You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/09/28 00:19:37 UTC
Review Request 62648: Added a test for nested container resource
limitations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62648/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Qian Zhang.
Bugs: MESOS-7963
https://issues.apache.org/jira/browse/MESOS-7963
Repository: mesos
Description
-------
Added a test to verify that resource limitations incurred by a nested
container are propagated all the way back to the scheduler through a
`TASK_FAILED` status update.
Diffs
-----
src/tests/default_executor_tests.cpp dd1a6ad0d4e2bf74972e15b478652196ee9cd927
Diff: https://reviews.apache.org/r/62648/diff/1/
Testing
-------
make check (Fedora 26)
Thanks,
James Peach
Re: Review Request 62648: Added a test for nested container resource
limitations.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62648/#review186974
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/default_executor_tests.cpp
Lines 1461-1482 (patched)
<https://reviews.apache.org/r/62648/#comment263923>
Do you still need this?
src/tests/default_executor_tests.cpp
Lines 1485 (patched)
<https://reviews.apache.org/r/62648/#comment263924>
I would suggest we just set `container_disk_watch_interval` to be a smaller value
- Jie Yu
On Sept. 28, 2017, 12:19 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62648/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2017, 12:19 a.m.)
>
>
> Review request for mesos, Jie Yu and Qian Zhang.
>
>
> Bugs: MESOS-7963
> https://issues.apache.org/jira/browse/MESOS-7963
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test to verify that resource limitations incurred by a nested
> container are propagated all the way back to the scheduler through a
> `TASK_FAILED` status update.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp dd1a6ad0d4e2bf74972e15b478652196ee9cd927
>
>
> Diff: https://reviews.apache.org/r/62648/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 62648: Added a test for nested container resource
limitations.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62648/#review186524
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['62640', '62641', '62642', '62643', '62644', '62646', '62647', '62648']`
Failed command: `C:\mesos\src\mesos-tests.exe --verbose --gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62648
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62648/logs/mesos-tests-stdout.log):
```
[ OK ] SchedulerHttpApiTest.NoContentType (194 ms)
[ RUN ] SchedulerHttpApiTest.ValidJsonButInvalidProtobuf
[ OK ] SchedulerHttpApiTest.ValidJsonButInvalidProtobuf (220 ms)
[ RUN ] SchedulerHttpApiTest.GetRequest
[ OK ] SchedulerHttpApiTest.GetRequest (193 ms)
[----------] 4 tests from SchedulerHttpApiTest (899 ms total)
[----------] 56 tests from SlaveTest
[ RUN ] SlaveTest.Shutdown
[ OK ] SlaveTest.Shutdown (682 ms)
[ RUN ] SlaveTest.DuplicateTerminalUpdateBeforeAck
[ OK ] SlaveTest.DuplicateTerminalUpdateBeforeAck (976 ms)
[ RUN ] SlaveTest.RemoveUnregisteredTerminatedExecutor
[ OK ] SlaveTest.RemoveUnregisteredTerminatedExecutor (733 ms)
[ RUN ] SlaveTest.CommandTaskWithKillPolicy
[ OK ] SlaveTest.CommandTaskWithKillPolicy (1901 ms)
[ RUN ] SlaveTest.IgnoreNonLeaderStatusUpdateAcknowledgement
[ OK ] SlaveTest.IgnoreNonLeaderStatusUpdateAcknowledgement (861 ms)
[ RUN ] SlaveTest.MetricsInMetricsEndpoint
[ OK ] SlaveTest.MetricsInMetricsEndpoint (589 ms)
[ RUN ] SlaveTest.MetricsSlaveLaunchErrors
[ OK ] SlaveTest.MetricsSlaveLaunchErrors (1147 ms)
[ RUN ] SlaveTest.StateEndpoint
[ OK ] SlaveTest.StateEndpoint (1148 ms)
[ RUN ] SlaveTest.GetStateTaskGroupPending
[ OK ] SlaveTest.GetStateTaskGroupPending (734 ms)
[ RUN ] SlaveTest.HTTPEndpointsBadAuthentication
[ OK ] SlaveTest.HTTPEndpointsBadAuthentication (592 ms)
[ RUN ] SlaveTest.ReadonlyHTTPEndpointsNoAuthentication
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62648/logs/mesos-tests-stderr.log):
```
I0928 03:43:45.304687 28984 slave.cpp:585] Agent resources: [{"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}]
I0928 03:43:45.325688 28984 slave.cpp:593] Agent attributes: [ ]
I0928 03:43:45.325688 28984 slave.cpp:602] Agent hostname: mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0928 03:43:45.325688 28988 status_update_manager.cpp:177] Pausing sending status updates
I0928 03:43:45.336688 28924 state.cpp:64] Recovering state from 'C:\Users\mesos\AppData\Local\Temp\2\CrFOp7\meta'
I0928 03:43:45.337689 27020 status_update_manager.cpp:203] Recovering status update manager
I0928 03:43:45.338690 27092 containerizer.cpp:649] Recovering containerizer
I0928 03:43:45.345688 28984 provisioner.cpp:416] Provisioner recovery complete
I0928 03:43:45.347689 28988 slave.cpp:6322] Finished recovery
I0928 03:43:45.357689 28784 status_update_manager.cpp:177] Pausing sending status updates
I0928 03:43:45.357689 29160 slave.cpp:1002] New master detected at master@10.3.1.7:49607
I0928 03:43:45.357689 29160 slave.cpp:1026] No credentials provided. Attempting to register without authentication
I0928 03:43:45.376688 29160 slave.cpp:1037] Detecting new master
I0928 03:43:45.474692 28628 slave.cpp:869] Agent terminating
I0928 03:43:45.512692 28628 master.cpp:1163] Master terminating
I0928 03:43:45.600694 28628 cluster.cpp:162] Creating default 'local' authorizer
I0928 03:43:45.628697 28984 master.cpp:445] Master 496872fd-6916-4aaf-beed-9e5639890f9f (mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) started on 10.3.1.7:49607
I0928 03:43:45.628697 28984 master.cpp:447] Flags at startup: --acls="" --agent_ping_timeout="15secs" --agent_reregister_timeout="10mins" --allocation_interval="1secs" --allocator="HierarchicalDRF" --authenticate_agents="false" --authenticate_frameworks="false" --authenticate_http_frameworks="true" --authenticate_http_readonly="true" --authenticate_http_readwrite="true" --authenticators="crammd5" --authorizers="local" --credentials="C:\Users\mesos\AppData\Local\Temp\2\S7vhlb\credentials" --filter_gpu_resources="true" --framework_sorter="drf" --help="false" --hostname_lookup="true" --http_authenticators="basic" --http_framework_authenticators="basic" --initialize_driver_logging="true" --log_auto_initialize="true" --logbufsecs="0" --logging_level="INFO" --max_agent_ping_timeouts="5" --max_completed_frameworks="50" --max_completed_tasks_per_framework="1000" --max_unreachable_tasks_per_framework="1000" --port="5050" --quiet="false" --recovery_agent_removal_limit="100%" --registry="in_mem
ory" --registry_fetch_timeout="1mins" --registry_gc_interval="15mins" --registry_max_agent_age="2weeks" --registry_max_agent_count="102400" --registry_store_timeout="100secs" --registry_strict="false" --root_submissions="true" --user_sorter="drf" --version="false" --webui_dir="/webui" --work_dir="C:\Users\mesos\AppData\Local\Temp\2\S7vhlb\master" --zk_session_timeout="10secs"
I0928 03:43:45.643790 28984 master.cpp:524] Master only allowing authenticated HTTP frameworks to register
I0928 03:43:45.643790 28984 credentials.hpp:37] Loading credentials for authentication from 'C:\Users\mesos\AppData\Local\Temp\2\S7vhlb\credentials'
I0928 03:43:45.656697 28984 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-master-readonly'
I0928 03:43:45.657696 28984 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-master-readwrite'
I0928 03:43:45.658696 28984 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-master-scheduler'
I0928 03:43:45.659698 28984 master.cpp:649] Authorization enabled
I0928 03:43:45.685696 28784 master.cpp:2166] Elected as the leading master!
I0928 03:43:45.685696 28784 master.cpp:1705] Recovering from registrar
I0928 03:43:45.687700 29392 registrar.cpp:391] Successfully fetched the registry (0B) in 1.003008ms
I0928 03:43:45.688699 29392 registrar.cpp:495] Applied 1 operations in 0ns; attempting to update the registry
I0928 03:43:45.690827 27020 registrar.cpp:552] Successfully updated the registry in 2.128128ms
I0928 03:43:45.691699```
- Mesos Reviewbot Windows
On Sept. 28, 2017, 12:19 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62648/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2017, 12:19 a.m.)
>
>
> Review request for mesos, Jie Yu and Qian Zhang.
>
>
> Bugs: MESOS-7963
> https://issues.apache.org/jira/browse/MESOS-7963
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test to verify that resource limitations incurred by a nested
> container are propagated all the way back to the scheduler through a
> `TASK_FAILED` status update.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp dd1a6ad0d4e2bf74972e15b478652196ee9cd927
>
>
> Diff: https://reviews.apache.org/r/62648/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 62648: Added a test for nested container resource
limitations.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62648/#review187504
-----------------------------------------------------------
Patch looks great!
Reviews applied: [62640, 62641, 62642, 62854, 62643, 62644, 62646, 62647, 62648]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 10, 2017, 12:24 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62648/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2017, 12:24 a.m.)
>
>
> Review request for mesos, Jie Yu and Qian Zhang.
>
>
> Bugs: MESOS-7963
> https://issues.apache.org/jira/browse/MESOS-7963
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test to verify that resource limitations incurred by a nested
> container are propagated all the way back to the scheduler through a
> `TASK_FAILED` status update.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp 2b4c643b8fb2fc8f2a5e98984ae1c267f66885d1
>
>
> Diff: https://reviews.apache.org/r/62648/diff/2/
>
>
> Testing
> -------
>
> make check (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 62648: Added a test for nested container resource
limitations.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62648/#review187489
-----------------------------------------------------------
PASS: Mesos patch 62648 was successfully built and tested.
Reviews applied: `['62640', '62641', '62642', '62854', '62643', '62644', '62646', '62647', '62648']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62648
- Mesos Reviewbot Windows
On Oct. 10, 2017, 12:24 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62648/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2017, 12:24 a.m.)
>
>
> Review request for mesos, Jie Yu and Qian Zhang.
>
>
> Bugs: MESOS-7963
> https://issues.apache.org/jira/browse/MESOS-7963
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test to verify that resource limitations incurred by a nested
> container are propagated all the way back to the scheduler through a
> `TASK_FAILED` status update.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp 2b4c643b8fb2fc8f2a5e98984ae1c267f66885d1
>
>
> Diff: https://reviews.apache.org/r/62648/diff/2/
>
>
> Testing
> -------
>
> make check (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 62648: Added a test for nested container resource
limitations.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62648/#review187655
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On Oct. 10, 2017, 8:24 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62648/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2017, 8:24 a.m.)
>
>
> Review request for mesos, Jie Yu and Qian Zhang.
>
>
> Bugs: MESOS-7963
> https://issues.apache.org/jira/browse/MESOS-7963
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test to verify that resource limitations incurred by a nested
> container are propagated all the way back to the scheduler through a
> `TASK_FAILED` status update.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp 2b4c643b8fb2fc8f2a5e98984ae1c267f66885d1
>
>
> Diff: https://reviews.apache.org/r/62648/diff/2/
>
>
> Testing
> -------
>
> make check (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 62648: Added a test for nested container resource
limitations.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62648/
-----------------------------------------------------------
(Updated Oct. 10, 2017, 12:24 a.m.)
Review request for mesos, Jie Yu and Qian Zhang.
Bugs: MESOS-7963
https://issues.apache.org/jira/browse/MESOS-7963
Repository: mesos
Description
-------
Added a test to verify that resource limitations incurred by a nested
container are propagated all the way back to the scheduler through a
`TASK_FAILED` status update.
Diffs (updated)
-----
src/tests/default_executor_tests.cpp 2b4c643b8fb2fc8f2a5e98984ae1c267f66885d1
Diff: https://reviews.apache.org/r/62648/diff/2/
Changes: https://reviews.apache.org/r/62648/diff/1-2/
Testing
-------
make check (Fedora 26)
Thanks,
James Peach