You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "yunlongn (via GitHub)" <gi...@apache.org> on 2023/08/01 09:07:04 UTC
[GitHub] [shenyu] yunlongn commented on a diff in pull request #4941: [fix:bug] Fix admin sync bug
yunlongn commented on code in PR #4941:
URL: https://github.com/apache/shenyu/pull/4941#discussion_r1280326292
##########
shenyu-common/src/main/java/org/apache/shenyu/common/dto/convert/selector/DubboUpstream.java:
##########
@@ -246,8 +246,6 @@ public boolean equals(final Object o) {
}
DubboUpstream that = (DubboUpstream) o;
return port == that.port
- && weight == that.weight
- && warmup == that.warmup
Review Comment:
These two are not the key factors. See `DivideUpstream#equals`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org