You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by Alex Heneveld <al...@cloudsoftcorp.com> on 2014/09/26 10:30:54 UTC
Re: Broken build - I smell a RAT
+1 to buildhive reviewing PR's
Also it should send notifications if brooklyn master is ever unhealthy.
Thirdly being more aware that the RAT will bite you for the smallest
misdemeanor. I've seen quite a few PR's missing headers and breaking
the build but most of these have been caught early. In the case below it
was some text files I added, confident they won't cause compilation or
test failures so skipping the full build and of course forgetting about
the pesky rodent.
Lastly there is no doubt build time is an issue. While we can do a few
small things to speed up build time a little I think we'd need a major
change to project structure to speed it up significantly, and I think
any such change would lead to other bigger problems. Thoughts? One
workflow addition I've found helpful is to have a staging `brooklyn-2`
directory whose git origin is the normal `brooklyn` dir; I pull a
putative merge to `brooklyn-2` and run my `mvn clean install` there so I
can continue working in my main `brooklyn` dir on a different branch and
without maven disrupting my IDE. Not rocket science but effective.
Best
Alex
On 24/09/2014 12:27, Aled Sage wrote:
> Hi,
>
> We need buildhive to run against each PR branch of
> https://github.com/apache/incubator-brooklyn
>
> *Andrew* and/or *Richard*, did you look at this previously? Where did
> we get to with that?
>
> Aled
>
>
> On 24/09/2014 11:57, Richard Downer wrote:
>> All,
>>
>> Thanks Alex for resolving this issue, BUT.... how did we get into this
>> situation in the first place? What commit caused this breakage, how
>> did it get merged, and how did nobody notice that it broke the build?
>>
>> (You can consider these rhetorical questions.)
>>
>> Let's learn the lessons and make sure that processes and/or tools are
>> changed to prevent this happening again.
>>
>> Richard.
>>
>>
>>
>> On 23 September 2014 23:07, Bhairavi Sankar (JIRA) <ji...@apache.org>
>> wrote:
>>> Bhairavi Sankar created BROOKLYN-69:
>>> ---------------------------------------
>>>
>>> Summary: Build Failure of incubator-brooklyn
>>> Key: BROOKLYN-69
>>> URL:
>>> https://issues.apache.org/jira/browse/BROOKLYN-69
>>> Project: Brooklyn
>>> Issue Type: Bug
>>> Reporter: Bhairavi Sankar
>>>
>>>
>>> I did a git pull --rebase of incubator-brooklyn and then on running
>>> the maven command to build: mvn clean install -DskipTests I get a
>>> build failure
>>>
>>> [ERROR] Failed to execute goal
>>> org.apache.rat:apache-rat-plugin:0.10:check (default) on project
>>> brooklyn-core: Too many files with unapproved license: 1 See RAT
>>> report in: /home/adminuser/git/brooklyn/core/target/rat.txt -> [Help 1]
>>>
>>> Content of /home/adminuser/git/brooklyn/core/target/rat.txt -
>>> 1 Unknown Licenses
>>> *******************************
>>> Unapproved licenses:
>>> /home/adminuser/git/brooklyn/core/src/test/resources/hello-world.txt
>>>
>>> Here is my git log:
>>> commit 10d566e78d3895c117e710c9b523d98e28e6eec8
>>>
>>> git status: working directory clean. Nothing to commit
>>>
>>>
>>> Let me know if you need any further information
>>>
>>>
>>>
>>>
>>>
>>> --
>>> This message was sent by Atlassian JIRA
>>> (v6.3.4#6332)
>
>
Re: Broken build - I smell a RAT
Posted by Richard Downer <ri...@apache.org>.
Hi Alex,
Yes this has been on my mind. I'm researching how we can get something
like this; it will no doubt involve the infra team's help so I'll
raise it on their lists / Jira / IRC.
Richard.
On 26 September 2014 09:30, Alex Heneveld
<al...@cloudsoftcorp.com> wrote:
>
> +1 to buildhive reviewing PR's
>
> Also it should send notifications if brooklyn master is ever unhealthy.
>
> Thirdly being more aware that the RAT will bite you for the smallest
> misdemeanor. I've seen quite a few PR's missing headers and breaking the
> build but most of these have been caught early. In the case below it was
> some text files I added, confident they won't cause compilation or test
> failures so skipping the full build and of course forgetting about the pesky
> rodent.
>
> Lastly there is no doubt build time is an issue. While we can do a few
> small things to speed up build time a little I think we'd need a major
> change to project structure to speed it up significantly, and I think any
> such change would lead to other bigger problems. Thoughts? One workflow
> addition I've found helpful is to have a staging `brooklyn-2` directory
> whose git origin is the normal `brooklyn` dir; I pull a putative merge to
> `brooklyn-2` and run my `mvn clean install` there so I can continue working
> in my main `brooklyn` dir on a different branch and without maven disrupting
> my IDE. Not rocket science but effective.
>
> Best
> Alex
>
>
> On 24/09/2014 12:27, Aled Sage wrote:
>>
>> Hi,
>>
>> We need buildhive to run against each PR branch of
>> https://github.com/apache/incubator-brooklyn
>>
>> *Andrew* and/or *Richard*, did you look at this previously? Where did we
>> get to with that?
>>
>> Aled
>>
>>
>> On 24/09/2014 11:57, Richard Downer wrote:
>>>
>>> All,
>>>
>>> Thanks Alex for resolving this issue, BUT.... how did we get into this
>>> situation in the first place? What commit caused this breakage, how
>>> did it get merged, and how did nobody notice that it broke the build?
>>>
>>> (You can consider these rhetorical questions.)
>>>
>>> Let's learn the lessons and make sure that processes and/or tools are
>>> changed to prevent this happening again.
>>>
>>> Richard.
>>>
>>>
>>>
>>> On 23 September 2014 23:07, Bhairavi Sankar (JIRA) <ji...@apache.org>
>>> wrote:
>>>>
>>>> Bhairavi Sankar created BROOKLYN-69:
>>>> ---------------------------------------
>>>>
>>>> Summary: Build Failure of incubator-brooklyn
>>>> Key: BROOKLYN-69
>>>> URL: https://issues.apache.org/jira/browse/BROOKLYN-69
>>>> Project: Brooklyn
>>>> Issue Type: Bug
>>>> Reporter: Bhairavi Sankar
>>>>
>>>>
>>>> I did a git pull --rebase of incubator-brooklyn and then on running the
>>>> maven command to build: mvn clean install -DskipTests I get a build failure
>>>>
>>>> [ERROR] Failed to execute goal
>>>> org.apache.rat:apache-rat-plugin:0.10:check (default) on project
>>>> brooklyn-core: Too many files with unapproved license: 1 See RAT report in:
>>>> /home/adminuser/git/brooklyn/core/target/rat.txt -> [Help 1]
>>>>
>>>> Content of /home/adminuser/git/brooklyn/core/target/rat.txt -
>>>> 1 Unknown Licenses
>>>> *******************************
>>>> Unapproved licenses:
>>>> /home/adminuser/git/brooklyn/core/src/test/resources/hello-world.txt
>>>>
>>>> Here is my git log:
>>>> commit 10d566e78d3895c117e710c9b523d98e28e6eec8
>>>>
>>>> git status: working directory clean. Nothing to commit
>>>>
>>>>
>>>> Let me know if you need any further information
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> This message was sent by Atlassian JIRA
>>>> (v6.3.4#6332)
>>
>>
>>
>