You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joshua Cohen <jc...@apache.org> on 2016/12/06 16:22:34 UTC
Review Request 54428: Fix invalid logging that was causing pmd to NPE.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54428/
-----------------------------------------------------------
Review request for Aurora and Stephan Erb.
Repository: aurora
Description
-------
Fix invalid logging that was causing pmd to NPE.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java ae7d019097f3e7049622623b48f3731198a08fb0
Diff: https://reviews.apache.org/r/54428/diff/
Testing
-------
Thanks,
Joshua Cohen
Re: Review Request 54428: Fix invalid logging that was causing pmd to
NPE.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54428/#review158176
-----------------------------------------------------------
Master (4bc5246) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Dec. 6, 2016, 4:22 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54428/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2016, 4:22 p.m.)
>
>
> Review request for Aurora and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix invalid logging that was causing pmd to NPE.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java ae7d019097f3e7049622623b48f3731198a08fb0
>
> Diff: https://reviews.apache.org/r/54428/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 54428: Fix invalid logging that was causing pmd to
NPE.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54428/#review158201
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Dec. 6, 2016, 8:22 a.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54428/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2016, 8:22 a.m.)
>
>
> Review request for Aurora and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix invalid logging that was causing pmd to NPE.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java ae7d019097f3e7049622623b48f3731198a08fb0
>
> Diff: https://reviews.apache.org/r/54428/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 54428: Fix invalid logging that was causing pmd to
NPE.
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54428/#review158172
-----------------------------------------------------------
Ship it!
Ship It!
- Stephan Erb
On Dec. 6, 2016, 5:22 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54428/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2016, 5:22 p.m.)
>
>
> Review request for Aurora and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix invalid logging that was causing pmd to NPE.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java ae7d019097f3e7049622623b48f3731198a08fb0
>
> Diff: https://reviews.apache.org/r/54428/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joshua Cohen
>
>