Re: [PR] Honor SMTP connection host/port and extra in send_mime_email [airflow]

["eladkal (via GitHub)" <gi...@apache.org>]

eladkal commented on code in PR #66764:
URL: https://github.com/apache/airflow/pull/66764#discussion_r3409106220


##########
airflow-core/src/airflow/utils/email.py:
##########
@@ -251,6 +259,19 @@ def send_mime_email(
             airflow_conn = Connection.get_connection_from_secrets(conn_id)
             smtp_user = airflow_conn.login
             smtp_password = airflow_conn.password
+            if airflow_conn.host:

Review Comment:
   This is probably not how we want to solve the issue.
   
   SMTP is planned to be migrated to smtp provider
   https://github.com/apache/airflow/pull/30531
   
   The fix should not be in airflow core.
   
   cc @hussein-awala @phanikumv @kaxil we probably need to find a path forward here. I think this is the last part that is still confusing between providers and core.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org