You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by cd...@apache.org on 2022/08/29 12:46:59 UTC

[plc4x] 03/03: chore(plc4j/modbus): Included Modbus in discovery

This is an automated email from the ASF dual-hosted git repository.

cdutz pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/plc4x.git

commit 682f3f7248c099e7af183d3f90ab28fe0e4145de
Author: Christofer Dutz <ch...@c-ware.de>
AuthorDate: Mon Aug 29 14:46:43 2022 +0200

    chore(plc4j/modbus): Included Modbus in discovery
---
 .../helloplc4x/discoverandbrowse/HelloPlc4xDiscoverAndBrowse.java     | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/plc4j/examples/hello-world-plc4x-discover-and-browse/src/main/java/org/apache/plc4x/java/examples/helloplc4x/discoverandbrowse/HelloPlc4xDiscoverAndBrowse.java b/plc4j/examples/hello-world-plc4x-discover-and-browse/src/main/java/org/apache/plc4x/java/examples/helloplc4x/discoverandbrowse/HelloPlc4xDiscoverAndBrowse.java
index 0af740fc8..33302f38d 100644
--- a/plc4j/examples/hello-world-plc4x-discover-and-browse/src/main/java/org/apache/plc4x/java/examples/helloplc4x/discoverandbrowse/HelloPlc4xDiscoverAndBrowse.java
+++ b/plc4j/examples/hello-world-plc4x-discover-and-browse/src/main/java/org/apache/plc4x/java/examples/helloplc4x/discoverandbrowse/HelloPlc4xDiscoverAndBrowse.java
@@ -36,10 +36,6 @@ public class HelloPlc4xDiscoverAndBrowse {
         // Iterate over all installed drivers and execute their browse functionality (If they support it)
         PlcDriverManager driverManager = new PlcDriverManager();
         for (String protocolCode : driverManager.listDrivers()) {
-            // For some reason modbus is failing on my machine ... investigate
-            if(protocolCode.startsWith("modbus")) {
-                continue;
-            }
             PlcDriver driver = driverManager.getDriver(protocolCode);
             if(driver.getMetadata().canDiscover()) {
                 logger.info("Performing discovery for {} protocol", driver.getProtocolName());