You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2018/07/04 02:37:34 UTC
[7/7] james-project git commit: JAMES-2449 MailQueue::browse should
not snapshot isolated
JAMES-2449 MailQueue::browse should not snapshot isolated
Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/3f842386
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/3f842386
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/3f842386
Branch: refs/heads/master
Commit: 3f8423860ec64954a1f5923c39ee6ab0c0576d05
Parents: b318027
Author: benwa <bt...@linagora.com>
Authored: Tue Jul 3 09:58:22 2018 +0700
Committer: benwa <bt...@linagora.com>
Committed: Wed Jul 4 09:36:38 2018 +0700
----------------------------------------------------------------------
.../queue/api/ManageableMailQueueContract.java | 20 --------------------
.../james/queue/file/FileMailQueueTest.java | 7 -------
2 files changed, 27 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/james-project/blob/3f842386/server/queue/queue-api/src/test/java/org/apache/james/queue/api/ManageableMailQueueContract.java
----------------------------------------------------------------------
diff --git a/server/queue/queue-api/src/test/java/org/apache/james/queue/api/ManageableMailQueueContract.java b/server/queue/queue-api/src/test/java/org/apache/james/queue/api/ManageableMailQueueContract.java
index 42aed12..00bac8d 100644
--- a/server/queue/queue-api/src/test/java/org/apache/james/queue/api/ManageableMailQueueContract.java
+++ b/server/queue/queue-api/src/test/java/org/apache/james/queue/api/ManageableMailQueueContract.java
@@ -226,26 +226,6 @@ public interface ManageableMailQueueContract extends MailQueueContract {
}
@Test
- default void concurrentEnqueueShouldNotAlterBrowsing() throws Exception {
- getManageableMailQueue().enQueue(defaultMail()
- .name("name1")
- .build());
- getManageableMailQueue().enQueue(defaultMail()
- .name("name2")
- .build());
-
- ManageableMailQueue.MailQueueIterator items = getManageableMailQueue().browse();
-
- getManageableMailQueue().enQueue(defaultMail()
- .name("name3")
- .build());
-
- assertThat(items).extracting(ManageableMailQueue.MailQueueItemView::getMail)
- .extracting(Mail::getName)
- .containsExactly("name1", "name2");
- }
-
- @Test
default void concurrentFlushShouldNotAlterBrowsingWhenDequeueWhileIterating() throws Exception {
getManageableMailQueue().enQueue(defaultMail()
.name("name1")
http://git-wip-us.apache.org/repos/asf/james-project/blob/3f842386/server/queue/queue-file/src/test/java/org/apache/james/queue/file/FileMailQueueTest.java
----------------------------------------------------------------------
diff --git a/server/queue/queue-file/src/test/java/org/apache/james/queue/file/FileMailQueueTest.java b/server/queue/queue-file/src/test/java/org/apache/james/queue/file/FileMailQueueTest.java
index 056bea3..80deab3 100644
--- a/server/queue/queue-file/src/test/java/org/apache/james/queue/file/FileMailQueueTest.java
+++ b/server/queue/queue-file/src/test/java/org/apache/james/queue/file/FileMailQueueTest.java
@@ -94,13 +94,6 @@ public class FileMailQueueTest implements DelayedManageableMailQueueContract {
@Test
@Override
@Disabled("JAMES-2299 No snapshot isolation")
- public void concurrentEnqueueShouldNotAlterBrowsing() {
-
- }
-
- @Test
- @Override
- @Disabled("JAMES-2299 No snapshot isolation")
public void concurrentDequeueShouldNotAlterBrowsingWhenDequeueWhileIterating() {
}
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org