You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/10 02:32:23 UTC

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #472: Fix random printf format warnings and type mismatches

xiaoxiang781216 commented on a change in pull request #472:
URL: https://github.com/apache/incubator-nuttx-apps/pull/472#discussion_r520246777



##########
File path: include/graphics/nxwidgets/itextbox.hxx
##########
@@ -208,7 +208,7 @@ namespace NXWidgets
      * @return position The cursor position.
      */
 
-    virtual const int getCursorPosition(void) const = 0;
+    virtual const int32_t getCursorPosition(void) const = 0;

Review comment:
       should we change https://github.com/apache/incubator-nuttx-apps/blob/master/include/graphics/nxwidgets/cscrollingtextbox.hxx#L329 to int instead?
   moveCursorToPosition at https://github.com/apache/incubator-nuttx-apps/blob/master/include/graphics/nxwidgets/cscrollingtextbox.hxx#L320 also need to change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org