You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/09/27 21:55:20 UTC

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1379: nimble/transport: Add generic IPC transport with flow control

apache-mynewt-bot commented on PR #1379:
URL: https://github.com/apache/mynewt-nimble/pull/1379#issuecomment-1260094540

   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### nimble/transport/nrf5340/src/nrf5340_ble_hci.c
   <details>
   
   ```diff
   @@ -86,7 +86,7 @@
    ble_transport_to_hs_evt_impl(void *buf)
    {
        uint8_t ind = HCI_IPC_TYPE_EVT;
   -    uint8_t* hci_ev = buf;
   +    uint8_t * hci_ev = buf;
        int len = 2 + hci_ev[1];
        int rc;
    
   @@ -167,7 +167,7 @@
                          "   cmp r1, #0                  \n"
                          "   bne 1b                      \n"
                          : [ret] "=&r" (ret)
   -                      : [addr] "r"(num)
   +                      : [addr] "r" (num)
                          : "r1", "r2", "memory");
    
        return ret;
   @@ -183,6 +183,6 @@
                          "   cmp r2, #0                \n"
                          "   bne 1b                    \n"
                          :
   -                      : [addr] "r"(num)
   +                      : [addr] "r" (num)
                          : "r1", "r2", "memory");
    }
   ```
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org