You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by mebelousov <gi...@git.apache.org> on 2018/05/17 10:19:18 UTC
[GitHub] zeppelin pull request #2972: ZEPPELIN-3379. Refactoring of JDBC autocomplete...
GitHub user mebelousov opened a pull request:
https://github.com/apache/zeppelin/pull/2972
ZEPPELIN-3379. Refactoring of JDBC autocomplete.
### What is this PR for?
Current implementation of autocomplete allows only completion in `schema.table.column` scenario. Such scenario exclude tables for default schema.
The PR fixes the scenario with tables in default schema and alias processing.
Also I want to add feature to complete columns for used tables in statement from blank cursor.
The autocomplete was tested for Greenplum 4.3 (PostgreSQL), Oracle 11g, MySQL (Hive Metastore) and Hive.
This PR is reopening of #2970
### What type of PR is it?
Improvement
### What is the Jira issue?
[https://issues.apache.org/jira/browse/ZEPPELIN-3379](ZEPPELIN-3379)
### How should this be tested?
* Manually
* Tests pass
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3379
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2972.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2972
----
commit 10f70cedb49e7fa5c78c19a9bf29354eece6d090
Author: Maxim Belousov <me...@...>
Date: 2018-05-17T09:31:33Z
ZEPPELIN-3379 Refactoring of SQL autocomplete
commit 9a3a4874fd8be5c8e01db87b8f0ff158e8b34a7a
Author: Maxim Belousov <me...@...>
Date: 2018-05-17T09:32:36Z
Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-3379-JDBC
commit 42d9decf761ed3fa52633565dc4363fb82e55b08
Author: Maxim Belousov <me...@...>
Date: 2018-05-17T09:51:55Z
ZEPPELIN-3379 Removed double star from license test
----
---
[GitHub] zeppelin issue #2972: ZEPPELIN-3379. Refactoring of JDBC autocomplete.
Posted by mebelousov <gi...@git.apache.org>.
Github user mebelousov commented on the issue:
https://github.com/apache/zeppelin/pull/2972
Will revert when anyone could test this PR.
---
[GitHub] zeppelin pull request #2972: ZEPPELIN-3379. Refactoring of JDBC autocomplete...
Posted by mebelousov <gi...@git.apache.org>.
Github user mebelousov closed the pull request at:
https://github.com/apache/zeppelin/pull/2972
---
[GitHub] zeppelin issue #2972: ZEPPELIN-3379. Refactoring of JDBC autocomplete.
Posted by mebelousov <gi...@git.apache.org>.
Github user mebelousov commented on the issue:
https://github.com/apache/zeppelin/pull/2972
Hi @anirbanch !
I have adopted PR to branch 0.8 and have created patch (can be founded in linked JIRA issue).
You can apply patch and build jars.
On your risks you can
1. Replace next files (from linked JIRA issue)
$ZEPPELIN_HOME/interpreter/jdbc/zeppelin-jdbc-0.8.1-SNAPSHOT.jar
$ZEPPELIN_HOME/interpreter/jdbc/postgresql-native-driver-sql.keywords
$ZEPPELIN_HOME/lib/interpreter/zeppelin-interpreter-0.8.1-SNAPSHOT.jar
2. Set "completionSupport" to false in $ZEPPELIN_HOME/interpreter/jdbc/interpreter-setting.json
also you can add `"completionKey": "TAB"` to editor key
3. Run Zeppelin.
---
[GitHub] zeppelin issue #2972: ZEPPELIN-3379. Refactoring of JDBC autocomplete.
Posted by anirbanch <gi...@git.apache.org>.
Github user anirbanch commented on the issue:
https://github.com/apache/zeppelin/pull/2972
@mebelousov would need this functionality, how can I help?
---