You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "neo-ytx (via GitHub)" <gi...@apache.org> on 2023/05/18 15:43:23 UTC
[GitHub] [tomcat] neo-ytx opened a new pull request, #617: #MessageBytes toString rollback
neo-ytx opened a new pull request, #617:
URL: https://github.com/apache/tomcat/pull/617
1. I think toString method should not change the object's status. Because this method is used for return a String. Most people think they can get object's stringValue from this method, and will not change the object's status.
2. The issue I found: After I integrate openTelemetry with my tomcat web services, the service always return 404. The openTelemetry use the toString method, then tomcat think it is a str not byte and return 404 error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] aooohan commented on pull request #617: #MessageBytes toString rollback
Posted by "aooohan (via GitHub)" <gi...@apache.org>.
aooohan commented on PR #617:
URL: https://github.com/apache/tomcat/pull/617#issuecomment-1556434703
> Thanks a lot~. And I still have one question: Is the toString method changing object status a good behavior?
No, not a good behavior. This Class has been refactored before to solve some issues, and I'm not familiar with this, you can post your question to user mailing list to discuss. ; )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] neo-ytx commented on pull request #617: #MessageBytes toString rollback
Posted by "neo-ytx (via GitHub)" <gi...@apache.org>.
neo-ytx commented on PR #617:
URL: https://github.com/apache/tomcat/pull/617#issuecomment-1554184173
Thanks a lot~. And I still have one question: Is the toString method changing object status a good behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] aooohan commented on pull request #617: #MessageBytes toString rollback
Posted by "aooohan (via GitHub)" <gi...@apache.org>.
aooohan commented on PR #617:
URL: https://github.com/apache/tomcat/pull/617#issuecomment-1553952940
Hmm. A similar issue has been raised by other user before, look this https://lists.apache.org/list?users@tomcat.apache.org:2023-3:openTelemetry
Hope this helps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] aooohan closed pull request #617: #MessageBytes toString rollback
Posted by "aooohan (via GitHub)" <gi...@apache.org>.
aooohan closed pull request #617: #MessageBytes toString rollback
URL: https://github.com/apache/tomcat/pull/617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org