You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2018/09/17 01:28:14 UTC
Review Request 68728: Added rapidjson to RPM spec file.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68728/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Till Toenshoff.
Bugs: MESOS-9238
https://issues.apache.org/jira/browse/MESOS-9238
Repository: mesos
Description
-------
We didn't update the RPM spec file when we added the rapidjson
dependencies. This will cause RPM build to fail like the following:
RPM build errors:
error: Installed (but unpackaged) file(s) found:
/usr/include/rapidjson/allocators.h
/usr/include/rapidjson/document.h
...
This patch fixed it by adding the rapidjson headers to the %files
section accordingly.
Diffs
-----
support/packaging/centos/mesos.spec 053298522ee198b3b23004ff9ce73aa60a39e8a4
Diff: https://reviews.apache.org/r/68728/diff/1/
Testing
-------
Thanks,
Jie Yu
Re: Review Request 68728: Added rapidjson to RPM spec file.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68728/#review208671
-----------------------------------------------------------
Ship it!
Oh, I didn't think to look here =/
Thanks for taking care of it!
- Benjamin Mahler
On Sept. 17, 2018, 1:28 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68728/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2018, 1:28 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Bugs: MESOS-9238
> https://issues.apache.org/jira/browse/MESOS-9238
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We didn't update the RPM spec file when we added the rapidjson
> dependencies. This will cause RPM build to fail like the following:
>
> RPM build errors:
> error: Installed (but unpackaged) file(s) found:
> /usr/include/rapidjson/allocators.h
> /usr/include/rapidjson/document.h
> ...
>
> This patch fixed it by adding the rapidjson headers to the %files
> section accordingly.
>
>
> Diffs
> -----
>
> support/packaging/centos/mesos.spec 053298522ee198b3b23004ff9ce73aa60a39e8a4
>
>
> Diff: https://reviews.apache.org/r/68728/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 68728: Added rapidjson to RPM spec file.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68728/#review208677
-----------------------------------------------------------
FAIL: Failed to apply the current review.
Failed command: `python.exe .\support\apply-reviews.py -n -r 68728`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2343/mesos-review-68728
Relevant logs:
- [apply-review-68728.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2343/mesos-review-68728/logs/apply-review-68728.log):
```
error: patch failed: support/packaging/centos/mesos.spec:161
error: support/packaging/centos/mesos.spec: patch does not apply
```
- Mesos Reviewbot Windows
On Sept. 17, 2018, 1:28 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68728/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2018, 1:28 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Bugs: MESOS-9238
> https://issues.apache.org/jira/browse/MESOS-9238
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We didn't update the RPM spec file when we added the rapidjson
> dependencies. This will cause RPM build to fail like the following:
>
> RPM build errors:
> error: Installed (but unpackaged) file(s) found:
> /usr/include/rapidjson/allocators.h
> /usr/include/rapidjson/document.h
> ...
>
> This patch fixed it by adding the rapidjson headers to the %files
> section accordingly.
>
>
> Diffs
> -----
>
> support/packaging/centos/mesos.spec 053298522ee198b3b23004ff9ce73aa60a39e8a4
>
>
> Diff: https://reviews.apache.org/r/68728/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 68728: Added rapidjson to RPM spec file.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68728/#review208675
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Sept. 17, 2018, 1:28 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68728/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2018, 1:28 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Bugs: MESOS-9238
> https://issues.apache.org/jira/browse/MESOS-9238
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We didn't update the RPM spec file when we added the rapidjson
> dependencies. This will cause RPM build to fail like the following:
>
> RPM build errors:
> error: Installed (but unpackaged) file(s) found:
> /usr/include/rapidjson/allocators.h
> /usr/include/rapidjson/document.h
> ...
>
> This patch fixed it by adding the rapidjson headers to the %files
> section accordingly.
>
>
> Diffs
> -----
>
> support/packaging/centos/mesos.spec 053298522ee198b3b23004ff9ce73aa60a39e8a4
>
>
> Diff: https://reviews.apache.org/r/68728/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jie Yu
>
>