You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2022/06/05 13:48:54 UTC

svn commit: r1901675 - /pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDTerminalField.java

Author: tilman
Date: Sun Jun  5 13:48:54 2022
New Revision: 1901675

URL: http://svn.apache.org/viewvc?rev=1901675&view=rev
Log:
PDFBOX-4892: optimize / refactor, as suggested by Valery Bokov

Modified:
    pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDTerminalField.java

Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDTerminalField.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDTerminalField.java?rev=1901675&r1=1901674&r2=1901675&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDTerminalField.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDTerminalField.java Sun Jun  5 13:48:54 2022
@@ -101,10 +101,9 @@ public abstract class PDTerminalField ex
     {
         super.importFDF(fdfField);
         
+        Integer f = fdfField.getWidgetFieldFlags();
         for (PDAnnotationWidget widget : getWidgets())
         {
-            int annotFlags = widget.getAnnotationFlags();
-            Integer f = fdfField.getWidgetFieldFlags();
             if (f != null)
             {
                 widget.setAnnotationFlags(f);
@@ -113,6 +112,7 @@ public abstract class PDTerminalField ex
             {
                 // these are supposed to be ignored if the F is set.
                 Integer setF = fdfField.getSetWidgetFieldFlags();
+                int annotFlags = widget.getAnnotationFlags();
                 if (setF != null)
                 {
                     annotFlags = annotFlags | setF;