You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2023/08/05 07:07:18 UTC

[GitHub] [shardingsphere] terrymanu opened a new issue, #27932: Add test case for ResultSetMapper and DialectResultSetMapper impls

terrymanu opened a new issue, #27932:
URL: https://github.com/apache/shardingsphere/issues/27932

   Add test cases on:
   
   - [ ] ResultSetMapper
   - [ ] MySQLResultSetMapper
   - [ ] PostgreSQLResultSetMapper
   - [ ] OpenGaussResultSetMapper


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] xdevore commented on issue #27932: Add test case for ResultSetMapper and DialectResultSetMapper impls

Posted by "xdevore (via GitHub)" <gi...@apache.org>.
xdevore commented on issue #27932:
URL: https://github.com/apache/shardingsphere/issues/27932#issuecomment-1679492556

   Great, thank you so much! Will do :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] xdevore commented on issue #27932: Add test case for ResultSetMapper and DialectResultSetMapper impls

Posted by "xdevore (via GitHub)" <gi...@apache.org>.
xdevore commented on issue #27932:
URL: https://github.com/apache/shardingsphere/issues/27932#issuecomment-1666974457

   Hello! I'd love to try take this on! I'm new to open source and fairly new to programming in general - would it be possible to write tests for just ResultSetMapper and check in to see if I'm on the right track? Thanks so much. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add test case for ResultSetMapper and DialectResultSetMapper impls [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu closed issue #27932: Add test case for ResultSetMapper and DialectResultSetMapper impls
URL: https://github.com/apache/shardingsphere/issues/27932


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] xdevore commented on issue #27932: Add test case for ResultSetMapper and DialectResultSetMapper impls

Posted by "xdevore (via GitHub)" <gi...@apache.org>.
xdevore commented on issue #27932:
URL: https://github.com/apache/shardingsphere/issues/27932#issuecomment-1686790747

   Hello! Sorry, I've been really busy - I will do my best to finish this soon. @jackyyyyyssss 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] jackyyyyyssss commented on issue #27932: Add test case for ResultSetMapper and DialectResultSetMapper impls

Posted by "jackyyyyyssss (via GitHub)" <gi...@apache.org>.
jackyyyyyssss commented on issue #27932:
URL: https://github.com/apache/shardingsphere/issues/27932#issuecomment-1687311924

   if you have question we can discuss together


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] jackyyyyyssss commented on issue #27932: Add test case for ResultSetMapper and DialectResultSetMapper impls

Posted by "jackyyyyyssss (via GitHub)" <gi...@apache.org>.
jackyyyyyssss commented on issue #27932:
URL: https://github.com/apache/shardingsphere/issues/27932#issuecomment-1683923164

   i will try MySQLResultSetMapper 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] jackyyyyyssss commented on issue #27932: Add test case for ResultSetMapper and DialectResultSetMapper impls

Posted by "jackyyyyyssss (via GitHub)" <gi...@apache.org>.
jackyyyyyssss commented on issue #27932:
URL: https://github.com/apache/shardingsphere/issues/27932#issuecomment-1686155863

   > 
   
   hello  Do you want to continue programming 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] xdevore commented on issue #27932: Add test case for ResultSetMapper and DialectResultSetMapper impls

Posted by "xdevore (via GitHub)" <gi...@apache.org>.
xdevore commented on issue #27932:
URL: https://github.com/apache/shardingsphere/issues/27932#issuecomment-1690733398

   Hi, @jackyyyyyssss ! I'm a little confused on writing tests for ResultSetMapper. Should I just test the load function? Would I go about that in the same way you have for the MySQLResultSetMapper with the DialectResultSetMapper? Thanks so much :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] yx9o commented on issue #27932: Add test case for ResultSetMapper and DialectResultSetMapper impls

Posted by "yx9o (via GitHub)" <gi...@apache.org>.
yx9o commented on issue #27932:
URL: https://github.com/apache/shardingsphere/issues/27932#issuecomment-1676301374

   Hi @xdevore , welcome, you can try it first, if you need any help, please leave a message.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] jackyyyyyssss commented on issue #27932: Add test case for ResultSetMapper and DialectResultSetMapper impls

Posted by "jackyyyyyssss (via GitHub)" <gi...@apache.org>.
jackyyyyyssss commented on issue #27932:
URL: https://github.com/apache/shardingsphere/issues/27932#issuecomment-1687314110

   Hello member  PostgreSQLResultSetMapper  OpenGaussResultSetMapperTest Is it necessary to abstract these two classes with similar code to their parent class


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add test case for ResultSetMapper and DialectResultSetMapper impls [shardingsphere]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #27932:
URL: https://github.com/apache/shardingsphere/issues/27932#issuecomment-1783911042

   There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org