You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/06/19 07:29:38 UTC
[GitHub] [echarts] pissang commented on a diff in pull request #17242: feat(treemap.breadcrumb): add `emphasis` state
pissang commented on code in PR #17242:
URL: https://github.com/apache/echarts/pull/17242#discussion_r901061118
##########
src/chart/treemap/TreemapSeries.ts:
##########
@@ -265,6 +266,9 @@ class TreemapSeriesModel extends SeriesModel<TreemapSeriesOption> {
textStyle: {
color: '#fff'
}
+ },
+ emphasis: {
+ disabled: true
Review Comment:
I think this nice new feature can be turned on by default in the 5.4
##########
src/chart/treemap/TreemapSeries.ts:
##########
@@ -265,6 +266,9 @@ class TreemapSeriesModel extends SeriesModel<TreemapSeriesOption> {
textStyle: {
color: '#fff'
}
+ },
+ emphasis: {
+ disabled: true
Review Comment:
I think this nice new feature can be enabled by default in the 5.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org