You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Minghui Zhu (Code Review)" <ge...@cloudera.org> on 2022/09/20 07:46:57 UTC
[Impala-ASF-CR] IMPALA-11555: external Udf support decimal(*, *)
Minghui Zhu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19021
Change subject: IMPALA-11555: external Udf support decimal(*, *)
......................................................................
IMPALA-11555: external Udf support decimal(*, *)
Increase syntax parsing and remove some restrictions.
Change-Id: I09f19da5b1660ed0b882497fc321e6cc1b9b55d0
---
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java
M fe/src/main/java/org/apache/impala/catalog/ScalarType.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
4 files changed, 16 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/19021/1
--
To view, visit http://gerrit.cloudera.org:8080/19021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I09f19da5b1660ed0b882497fc321e6cc1b9b55d0
Gerrit-Change-Number: 19021
Gerrit-PatchSet: 1
Gerrit-Owner: Minghui Zhu <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-11555: external Udf support decimal(*, *)
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19021 )
Change subject: IMPALA-11555: external Udf support decimal(*, *)
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11385/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09f19da5b1660ed0b882497fc321e6cc1b9b55d0
Gerrit-Change-Number: 19021
Gerrit-PatchSet: 1
Gerrit-Owner: Minghui Zhu <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Sep 2022 08:08:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11555: external Udf support decimal(*, *)
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19021 )
Change subject: IMPALA-11555: external Udf support decimal(*, *)
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11393/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09f19da5b1660ed0b882497fc321e6cc1b9b55d0
Gerrit-Change-Number: 19021
Gerrit-PatchSet: 3
Gerrit-Owner: Minghui Zhu <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Sep 2022 03:14:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11555: external Udf support decimal(*, *)
Posted by "Minghui Zhu (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19021
to look at the new patch set (#3).
Change subject: IMPALA-11555: external Udf support decimal(*, *)
......................................................................
IMPALA-11555: external Udf support decimal(*, *)
Increase syntax parsing and remove some restrictions.
Change-Id: I09f19da5b1660ed0b882497fc321e6cc1b9b55d0
---
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java
M fe/src/main/java/org/apache/impala/catalog/ScalarType.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
4 files changed, 17 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/19021/3
--
To view, visit http://gerrit.cloudera.org:8080/19021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I09f19da5b1660ed0b882497fc321e6cc1b9b55d0
Gerrit-Change-Number: 19021
Gerrit-PatchSet: 3
Gerrit-Owner: Minghui Zhu <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11555: external Udf support decimal(*, *)
Posted by "Jian Zhang (Code Review)" <ge...@cloudera.org>.
Jian Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19021 )
Change subject: IMPALA-11555: external Udf support decimal(*, *)
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19021/3/fe/src/main/java/org/apache/impala/catalog/ScalarType.java
File fe/src/main/java/org/apache/impala/catalog/ScalarType.java:
http://gerrit.cloudera.org:8080/#/c/19021/3/fe/src/main/java/org/apache/impala/catalog/ScalarType.java@a118
PS3, Line 118:
why remove this pre-condition? will these values be negative?
--
To view, visit http://gerrit.cloudera.org:8080/19021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09f19da5b1660ed0b882497fc321e6cc1b9b55d0
Gerrit-Change-Number: 19021
Gerrit-PatchSet: 3
Gerrit-Owner: Minghui Zhu <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Comment-Date: Thu, 22 Sep 2022 03:45:58 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11555: external Udf support decimal(*, *)
Posted by "Minghui Zhu (Code Review)" <ge...@cloudera.org>.
Minghui Zhu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19021 )
Change subject: IMPALA-11555: external Udf support decimal(*, *)
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19021/3/fe/src/main/java/org/apache/impala/catalog/ScalarType.java
File fe/src/main/java/org/apache/impala/catalog/ScalarType.java:
http://gerrit.cloudera.org:8080/#/c/19021/3/fe/src/main/java/org/apache/impala/catalog/ScalarType.java@a118
PS3, Line 118:
> why remove this pre-condition? will these values be negative?
yes, these values are -1
--
To view, visit http://gerrit.cloudera.org:8080/19021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09f19da5b1660ed0b882497fc321e6cc1b9b55d0
Gerrit-Change-Number: 19021
Gerrit-PatchSet: 3
Gerrit-Owner: Minghui Zhu <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Minghui Zhu <hu...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 28 Sep 2022 06:33:45 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11555: external Udf support decimal(*, *)
Posted by "Minghui Zhu (Code Review)" <ge...@cloudera.org>.
Minghui Zhu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19021 )
Change subject: IMPALA-11555: external Udf support decimal(*, *)
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19021/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19021/3//COMMIT_MSG@9
PS3, Line 9: Increase syntax parsing and remove some restrictions.
> To help others to understand the sense of "decimal(*, *)", could you please
I have written in https://issues.apache.org/jira/browse/IMPALA-11555
--
To view, visit http://gerrit.cloudera.org:8080/19021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09f19da5b1660ed0b882497fc321e6cc1b9b55d0
Gerrit-Change-Number: 19021
Gerrit-PatchSet: 3
Gerrit-Owner: Minghui Zhu <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Minghui Zhu <hu...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 30 Sep 2022 04:04:20 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11555: external Udf support decimal(*, *)
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19021 )
Change subject: IMPALA-11555: external Udf support decimal(*, *)
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11392/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09f19da5b1660ed0b882497fc321e6cc1b9b55d0
Gerrit-Change-Number: 19021
Gerrit-PatchSet: 2
Gerrit-Owner: Minghui Zhu <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Sep 2022 03:02:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11555: external Udf support decimal(*, *)
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19021 )
Change subject: IMPALA-11555: external Udf support decimal(*, *)
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19021/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java
File fe/src/test/java/org/apache/impala/analysis/ParserTest.java:
http://gerrit.cloudera.org:8080/#/c/19021/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2255
PS1, Line 2255: ParsesOk("CREATE AGGREGATE FUNCTIOn Foo(TIMESTAMP, DECIMAL(*, *)) RETURNS DECIMAL(*, *) " +
line too long (95 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/19021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09f19da5b1660ed0b882497fc321e6cc1b9b55d0
Gerrit-Change-Number: 19021
Gerrit-PatchSet: 1
Gerrit-Owner: Minghui Zhu <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Sep 2022 07:47:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11555: external Udf support decimal(*, *)
Posted by "Minghui Zhu (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19021
to look at the new patch set (#2).
Change subject: IMPALA-11555: external Udf support decimal(*, *)
......................................................................
IMPALA-11555: external Udf support decimal(*, *)
Increase syntax parsing and remove some restrictions.
Change-Id: I09f19da5b1660ed0b882497fc321e6cc1b9b55d0
---
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java
M fe/src/main/java/org/apache/impala/catalog/ScalarType.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
4 files changed, 17 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/19021/2
--
To view, visit http://gerrit.cloudera.org:8080/19021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I09f19da5b1660ed0b882497fc321e6cc1b9b55d0
Gerrit-Change-Number: 19021
Gerrit-PatchSet: 2
Gerrit-Owner: Minghui Zhu <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11555: external Udf support decimal(*, *)
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19021 )
Change subject: IMPALA-11555: external Udf support decimal(*, *)
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19021/2/fe/src/test/java/org/apache/impala/analysis/ParserTest.java
File fe/src/test/java/org/apache/impala/analysis/ParserTest.java:
http://gerrit.cloudera.org:8080/#/c/19021/2/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2255
PS2, Line 2255: ParsesOk("CREATE AGGREGATE FUNCTIOn Foo(TIMESTAMP, DECIMAL(*, *)) " +
line has trailing whitespace
--
To view, visit http://gerrit.cloudera.org:8080/19021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09f19da5b1660ed0b882497fc321e6cc1b9b55d0
Gerrit-Change-Number: 19021
Gerrit-PatchSet: 2
Gerrit-Owner: Minghui Zhu <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Sep 2022 02:42:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11555: external Udf support decimal(*, *)
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lipenglin@sensorsdata.cn has posted comments on this change. ( http://gerrit.cloudera.org:8080/19021 )
Change subject: IMPALA-11555: external Udf support decimal(*, *)
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19021/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19021/3//COMMIT_MSG@9
PS3, Line 9: Increase syntax parsing and remove some restrictions.
To help others to understand the sense of "decimal(*, *)", could you please give more description?
--
To view, visit http://gerrit.cloudera.org:8080/19021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09f19da5b1660ed0b882497fc321e6cc1b9b55d0
Gerrit-Change-Number: 19021
Gerrit-PatchSet: 3
Gerrit-Owner: Minghui Zhu <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Minghui Zhu <hu...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 28 Sep 2022 16:07:29 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11555: external Udf support decimal(*, *)
Posted by "Jian Zhang (Code Review)" <ge...@cloudera.org>.
Jian Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19021 )
Change subject: IMPALA-11555: external Udf support decimal(*, *)
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09f19da5b1660ed0b882497fc321e6cc1b9b55d0
Gerrit-Change-Number: 19021
Gerrit-PatchSet: 3
Gerrit-Owner: Minghui Zhu <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Minghui Zhu <hu...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 28 Sep 2022 07:51:07 +0000
Gerrit-HasComments: No