You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/06/23 13:07:50 UTC
[commons-net] branch master updated (dd6e8cd6 -> c6b66581)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git
from dd6e8cd6 NntpThreadContainer.flush() now throws IllegalStateException instead of RuntimeException.
new abaa661e org.apache.commons.net.nntp.Threader now throws IllegalStateException instead of RuntimeException.
new 672cdd46 POP3Command static initializer now throws IllegalStateException instead of RuntimeException.
new 1bb0eb61 FTPClientTest now throws IllegalStateException instead of RuntimeException.
new 51d1f869 SMTPCommand static initializer now throws IllegalStateException instead of RuntimeException.
new 5277c76d SubnetUtils.SubnetInfo.getPreviousAddress() now throws IllegalStateException instead of RuntimeException.
new c6b66581 Format tweak
The 6 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
src/changes/changes.xml | 12 ++++++++++++
src/main/java/org/apache/commons/net/nntp/Threader.java | 6 +++---
src/main/java/org/apache/commons/net/pop3/POP3Command.java | 2 +-
src/main/java/org/apache/commons/net/smtp/SMTPCommand.java | 3 +--
src/main/java/org/apache/commons/net/util/SubnetUtils.java | 2 +-
src/test/java/org/apache/commons/net/ftp/FTPClientTest.java | 2 +-
6 files changed, 19 insertions(+), 8 deletions(-)
[commons-net] 05/06: SubnetUtils.SubnetInfo.getPreviousAddress() now throws IllegalStateException instead of RuntimeException.
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git
commit 5277c76d43e7e74aeb1cbaed31da420e884db230
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Jun 23 09:07:14 2023 -0400
SubnetUtils.SubnetInfo.getPreviousAddress() now throws
IllegalStateException
instead of RuntimeException.
---
src/changes/changes.xml | 3 +++
src/main/java/org/apache/commons/net/util/SubnetUtils.java | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 359a0595..b2e0f635 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -100,6 +100,9 @@ The <action> type attribute can be add,update,fix,remove.
<action type="fix" dev="ggregory" due-to="Gary Gregory">
SMTPCommand static initializer now throws IllegalStateException instead of RuntimeException.
</action>
+ <action type="fix" dev="ggregory" due-to="Gary Gregory">
+ SubnetUtils.SubnetInfo.getPreviousAddress() now throws IllegalStateException instead of RuntimeException.
+ </action>
<!-- UPDATE -->
<action type="update" dev="ggregory" due-to="Dependabot">
Bump commons-parent from 54 to 58 #132, #137, #153.
diff --git a/src/main/java/org/apache/commons/net/util/SubnetUtils.java b/src/main/java/org/apache/commons/net/util/SubnetUtils.java
index 5655c957..c722d6a8 100644
--- a/src/main/java/org/apache/commons/net/util/SubnetUtils.java
+++ b/src/main/java/org/apache/commons/net/util/SubnetUtils.java
@@ -76,7 +76,7 @@ public class SubnetUtils {
public int getAddressCount() {
final long countLong = getAddressCountLong();
if (countLong > Integer.MAX_VALUE) {
- throw new RuntimeException("Count is larger than an integer: " + countLong);
+ throw new IllegalStateException("Count is larger than an integer: " + countLong);
}
// Cannot be negative here
return (int) countLong;
[commons-net] 01/06: org.apache.commons.net.nntp.Threader now throws IllegalStateException instead of RuntimeException.
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git
commit abaa661e59095944bd9d16c291129ba6b56d6ff6
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Jun 23 09:00:09 2023 -0400
org.apache.commons.net.nntp.Threader now throws IllegalStateException
instead of RuntimeException.
---
src/changes/changes.xml | 3 +++
src/main/java/org/apache/commons/net/nntp/Threader.java | 6 +++---
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 44d17ea6..8f59d4ff 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -91,6 +91,9 @@ The <action> type attribute can be add,update,fix,remove.
<action type="fix" dev="ggregory" due-to="Gary Gregory">
FTPCommand.checkArray() now throws IllegalStateException instead of RuntimeException.
</action>
+ <action type="fix" dev="ggregory" due-to="Gary Gregory">
+ org.apache.commons.net.nntp.Threader now throws IllegalStateException instead of RuntimeException.
+ </action>
<!-- UPDATE -->
<action type="update" dev="ggregory" due-to="Dependabot">
Bump commons-parent from 54 to 58 #132, #137, #153.
diff --git a/src/main/java/org/apache/commons/net/nntp/Threader.java b/src/main/java/org/apache/commons/net/nntp/Threader.java
index 62c311d4..9c11c68d 100644
--- a/src/main/java/org/apache/commons/net/nntp/Threader.java
+++ b/src/main/java/org/apache/commons/net/nntp/Threader.java
@@ -108,7 +108,7 @@ public class Threader {
}
if (rest == null) {
- throw new RuntimeException("Didnt find " + container + " in parent " + container.parent);
+ throw new IllegalStateException("Didnt find " + container + " in parent " + container.parent);
}
// Unlink this container from the parent's child list
@@ -142,7 +142,7 @@ public class Threader {
final NntpThreadContainer c = entry.getValue();
if (c.parent == null) {
if (c.next != null) {
- throw new RuntimeException("c.next is " + c.next.toString());
+ throw new IllegalStateException("c.next is " + c.next.toString());
}
c.next = root.child;
root.child = c;
@@ -384,7 +384,7 @@ public class Threader {
gatherSubjects(root);
if (root.next != null) {
- throw new RuntimeException("root node has a next:" + root);
+ throw new IllegalStateException("root node has a next:" + root);
}
for (NntpThreadContainer r = root.child; r != null; r = r.next) {
[commons-net] 06/06: Format tweak
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git
commit c6b6658159534472956bdf0859917a004cb46246
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Jun 23 09:07:45 2023 -0400
Format tweak
---
src/main/java/org/apache/commons/net/smtp/SMTPCommand.java | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/main/java/org/apache/commons/net/smtp/SMTPCommand.java b/src/main/java/org/apache/commons/net/smtp/SMTPCommand.java
index c08f5cb8..4e31097f 100644
--- a/src/main/java/org/apache/commons/net/smtp/SMTPCommand.java
+++ b/src/main/java/org/apache/commons/net/smtp/SMTPCommand.java
@@ -22,7 +22,6 @@ package org.apache.commons.net.smtp;
* constant names are transcriptions from the code descriptions of RFC 821. For those who think in terms of the actual SMTP commands, a set of constants such as
* {@link #HELO HELO } are provided where the constant name is the same as the SMTP command.
*/
-
public final class SMTPCommand {
public static final int HELO = 0;
[commons-net] 04/06: SMTPCommand static initializer now throws IllegalStateException instead of RuntimeException.
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git
commit 51d1f869804ae9430c38e7bec03747204eb221b5
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Jun 23 09:06:09 2023 -0400
SMTPCommand static initializer now throws IllegalStateException
instead of RuntimeException.
---
src/changes/changes.xml | 3 +++
src/main/java/org/apache/commons/net/smtp/SMTPCommand.java | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 7a9071be..359a0595 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -97,6 +97,9 @@ The <action> type attribute can be add,update,fix,remove.
<action type="fix" dev="ggregory" due-to="Gary Gregory">
POP3Command static initializer now throws IllegalStateException instead of RuntimeException.
</action>
+ <action type="fix" dev="ggregory" due-to="Gary Gregory">
+ SMTPCommand static initializer now throws IllegalStateException instead of RuntimeException.
+ </action>
<!-- UPDATE -->
<action type="update" dev="ggregory" due-to="Dependabot">
Bump commons-parent from 54 to 58 #132, #137, #153.
diff --git a/src/main/java/org/apache/commons/net/smtp/SMTPCommand.java b/src/main/java/org/apache/commons/net/smtp/SMTPCommand.java
index cd3c7d69..c08f5cb8 100644
--- a/src/main/java/org/apache/commons/net/smtp/SMTPCommand.java
+++ b/src/main/java/org/apache/commons/net/smtp/SMTPCommand.java
@@ -78,7 +78,7 @@ public final class SMTPCommand {
static {
if (commands.length != NEXT) {
- throw new RuntimeException("Error in array definition");
+ throw new IllegalStateException("Error in array definition");
}
}
[commons-net] 03/06: FTPClientTest now throws IllegalStateException instead of RuntimeException.
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git
commit 1bb0eb6189e340bc3745395252dd532a769f87cc
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Jun 23 09:04:35 2023 -0400
FTPClientTest now throws IllegalStateException
instead of RuntimeException.
---
src/test/java/org/apache/commons/net/ftp/FTPClientTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/test/java/org/apache/commons/net/ftp/FTPClientTest.java b/src/test/java/org/apache/commons/net/ftp/FTPClientTest.java
index f2dc55cf..5576b393 100644
--- a/src/test/java/org/apache/commons/net/ftp/FTPClientTest.java
+++ b/src/test/java/org/apache/commons/net/ftp/FTPClientTest.java
@@ -54,7 +54,7 @@ public class FTPClientTest extends TestCase {
try {
return InetAddress.getByName(passiveModeServerIP);
} catch (final Exception e) {
- throw new RuntimeException(e);
+ throw new IllegalStateException(e);
}
}
[commons-net] 02/06: POP3Command static initializer now throws IllegalStateException instead of RuntimeException.
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git
commit 672cdd46cd439dc2eafb5abcb0dc55a47c80cb04
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Jun 23 09:03:43 2023 -0400
POP3Command static initializer now throws IllegalStateException
instead of RuntimeException.
---
src/changes/changes.xml | 3 +++
src/main/java/org/apache/commons/net/pop3/POP3Command.java | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 8f59d4ff..7a9071be 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -94,6 +94,9 @@ The <action> type attribute can be add,update,fix,remove.
<action type="fix" dev="ggregory" due-to="Gary Gregory">
org.apache.commons.net.nntp.Threader now throws IllegalStateException instead of RuntimeException.
</action>
+ <action type="fix" dev="ggregory" due-to="Gary Gregory">
+ POP3Command static initializer now throws IllegalStateException instead of RuntimeException.
+ </action>
<!-- UPDATE -->
<action type="update" dev="ggregory" due-to="Dependabot">
Bump commons-parent from 54 to 58 #132, #137, #153.
diff --git a/src/main/java/org/apache/commons/net/pop3/POP3Command.java b/src/main/java/org/apache/commons/net/pop3/POP3Command.java
index 782d7c6d..a08cbb1a 100644
--- a/src/main/java/org/apache/commons/net/pop3/POP3Command.java
+++ b/src/main/java/org/apache/commons/net/pop3/POP3Command.java
@@ -65,7 +65,7 @@ public final class POP3Command {
static {
if (commands.length != NEXT) {
- throw new RuntimeException("Error in array definition");
+ throw new IllegalStateException("Error in array definition");
}
}