[kudu-CR] KUDU-3371 [fs] make LogBlockManager a base class

["Alexey Serbin (Code Review)" <ge...@cloudera.org>]

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18709 )

Change subject: KUDU-3371 [fs] make LogBlockManager a base class
......................................................................


Patch Set 13: Code-Review+2

(2 comments)

Thank you for working on this!

http://gerrit.cloudera.org:8080/#/c/18709/8/src/kudu/fs/log_block_manager.h
File src/kudu/fs/log_block_manager.h:

http://gerrit.cloudera.org:8080/#/c/18709/8/src/kudu/fs/log_block_manager.h@178
PS8, Line 178:  override;
> Also reported by tidy like:
That makes sense, thanks!


http://gerrit.cloudera.org:8080/#/c/18709/8/src/kudu/fs/log_block_manager.h@473
PS8, Line 473: // Metrics for the block manager.
> It's useful in next patches but now seems useless, as Yuqi also confused ab
Sure!  Let's see if we can get away without introducing these :)



-- 
To view, visit http://gerrit.cloudera.org:8080/18709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59c1287a9539668e0c08036452bb96a3006ed356
Gerrit-Change-Number: 18709
Gerrit-PatchSet: 13
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Thu, 02 Feb 2023 02:13:21 +0000
Gerrit-HasComments: Yes