You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/13 21:21:12 UTC
[GitHub] [arrow-rs] jhorstmann opened a new pull request #1169: Fix compilation error with simd feature
jhorstmann opened a new pull request #1169:
URL: https://github.com/apache/arrow-rs/pull/1169
# Which issue does this PR close?
Fixes a compilation error introduced in the last commit of PR #1161
That commit was supposed to only add some comments, but I also removed one unneeded Result return type and did not try to compile with the simd feature afterwards.
cc @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1169: Fix compilation error with simd feature
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1169:
URL: https://github.com/apache/arrow-rs/pull/1169#issuecomment-1012537368
FWIW I think a new version of rust (1.58) was released which is likely breaking some of the CI tests on master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #1169: Fix compilation error with simd feature
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1169:
URL: https://github.com/apache/arrow-rs/pull/1169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1169: Fix compilation error with simd feature
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1169:
URL: https://github.com/apache/arrow-rs/pull/1169#issuecomment-1013263983
Thanks @jhorstmann -- I'll get a PR up to fix the last error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb edited a comment on pull request #1169: Fix compilation error with simd feature
Posted by GitBox <gi...@apache.org>.
alamb edited a comment on pull request #1169:
URL: https://github.com/apache/arrow-rs/pull/1169#issuecomment-1013278674
> Looks like the test failures on master are due to an intentional change in rust: rust-lang/rust@8731d4d#diff-363ad34c0858be71721f73b0880238813baf8f8b36ebbb494baa6b29103dd8d5
PR to fix the tests: https://github.com/apache/arrow-rs/pull/1173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jhorstmann commented on pull request #1169: Fix compilation error with simd feature
Posted by GitBox <gi...@apache.org>.
jhorstmann commented on pull request #1169:
URL: https://github.com/apache/arrow-rs/pull/1169#issuecomment-1012558204
Looks like the test failures on master are due to an intentional change in rust: https://github.com/rust-lang/rust/commit/8731d4dfb479914a91f650f4f124528e332e8128#diff-363ad34c0858be71721f73b0880238813baf8f8b36ebbb494baa6b29103dd8d5
I don't know why we assert that exact formatting though. Also seems intentional because there is a range check in `fmt::Display for parquet::record::api`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jhorstmann commented on pull request #1169: Fix compilation error with simd feature
Posted by GitBox <gi...@apache.org>.
jhorstmann commented on pull request #1169:
URL: https://github.com/apache/arrow-rs/pull/1169#issuecomment-1012545065
Ah, I see there was also `multiply_scalar` introduced at nearly the same time, so it was the combination that failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1169: Fix compilation error with simd feature
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1169:
URL: https://github.com/apache/arrow-rs/pull/1169#issuecomment-1013278674
> Looks like the test failures on master are due to an intentional change in rust: rust-lang/rust@8731d4d#diff-363ad34c0858be71721f73b0880238813baf8f8b36ebbb494baa6b29103dd8d5
To fix the tests. https://github.com/apache/arrow-rs/pull/1173#pullrequestreview-853124822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org