[jira] [Commented] (MESOS-5882) `os::cloexec` does not exist on Windows

["Andrew Schwartzmeyer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961217#comment-15961217 ] 

Andrew Schwartzmeyer commented on MESOS-5882:
---------------------------------------------

Joe, we're assigning this to simply to mean "follow-up with Joe". We need a lot more context to understand this bug, which is likely going to come from you. Thanks!

> `os::cloexec` does not exist on Windows
> ---------------------------------------
>
>                 Key: MESOS-5882
>                 URL: https://issues.apache.org/jira/browse/MESOS-5882
>             Project: Mesos
>          Issue Type: Bug
>          Components: stout
>            Reporter: Alex Clemmer
>            Assignee: Joseph Wu
>              Labels: mesosphere, stout
>
> `os::cloexec` does not work on Windows. It will never work at the OS level. Because of this, there are likely many important and hard-to-detect bugs hanging around the agent.
> This is extremely important to fix. Some possible solutions to investigate (some of which are _extremely_ risky):
> * Abstract out file descriptors into a class, implement cloexec in that class on Windows (since we can't rely on the OS to do it).
> * Refactor all the code that relies on `os::cloexec` to not rely on it.
> Of the two, the first seems less risky in the short term, because the cloexec code only affects Windows. Depending on the semantics of the implementation of the `FileDescriptor` class, it is possible that this is riskier to Windows in the longer term, as the semantics of `cloexec` may have subtle difference between Linux and Windows.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)