You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by Mark Swanson <ma...@ScheduleWorld.com> on 2007/04/16 06:41:40 UTC

Code comments: custom Authenticator implementations

Hello,

I have a shiny new Authenticator implementation running (mostly, I 
think) and came across a  comment that I think should be changed:

--- AbstractAuthenticator.java  2007-02-21 16:25:53.000000000 -0500
+++ AbstractAuthenticator.java.new      2007-04-16 00:40:12.000000000 -0400
@@ -144,13 +144,14 @@
      /**
       * Returns a new {@link LdapPrincipal} instance whose value is the 
specified
       * <tt>name</tt>.
-     *
+     *
+        * This method is available for custom Authenticator 
implementations.
+        *
       * @param name the distinguished name of the X.500 principal
       * @param authenticationLeve
       * @return the principal for the <tt>name</tt>
       * @throws NamingException if there is a problem parsing <tt>name</tt>
       */
-    // does not seem to be used
      protected static LdapPrincipal createLdapPrincipal( String name, 
AuthenticationLevel authenticationLeve )
          throws NamingException
      {

I could not create a custom Authenticator without createLdapPrincipal().
Of course, unless I can. :-) (then please show me how)

Cheers.

-- 
http://www.ScheduleWorld.com/
Free Google Calendar synchronization with Outlook, Evolution,
cell phones, BlackBerry, PalmOS, Exchange, Mozilla, Thunderbird,
Pocket PC/Windows Mobile. Also sync tasks, notes and contacts!
WebDAV, vfreebusy, RSS, LDAP, iCalendar, iTIP, iMIP support.

Re: Code comments: custom Authenticator implementations

Posted by Emmanuel Lecharny <el...@gmail.com>.
Ok, thanks Mark,

I have remove dthe comment.


On 4/16/07, Mark Swanson <ma...@scheduleworld.com> wrote:
>
> Hello,
>
> I have a shiny new Authenticator implementation running (mostly, I
> think) and came across a  comment that I think should be changed:
>
> --- AbstractAuthenticator.java  2007-02-21 16:25:53.000000000 -0500
> +++ AbstractAuthenticator.java.new      2007-04-16 00:40:12.000000000-0400
> @@ -144,13 +144,14 @@
>       /**
>        * Returns a new {@link LdapPrincipal} instance whose value is the
> specified
>        * <tt>name</tt>.
> -     *
> +     *
> +        * This method is available for custom Authenticator
> implementations.
> +        *
>        * @param name the distinguished name of the X.500 principal
>        * @param authenticationLeve
>        * @return the principal for the <tt>name</tt>
>        * @throws NamingException if there is a problem parsing
> <tt>name</tt>
>        */
> -    // does not seem to be used
>       protected static LdapPrincipal createLdapPrincipal( String name,
> AuthenticationLevel authenticationLeve )
>           throws NamingException
>       {
>
> I could not create a custom Authenticator without createLdapPrincipal().
> Of course, unless I can. :-) (then please show me how)
>
> Cheers.
>
> --
> http://www.ScheduleWorld.com/
> Free Google Calendar synchronization with Outlook, Evolution,
> cell phones, BlackBerry, PalmOS, Exchange, Mozilla, Thunderbird,
> Pocket PC/Windows Mobile. Also sync tasks, notes and contacts!
> WebDAV, vfreebusy, RSS, LDAP, iCalendar, iTIP, iMIP support.
>



-- 
Cordialement,
Emmanuel Lécharny
www.iktek.com