You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/10/06 08:31:51 UTC
[GitHub] [dubbo] kevinw66 opened a new pull request #8983: [WIP][3.0] Add micrometer-prometheus metrics support
kevinw66 opened a new pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983
## What is the purpose of the change
1、Add collector to collect metrics inside dubbo.
## TODO
1、Complete prometheus metrics reporter
2、ut
3、Export MetricsService
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r771085938
##########
File path: dubbo-metrics/dubbo-metrics-prometheus/src/main/java/org/apache/dubbo/metrics/prometheus/PrometheusMetricsReporter.java
##########
@@ -93,7 +94,8 @@ private void exportHttpServer() {
}
});
- new Thread(prometheusExporterHttpServer::start).start();
+ httpServerThread = new Thread(prometheusExporterHttpServer::start);
+ httpServerThread.start();
Review comment:
The http server management seems a bit strange, see about: https://stackoverflow.com/a/2917297
```java
this.httpServer = HttpServer.create(addr, 0);
HttpContext context = this.httpServer.createContext("/", new DocumentProcessHandler());
this.httpThreadPool = Executors.newFixedThreadPool(this.noOfThreads);
this.httpServer.setExecutor(this.httpThreadPool);
this.httpServer.start();
```
```java
this.httpServer.stop(1);
this.httpThreadPool.shutdownNow();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-986009902
Please add a readme doc to `dubbo-metrics-prometheus` module, including metrics config and query description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r762397195
##########
File path: dubbo-common/src/main/java/org/apache/dubbo/common/metrics/model/MethodMetric.java
##########
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.common.metrics.model;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Objects;
+
+import static org.apache.dubbo.common.constants.MetricsConstants.TAG_APPLICATION_NAME;
+import static org.apache.dubbo.common.constants.MetricsConstants.TAG_GROUP_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.TAG_HOST;
+import static org.apache.dubbo.common.constants.MetricsConstants.TAG_INTERFACE_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.TAG_METHOD_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.TAG_PARAMETER_TYPES_DESC;
+import static org.apache.dubbo.common.constants.MetricsConstants.TAG_VERSION_KEY;
+import static org.apache.dubbo.common.utils.NetUtils.getLocalHost;
+
+public class MethodMetric {
+ private String applicationName;
+ private String interfaceName;
+ private String methodName;
+ private String parameterTypesDesc;
+ private String group;
+ private String version;
+
+ public MethodMetric() {
+
+ }
+
+ public MethodMetric(String applicationName, String interfaceName, String methodName, String parameterTypesDesc, String group, String version) {
+ this.applicationName = applicationName;
+ this.interfaceName = interfaceName;
+ this.methodName = methodName;
+ this.parameterTypesDesc = parameterTypesDesc;
+ this.group = group;
+ this.version = version;
+ }
+
+ public String getInterfaceName() {
+ return interfaceName;
+ }
+
+ public void setInterfaceName(String interfaceName) {
+ this.interfaceName = interfaceName;
+ }
+
+ public String getMethodName() {
+ return methodName;
+ }
+
+ public void setMethodName(String methodName) {
+ this.methodName = methodName;
+ }
+
+ public String getParameterTypesDesc() {
+ return parameterTypesDesc;
+ }
+
+ public void setParameterTypesDesc(String parameterTypesDesc) {
+ this.parameterTypesDesc = parameterTypesDesc;
+ }
+
+ public String getGroup() {
+ return group;
+ }
+
+ public void setGroup(String group) {
+ this.group = group;
+ }
+
+ public String getVersion() {
+ return version;
+ }
+
+ public void setVersion(String version) {
+ this.version = version;
+ }
+
+ public Map<String, String> getTags() {
+ Map<String, String> tags = new HashMap<>();
+ tags.put(TAG_HOST, getLocalHost());
+ tags.put(TAG_APPLICATION_NAME, applicationName);
+
+ tags.put(TAG_INTERFACE_KEY, interfaceName);
+ tags.put(TAG_METHOD_KEY, methodName);
+ tags.put(TAG_PARAMETER_TYPES_DESC, parameterTypesDesc);
Review comment:
The `TAG_PARAMETER_TYPES_DESC` tag seems meaningless, API method overloading is rare. I think it can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kevinw66 edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kevinw66 edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-1022914821
After some benchmark test by `dubbo-benchmark` framework
The results is shown as below
Jvm parameters:
`JDK Version: 1.8.0_281`
`VM Arguments: -Xmx2g -Xms2g -XX:MaxDirectMemorySize=1g -XX:+UseG1GC`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (afb2cf3) into [3.0](https://codecov.io/gh/apache/dubbo/commit/954c715366931dd81cf66592700f6f54b1cbbe09?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (954c715) will **decrease** coverage by `0.17%`.
> The diff coverage is `72.75%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
- Coverage 65.38% 65.20% -0.18%
- Complexity 342 407 +65
============================================
Files 1202 1222 +20
Lines 51844 52532 +688
Branches 7727 7789 +62
============================================
+ Hits 33898 34255 +357
- Misses 14334 14620 +286
- Partials 3612 3657 +45
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `82.52% <0.00%> (+0.20%)` | :arrow_up: |
| [...e/dubbo/metrics/service/DefaultMetricsService.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9zZXJ2aWNlL0RlZmF1bHRNZXRyaWNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...n/java/org/apache/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvTmV0VXRpbHMuamF2YQ==) | `68.05% <33.33%> (-0.99%)` | :arrow_down: |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `38.46% <38.46%> (ø)` | |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `50.00% <50.00%> (ø)` | |
| [...pache/dubbo/common/metrics/event/MetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9NZXRyaWNzRXZlbnQuamF2YQ==) | `57.14% <57.14%> (ø)` | |
| [...common/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `58.33% <58.33%> (ø)` | |
| [.../apache/dubbo/metrics/AbstractMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9BYnN0cmFjdE1ldHJpY3NSZXBvcnRlci5qYXZh) | `61.29% <61.29%> (ø)` | |
| ... and [85 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [954c715...afb2cf3](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r762396708
##########
File path: dubbo-common/src/main/java/org/apache/dubbo/common/metrics/model/MethodMetric.java
##########
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.common.metrics.model;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Objects;
+
+import static org.apache.dubbo.common.constants.MetricsConstants.TAG_APPLICATION_NAME;
+import static org.apache.dubbo.common.constants.MetricsConstants.TAG_GROUP_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.TAG_HOST;
+import static org.apache.dubbo.common.constants.MetricsConstants.TAG_INTERFACE_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.TAG_METHOD_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.TAG_PARAMETER_TYPES_DESC;
+import static org.apache.dubbo.common.constants.MetricsConstants.TAG_VERSION_KEY;
+import static org.apache.dubbo.common.utils.NetUtils.getLocalHost;
+
+public class MethodMetric {
+ private String applicationName;
+ private String interfaceName;
+ private String methodName;
+ private String parameterTypesDesc;
+ private String group;
+ private String version;
+
+ public MethodMetric() {
+
+ }
+
+ public MethodMetric(String applicationName, String interfaceName, String methodName, String parameterTypesDesc, String group, String version) {
+ this.applicationName = applicationName;
+ this.interfaceName = interfaceName;
+ this.methodName = methodName;
+ this.parameterTypesDesc = parameterTypesDesc;
+ this.group = group;
+ this.version = version;
+ }
+
+ public String getInterfaceName() {
+ return interfaceName;
+ }
+
+ public void setInterfaceName(String interfaceName) {
+ this.interfaceName = interfaceName;
+ }
+
+ public String getMethodName() {
+ return methodName;
+ }
+
+ public void setMethodName(String methodName) {
+ this.methodName = methodName;
+ }
+
+ public String getParameterTypesDesc() {
+ return parameterTypesDesc;
+ }
+
+ public void setParameterTypesDesc(String parameterTypesDesc) {
+ this.parameterTypesDesc = parameterTypesDesc;
+ }
+
+ public String getGroup() {
+ return group;
+ }
+
+ public void setGroup(String group) {
+ this.group = group;
+ }
+
+ public String getVersion() {
+ return version;
+ }
+
+ public void setVersion(String version) {
+ this.version = version;
+ }
+
+ public Map<String, String> getTags() {
+ Map<String, String> tags = new HashMap<>();
+ tags.put(TAG_HOST, getLocalHost());
Review comment:
It's better to add tag both for IP address and hostname. In the k8s cluster, the node name uses hostname.
##########
File path: dubbo-common/src/main/java/org/apache/dubbo/common/metrics/model/MethodMetric.java
##########
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.common.metrics.model;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Objects;
+
+import static org.apache.dubbo.common.constants.MetricsConstants.TAG_APPLICATION_NAME;
+import static org.apache.dubbo.common.constants.MetricsConstants.TAG_GROUP_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.TAG_HOST;
+import static org.apache.dubbo.common.constants.MetricsConstants.TAG_INTERFACE_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.TAG_METHOD_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.TAG_PARAMETER_TYPES_DESC;
+import static org.apache.dubbo.common.constants.MetricsConstants.TAG_VERSION_KEY;
+import static org.apache.dubbo.common.utils.NetUtils.getLocalHost;
+
+public class MethodMetric {
+ private String applicationName;
+ private String interfaceName;
+ private String methodName;
+ private String parameterTypesDesc;
+ private String group;
+ private String version;
+
+ public MethodMetric() {
+
+ }
+
+ public MethodMetric(String applicationName, String interfaceName, String methodName, String parameterTypesDesc, String group, String version) {
+ this.applicationName = applicationName;
+ this.interfaceName = interfaceName;
+ this.methodName = methodName;
+ this.parameterTypesDesc = parameterTypesDesc;
+ this.group = group;
+ this.version = version;
+ }
+
+ public String getInterfaceName() {
+ return interfaceName;
+ }
+
+ public void setInterfaceName(String interfaceName) {
+ this.interfaceName = interfaceName;
+ }
+
+ public String getMethodName() {
+ return methodName;
+ }
+
+ public void setMethodName(String methodName) {
+ this.methodName = methodName;
+ }
+
+ public String getParameterTypesDesc() {
+ return parameterTypesDesc;
+ }
+
+ public void setParameterTypesDesc(String parameterTypesDesc) {
+ this.parameterTypesDesc = parameterTypesDesc;
+ }
+
+ public String getGroup() {
+ return group;
+ }
+
+ public void setGroup(String group) {
+ this.group = group;
+ }
+
+ public String getVersion() {
+ return version;
+ }
+
+ public void setVersion(String version) {
+ this.version = version;
+ }
+
+ public Map<String, String> getTags() {
+ Map<String, String> tags = new HashMap<>();
+ tags.put(TAG_HOST, getLocalHost());
Review comment:
It's better to add tags both for IP address and hostname. In the k8s cluster, the node name uses hostname.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r762407136
##########
File path: dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/AbstractMetricsReporter.java
##########
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.metrics;
+
+import org.apache.dubbo.common.URL;
+import org.apache.dubbo.common.lang.ShutdownHookCallbacks;
+import org.apache.dubbo.common.logger.Logger;
+import org.apache.dubbo.common.logger.LoggerFactory;
+import org.apache.dubbo.common.metrics.MetricsReporter;
+import org.apache.dubbo.common.metrics.collector.DefaultMetricsCollector;
+import org.apache.dubbo.common.metrics.collector.MetricsCollector;
+import org.apache.dubbo.common.metrics.model.sample.GaugeMetricSample;
+import org.apache.dubbo.common.metrics.model.sample.MetricSample;
+import org.apache.dubbo.common.utils.NamedThreadFactory;
+import org.apache.dubbo.metrics.collector.AggregateMetricsCollector;
+import org.apache.dubbo.rpc.model.ApplicationModel;
+
+import io.micrometer.core.instrument.Gauge;
+import io.micrometer.core.instrument.MeterRegistry;
+import io.micrometer.core.instrument.Tag;
+import io.micrometer.core.instrument.binder.jvm.ClassLoaderMetrics;
+import io.micrometer.core.instrument.binder.jvm.JvmGcMetrics;
+import io.micrometer.core.instrument.binder.jvm.JvmMemoryMetrics;
+import io.micrometer.core.instrument.binder.jvm.JvmThreadMetrics;
+import io.micrometer.core.instrument.binder.system.ProcessorMetrics;
+import io.micrometer.core.instrument.composite.CompositeMeterRegistry;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+
+import static org.apache.dubbo.common.constants.MetricsConstants.ENABLE_JVM_METRICS_KEY;
+
+/**
+ * AbstractMetricsReporter.
+ */
+public abstract class AbstractMetricsReporter implements MetricsReporter {
+
+ private final Logger logger = LoggerFactory.getLogger(AbstractMetricsReporter.class);
+
+ protected final URL url;
+ protected final List<MetricsCollector> collectors = new ArrayList<>();
+ protected final CompositeMeterRegistry compositeRegistry = new CompositeMeterRegistry();
+
+ private final ApplicationModel applicationModel;
+ private ScheduledExecutorService collectorSyncJobExecutor = null;
+
+ private static final int DEFAULT_SCHEDULE_INITIAL_DELAY = 5;
+ private static final int DEFAULT_SCHEDULE_PERIOD = 30;
+
+ protected AbstractMetricsReporter(URL url, ApplicationModel applicationModel) {
+ this.url = url;
+ this.applicationModel = applicationModel;
+ }
+
+ @Override
+ public void init() {
+ addJvmMetrics();
+ initCollectors();
+ scheduleMetricsCollectorSyncJob();
+
+ doInit();
+
+ registerDubboShutdownHook();
+ }
+
+ protected void addMeterRegistry(MeterRegistry registry) {
+ compositeRegistry.add(registry);
+ }
+
+ protected ApplicationModel getApplicationModel() {
+ return applicationModel;
+ }
+
+ private void addJvmMetrics() {
+ boolean enableJvmMetrics = url.getParameter(ENABLE_JVM_METRICS_KEY, false);
+ if (enableJvmMetrics) {
+ new ClassLoaderMetrics().bindTo(compositeRegistry);
+ new JvmMemoryMetrics().bindTo(compositeRegistry);
+ new JvmGcMetrics().bindTo(compositeRegistry);
+ new ProcessorMetrics().bindTo(compositeRegistry);
+ new JvmThreadMetrics().bindTo(compositeRegistry);
+ }
+ }
+
+ private void initCollectors() {
+ applicationModel.getBeanFactory().getOrRegisterBean(AggregateMetricsCollector.class);
+
+ collectors.add(applicationModel.getBeanFactory().getBean(DefaultMetricsCollector.class));
+ collectors.add(applicationModel.getBeanFactory().getBean(AggregateMetricsCollector.class));
+ }
+
+ private void scheduleMetricsCollectorSyncJob() {
+ NamedThreadFactory threadFactory = new NamedThreadFactory("metrics-collector-sync-job", true);
+ collectorSyncJobExecutor = Executors.newScheduledThreadPool(1, threadFactory);
+ collectorSyncJobExecutor.scheduleAtFixedRate(() -> {
Review comment:
It's better to schedule with `scheduleWithFixedDelay`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r762409208
##########
File path: dubbo-metrics/dubbo-metrics-prometheus/src/main/java/org/apache/dubbo/metrics/prometheus/PrometheusMetricsReporter.java
##########
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.metrics.prometheus;
+
+import org.apache.dubbo.common.URL;
+import org.apache.dubbo.common.logger.Logger;
+import org.apache.dubbo.common.logger.LoggerFactory;
+import org.apache.dubbo.common.utils.NamedThreadFactory;
+import org.apache.dubbo.common.utils.StringUtils;
+import org.apache.dubbo.metrics.AbstractMetricsReporter;
+import org.apache.dubbo.rpc.model.ApplicationModel;
+
+import com.sun.net.httpserver.HttpServer;
+import io.micrometer.prometheus.PrometheusConfig;
+import io.micrometer.prometheus.PrometheusMeterRegistry;
+import io.prometheus.client.exporter.BasicAuthHttpConnectionFactory;
+import io.prometheus.client.exporter.PushGateway;
+
+import java.io.IOException;
+import java.io.OutputStream;
+import java.net.InetSocketAddress;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_DEFAULT_JOB_NAME;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_DEFAULT_METRICS_PATH;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_DEFAULT_METRICS_PORT;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_DEFAULT_PUSH_INTERVAL;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_EXPORTER_ENABLED_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_EXPORTER_METRICS_PATH_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_EXPORTER_METRICS_PORT_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_PUSHGATEWAY_BASE_URL_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_PUSHGATEWAY_ENABLED_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_PUSHGATEWAY_JOB_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_PUSHGATEWAY_PASSWORD_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_PUSHGATEWAY_PUSH_INTERVAL_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_PUSHGATEWAY_USERNAME_KEY;
+
+/**
+ * Metrics reporter for prometheus.
+ */
+public class PrometheusMetricsReporter extends AbstractMetricsReporter {
+
+ private final Logger logger = LoggerFactory.getLogger(PrometheusMetricsReporter.class);
+
+ private final PrometheusMeterRegistry prometheusRegistry = new PrometheusMeterRegistry(PrometheusConfig.DEFAULT);
+ private ScheduledExecutorService pushJobExecutor = null;
+ private HttpServer prometheusExporterHttpServer = null;
+
+ public PrometheusMetricsReporter(URL url, ApplicationModel applicationModel) {
+ super(url, applicationModel);
+ }
+
+ @Override
+ public void doInit() {
+ addMeterRegistry(prometheusRegistry);
+ exportHttpServer();
+ schedulePushJob();
+ }
+
+ private void exportHttpServer() {
+ boolean exporterEnabled = url.getParameter(PROMETHEUS_EXPORTER_ENABLED_KEY, false);
+ if (exporterEnabled) {
+ int port = url.getParameter(PROMETHEUS_EXPORTER_METRICS_PORT_KEY, PROMETHEUS_DEFAULT_METRICS_PORT);
+ String path = url.getParameter(PROMETHEUS_EXPORTER_METRICS_PATH_KEY, PROMETHEUS_DEFAULT_METRICS_PATH);
+ if (!path.startsWith("/")) {
+ path = "/" + path;
+ }
+
+ try {
+ prometheusExporterHttpServer = HttpServer.create(new InetSocketAddress(port), 0);
+ prometheusExporterHttpServer.createContext(path, httpExchange -> {
+ String response = prometheusRegistry.scrape();
+ httpExchange.sendResponseHeaders(200, response.getBytes().length);
+ try (OutputStream os = httpExchange.getResponseBody()) {
+ os.write(response.getBytes());
+ }
+ });
+
+ new Thread(prometheusExporterHttpServer::start).start();
Review comment:
The thread of Http server is not managed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kevinw66 commented on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kevinw66 commented on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-1023923825
## Throughput
### Enable Metrics
| Benchmark | Mode | Cnt | Score | Error | Units |
| :----: | :----: | :----: | :----: | :----: | :----: |
| Client.createUser | thrpt | 3 | 22.082 ± 2.066 | | ops/ms |
| Client.existUser | thrpt | 3 | 41.490 ± 1.442 | | ops/ms |
| Client.getUser | thrpt | 3 | 22.077 ± 1.809 | | ops/ms |
| Client.listUser | thrpt | 3 | 2.972 ± 0.022 | | ops/ms |
| Client.createUser | avgt | 3 | 1.452 ± 0.351 | | ms/op |
| Client.existUser | avgt | 3 | 0.772 ± 0.100 | | ms/op |
| Client.getUser | avgt | 3 | 1.445 ± 0.173 | | ms/op |
| Client.listUser | avgt | 3 | 10.730 ± 0.700 | | ms/op |
| Client.createUser | sample | 688220 | 1.479 ± 0.002 | | ms/op |
| Client.createUser:createUser·p0.00 | sample | | 0.509 | | ms/op |
| Client.createUser:createUser·p0.50 | sample | | 1.300 | | ms/op |
| Client.createUser:createUser·p0.90 | sample | | 2.269 | | ms/op |
| Client.createUser:createUser·p0.95 | sample | | 2.425 | | ms/op |
| Client.createUser:createUser·p0.99 | sample | | 2.875 | | ms/op |
| Client.createUser:createUser·p0.999 | sample | | 3.580 | | ms/op |
| Client.createUser:createUser·p0.9999 | sample | | 12.461 | | ms/op |
| Client.createUser:createUser·p1.00 | sample | | 14.516 | | ms/op |
| Client.existUser | sample | 1244807 | 0.771 ± 0.001 | | ms/op |
| Client.existUser:existUser·p0.00 | sample | | 0.242 | | ms/op |
| Client.existUser:existUser·p0.50 | sample | | 0.753 | | ms/op |
| Client.existUser:existUser·p0.90 | sample | | 1.008 | | ms/op |
| Client.existUser:existUser·p0.95 | sample | | 1.100 | | ms/op |
| Client.existUser:existUser·p0.99 | sample | | 1.274 | | ms/op |
| Client.existUser:existUser·p0.999 | sample | | 1.577 | | ms/op |
| Client.existUser:existUser·p0.9999 | sample | | 12.297 | | ms/op |
| Client.existUser:existUser·p1.00 | sample | | 14.729 | | ms/op |
| Client.getUser | sample | 657680 | 1.458 ± 0.001 | | ms/op |
| Client.getUser:getUser·p0.00 | sample | | 0.425 | | ms/op |
| Client.getUser:getUser·p0.50 | sample | | 1.468 | | ms/op |
| Client.getUser:getUser·p0.90 | sample | | 1.686 | | ms/op |
| Client.getUser:getUser·p0.95 | sample | | 1.794 | | ms/op |
| Client.getUser:getUser·p0.99 | sample | | 2.054 | | ms/op |
| Client.getUser:getUser·p0.999 | sample | | 3.262 | | ms/op |
| Client.getUser:getUser·p0.9999 | sample | | 12.898 | | ms/op |
| Client.getUser:getUser·p1.00 | sample | | 16.040 | | ms/op |
| Client.listUser | sample | 89410 | 10.731 ± 0.020 | | ms/op |
| Client.listUser:listUser·p0.00 | sample | | 1.884 | | ms/op |
| Client.listUser:listUser·p0.50 | sample | | 11.026 | | ms/op |
| Client.listUser:listUser·p0.90 | sample | | 11.698 | | ms/op |
| Client.listUser:listUser·p0.95 | sample | | 12.091 | | ms/op |
| Client.listUser:listUser·p0.99 | sample | | 13.271 | | ms/op |
| Client.listUser:listUser·p0.999 | sample | | 19.189 | | ms/op |
| Client.listUser:listUser·p0.9999 | sample | | 20.418 | | ms/op |
| Client.listUser:listUser·p1.00 | sample | | 21.987 | | ms/op |
### Disable Metrics
| Benchmark | Mode | Cnt | Score | Error | Units |
| :----: | :----: | :----: | :----: | :----: | :----: |
| Client.createUser | thrpt | 3 | 23.067 ± 2.783 | | ops/ms |
| Client.existUser | thrpt | 3 | 41.526 ± 5.468 | | ops/ms |
| Client.getUser | thrpt | 3 | 23.092 ± 4.975 | | ops/ms |
| Client.listUser | thrpt | 3 | 3.548 ± 0.077 | | ops/ms |
| Client.createUser | avgt | 3 | 1.430 ± 0.102 | | ms/op |
| Client.existUser | avgt | 3 | 0.750 ± 0.154 | | ms/op |
| Client.getUser | avgt | 3 | 1.361 ± 0.145 | | ms/op |
| Client.listUser | avgt | 3 | 8.981 ± 0.220 | | ms/op |
| Client.createUser | sample | 688350 | 1.394 ± 0.002 | | ms/op |
| Client.createUser:createUser·p0.00 | sample | | 0.600 | | ms/op |
| Client.createUser:createUser·p0.50 | sample | | 1.225 | | ms/op |
| Client.createUser:createUser·p0.90 | sample | | 2.154 | | ms/op |
| Client.createUser:createUser·p0.95 | sample | | 2.294 | | ms/op |
| Client.createUser:createUser·p0.99 | sample | | 2.707 | | ms/op |
| Client.createUser:createUser·p0.999 | sample | | 3.431 | | ms/op |
| Client.createUser:createUser·p0.9999 | sample | | 12.190 | | ms/op |
| Client.createUser:createUser·p1.00 | sample | | 14.500 | | ms/op |
| Client.existUser | sample | 1266489 | 0.758 ± 0.001 | | ms/op |
| Client.existUser:existUser·p0.00 | sample | | 0.242 | | ms/op |
| Client.existUser:existUser·p0.50 | sample | | 0.735 | | ms/op |
| Client.existUser:existUser·p0.90 | sample | | 1.002 | | ms/op |
| Client.existUser:existUser·p0.95 | sample | | 1.106 | | ms/op |
| Client.existUser:existUser·p0.99 | sample | | 1.286 | | ms/op |
| Client.existUser:existUser·p0.999 | sample | | 1.688 | | ms/op |
| Client.existUser:existUser·p0.9999 | sample | | 12.468 | | ms/op |
| Client.existUser:existUser·p1.00 | sample | | 15.221 | | ms/op |
| Client.getUser | sample | 689952 | 1.390 ± 0.001 | | ms/op |
| Client.getUser:getUser·p0.00 | sample | | 0.387 | | ms/op |
| Client.getUser:getUser·p0.50 | sample | | 1.399 | | ms/op |
| Client.getUser:getUser·p0.90 | sample | | 1.632 | | ms/op |
| Client.getUser:getUser·p0.95 | sample | | 1.737 | | ms/op |
| Client.getUser:getUser·p0.99 | sample | | 1.997 | | ms/op |
| Client.getUser:getUser·p0.999 | sample | | 2.822 | | ms/op |
| Client.getUser:getUser·p0.9999 | sample | | 16.253 | | ms/op |
| Client.getUser:getUser·p1.00 | sample | | 19.857 | | ms/op |
| Client.listUser | sample | 106368 | 9.021 ± 0.015 | | ms/op |
| Client.listUser:listUser·p0.00 | sample | | 1.608 | | ms/op |
| Client.listUser:listUser·p0.50 | sample | | 9.290 | | ms/op |
| Client.listUser:listUser·p0.90 | sample | | 9.994 | | ms/op |
| Client.listUser:listUser·p0.95 | sample | | 10.256 | | ms/op |
| Client.listUser:listUser·p0.99 | sample | | 11.190 | | ms/op |
| Client.listUser:listUser·p0.999 | sample | | 15.362 | | ms/op |
| Client.listUser:listUser·p0.9999 | sample | | 17.182 | | ms/op |
| Client.listUser:listUser·p1.00 | sample | | 23.167 | | ms/op |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (659c02a) into [3.0](https://codecov.io/gh/apache/dubbo/commit/dfe4fcaea107ac292e6f2e967807a0756f59c7e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dfe4fca) will **increase** coverage by `0.03%`.
> The diff coverage is `72.92%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
+ Coverage 65.59% 65.62% +0.03%
- Complexity 297 355 +58
============================================
Files 1191 1211 +20
Lines 52068 52653 +585
Branches 7907 7954 +47
============================================
+ Hits 34154 34556 +402
- Misses 14231 14379 +148
- Partials 3683 3718 +35
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/dubbo/metrics/service/DefaultMetricsService.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9zZXJ2aWNlL0RlZmF1bHRNZXRyaWNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...n/java/org/apache/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvTmV0VXRpbHMuamF2YQ==) | `68.69% <33.33%> (-0.35%)` | :arrow_down: |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `38.46% <38.46%> (ø)` | |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `50.00% <50.00%> (ø)` | |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `82.52% <50.00%> (+0.26%)` | :arrow_up: |
| [...pache/dubbo/common/metrics/event/MetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9NZXRyaWNzRXZlbnQuamF2YQ==) | `57.14% <57.14%> (ø)` | |
| [...common/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `58.33% <58.33%> (ø)` | |
| [.../apache/dubbo/metrics/AbstractMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9BYnN0cmFjdE1ldHJpY3NSZXBvcnRlci5qYXZh) | `61.29% <61.29%> (ø)` | |
| ... and [36 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dfe4fca...659c02a](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kevinw66 edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kevinw66 edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-1023923825
## Throughput
| Benchmark | Mode | Cnt | Score(Normal) | Score(Metrics) | Error | Units |
| :----: | :----: | :----: | :----: | :----: | :----: |
| Client.createUser | thrpt | 3 | 23.067 ± 2.783 | 22.082 ± 2.066 | | ops/ms |
| Client.existUser | thrpt | 3 | 41.526 ± 5.468 | 41.490 ± 1.442 | | ops/ms |
| Client.getUser | thrpt | 3 | 23.092 ± 4.975 | 22.077 ± 1.809 | | ops/ms |
| Client.listUser | thrpt | 3 | 3.548 ± 0.077 | 2.972 ± 0.022 | | ops/ms |
| Client.createUser | avgt | 3 | 1.430 ± 0.102 | 1.452 ± 0.351 | | ms/op |
| Client.existUser | avgt | 3 | 0.750 ± 0.154 | 0.772 ± 0.100 | | ms/op |
| Client.getUser | avgt | 3 | 1.361 ± 0.145 | 1.445 ± 0.173 | | ms/op |
| Client.listUser | avgt | 3 | 8.981 ± 0.220 | 10.730 ± 0.700 | | ms/op |
| Client.createUser | sample | 688220 | 1.394 ± 0.002 | 1.479 ± 0.002 | | ms/op |
| Client.createUser:createUser·p0.00 | sample | | 0.600 | 0.509 | | ms/op |
| Client.createUser:createUser·p0.50 | sample | | 1.225 | 1.300 | | ms/op |
| Client.createUser:createUser·p0.90 | sample | | 2.154 | 2.269 | | ms/op |
| Client.createUser:createUser·p0.95 | sample | | 2.294 | 2.425 | | ms/op |
| Client.createUser:createUser·p0.99 | sample | | 2.707 | 2.875 | | ms/op |
| Client.createUser:createUser·p0.999 | sample | | 3.431 | 3.580 | | ms/op |
| Client.createUser:createUser·p0.9999 | sample | | 12.190 | 12.461 | | ms/op |
| Client.createUser:createUser·p1.00 | sample | | 14.500 | 14.516 | | ms/op |
| Client.existUser | sample | 1244807 | 0.758 ± 0.001 | 0.771 ± 0.001 | | ms/op |
| Client.existUser:existUser·p0.00 | sample | | 0.242 | 0.242 | | ms/op |
| Client.existUser:existUser·p0.50 | sample | | 0.735 | 0.753 | | ms/op |
| Client.existUser:existUser·p0.90 | sample | | 1.002 | 1.008 | | ms/op |
| Client.existUser:existUser·p0.95 | sample | | 1.106 | 1.100 | | ms/op |
| Client.existUser:existUser·p0.99 | sample | | 1.286 | 1.274 | | ms/op |
| Client.existUser:existUser·p0.999 | sample | | 1.688 | 1.577 | | ms/op |
| Client.existUser:existUser·p0.9999 | sample | | 12.468 | 12.297 | | ms/op |
| Client.existUser:existUser·p1.00 | sample | | 15.221 | 14.729 | | ms/op |
| Client.getUser | sample | 657680 | 1.390 ± 0.001 | 1.458 ± 0.001 | | ms/op |
| Client.getUser:getUser·p0.00 | sample | | 0.387 | 0.425 | | ms/op |
| Client.getUser:getUser·p0.50 | sample | | 1.399 | 1.468 | | ms/op |
| Client.getUser:getUser·p0.90 | sample | | 1.632 | 1.686 | | ms/op |
| Client.getUser:getUser·p0.95 | sample | | 1.737 | 1.794 | | ms/op |
| Client.getUser:getUser·p0.99 | sample | | 1.997 | 2.054 | | ms/op |
| Client.getUser:getUser·p0.999 | sample | | 2.822 | 3.262 | | ms/op |
| Client.getUser:getUser·p0.9999 | sample | | 16.253 | 12.898 | | ms/op |
| Client.getUser:getUser·p1.00 | sample | | 19.857 | 16.040 | | ms/op |
| Client.listUser | sample | 89410 | 9.021 ± 0.015 | 10.731 ± 0.020 | | ms/op |
| Client.listUser:listUser·p0.00 | sample | | 1.608 | 1.884 | | ms/op |
| Client.listUser:listUser·p0.50 | sample | | 9.290 | 11.026 | | ms/op |
| Client.listUser:listUser·p0.90 | sample | | 9.994 | 11.698 | | ms/op |
| Client.listUser:listUser·p0.95 | sample | | 10.256 | 12.091 | | ms/op |
| Client.listUser:listUser·p0.99 | sample | | 11.190 | 13.271 | | ms/op |
| Client.listUser:listUser·p0.999 | sample | | 15.362 | 19.189 | | ms/op |
| Client.listUser:listUser·p0.9999 | sample | | 17.182 | 20.418 | | ms/op |
| Client.listUser:listUser·p1.00 | sample | | 23.167 | 21.987 | | ms/op |
### Disable Metrics
| Benchmark | Mode | Cnt | Score | Error | Units |
| :----: | :----: | :----: | :----: | :----: | :----: |
| Client.createUser | thrpt | 3 | 23.067 ± 2.783 | | ops/ms |
| Client.existUser | thrpt | 3 | 41.526 ± 5.468 | | ops/ms |
| Client.getUser | thrpt | 3 | 23.092 ± 4.975 | | ops/ms |
| Client.listUser | thrpt | 3 | 3.548 ± 0.077 | | ops/ms |
| Client.createUser | avgt | 3 | 1.430 ± 0.102 | | ms/op |
| Client.existUser | avgt | 3 | 0.750 ± 0.154 | | ms/op |
| Client.getUser | avgt | 3 | 1.361 ± 0.145 | | ms/op |
| Client.listUser | avgt | 3 | 8.981 ± 0.220 | | ms/op |
| Client.createUser | sample | 688350 | 1.394 ± 0.002 | | ms/op |
| Client.createUser:createUser·p0.00 | sample | | 0.600 | | ms/op |
| Client.createUser:createUser·p0.50 | sample | | 1.225 | | ms/op |
| Client.createUser:createUser·p0.90 | sample | | 2.154 | | ms/op |
| Client.createUser:createUser·p0.95 | sample | | 2.294 | | ms/op |
| Client.createUser:createUser·p0.99 | sample | | 2.707 | | ms/op |
| Client.createUser:createUser·p0.999 | sample | | 3.431 | | ms/op |
| Client.createUser:createUser·p0.9999 | sample | | 12.190 | | ms/op |
| Client.createUser:createUser·p1.00 | sample | | 14.500 | | ms/op |
| Client.existUser | sample | 1266489 | 0.758 ± 0.001 | | ms/op |
| Client.existUser:existUser·p0.00 | sample | | 0.242 | | ms/op |
| Client.existUser:existUser·p0.50 | sample | | 0.735 | | ms/op |
| Client.existUser:existUser·p0.90 | sample | | 1.002 | | ms/op |
| Client.existUser:existUser·p0.95 | sample | | 1.106 | | ms/op |
| Client.existUser:existUser·p0.99 | sample | | 1.286 | | ms/op |
| Client.existUser:existUser·p0.999 | sample | | 1.688 | | ms/op |
| Client.existUser:existUser·p0.9999 | sample | | 12.468 | | ms/op |
| Client.existUser:existUser·p1.00 | sample | | 15.221 | | ms/op |
| Client.getUser | sample | 689952 | 1.390 ± 0.001 | | ms/op |
| Client.getUser:getUser·p0.00 | sample | | 0.387 | | ms/op |
| Client.getUser:getUser·p0.50 | sample | | 1.399 | | ms/op |
| Client.getUser:getUser·p0.90 | sample | | 1.632 | | ms/op |
| Client.getUser:getUser·p0.95 | sample | | 1.737 | | ms/op |
| Client.getUser:getUser·p0.99 | sample | | 1.997 | | ms/op |
| Client.getUser:getUser·p0.999 | sample | | 2.822 | | ms/op |
| Client.getUser:getUser·p0.9999 | sample | | 16.253 | | ms/op |
| Client.getUser:getUser·p1.00 | sample | | 19.857 | | ms/op |
| Client.listUser | sample | 106368 | 9.021 ± 0.015 | | ms/op |
| Client.listUser:listUser·p0.00 | sample | | 1.608 | | ms/op |
| Client.listUser:listUser·p0.50 | sample | | 9.290 | | ms/op |
| Client.listUser:listUser·p0.90 | sample | | 9.994 | | ms/op |
| Client.listUser:listUser·p0.95 | sample | | 10.256 | | ms/op |
| Client.listUser:listUser·p0.99 | sample | | 11.190 | | ms/op |
| Client.listUser:listUser·p0.999 | sample | | 15.362 | | ms/op |
| Client.listUser:listUser·p0.9999 | sample | | 17.182 | | ms/op |
| Client.listUser:listUser·p1.00 | sample | | 23.167 | | ms/op |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kevinw66 edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kevinw66 edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-1022914821
After some benchmark test by `dubbo-benchmark` framework
The results is shown as below
Jvm parameters:
`JDK Version: 1.8.0_281`
`VM Arguments: -Xmx2g -Xms2g -XX:MaxDirectMemorySize=1g -XX:+UseG1GC`
## Throughput
### Disable Metrics
| Benchmark | Mode | Cnt | Score | Error | Units |
| :----: | :----: | :----: | :----: | :----: | :----: |
| Client.createUser | thrpt | 3 | 23.067 ± 2.783 | | ops/ms |
| Client.existUser | thrpt | 3 | 41.526 ± 5.468 | | ops/ms |
| Client.getUser | thrpt | 3 | 23.092 ± 4.975 | | ops/ms |
| Client.listUser | thrpt | 3 | 3.548 ± 0.077 | | ops/ms |
| Client.createUser | avgt | 3 | 1.430 ± 0.102 | | ms/op |
| Client.existUser | avgt | 3 | 0.750 ± 0.154 | | ms/op |
| Client.getUser | avgt | 3 | 1.361 ± 0.145 | | ms/op |
| Client.listUser | avgt | 3 | 8.981 ± 0.220 | | ms/op |
| Client.createUser | sample | 688350 | 1.394 ± 0.002 | | ms/op |
| Client.createUser:createUser·p0.00 | sample | | 0.600 | | ms/op |
| Client.createUser:createUser·p0.50 | sample | | 1.225 | | ms/op |
| Client.createUser:createUser·p0.90 | sample | | 2.154 | | ms/op |
| Client.createUser:createUser·p0.95 | sample | | 2.294 | | ms/op |
| Client.createUser:createUser·p0.99 | sample | | 2.707 | | ms/op |
| Client.createUser:createUser·p0.999 | sample | | 3.431 | | ms/op |
| Client.createUser:createUser·p0.9999 | sample | | 12.190 | | ms/op |
| Client.createUser:createUser·p1.00 | sample | | 14.500 | | ms/op |
| Client.existUser | sample | 1266489 | 0.758 ± 0.001 | | ms/op |
| Client.existUser:existUser·p0.00 | sample | | 0.242 | | ms/op |
| Client.existUser:existUser·p0.50 | sample | | 0.735 | | ms/op |
| Client.existUser:existUser·p0.90 | sample | | 1.002 | | ms/op |
| Client.existUser:existUser·p0.95 | sample | | 1.106 | | ms/op |
| Client.existUser:existUser·p0.99 | sample | | 1.286 | | ms/op |
| Client.existUser:existUser·p0.999 | sample | | 1.688 | | ms/op |
| Client.existUser:existUser·p0.9999 | sample | | 12.468 | | ms/op |
| Client.existUser:existUser·p1.00 | sample | | 15.221 | | ms/op |
| Client.getUser | sample | 689952 | 1.390 ± 0.001 | | ms/op |
| Client.getUser:getUser·p0.00 | sample | | 0.387 | | ms/op |
| Client.getUser:getUser·p0.50 | sample | | 1.399 | | ms/op |
| Client.getUser:getUser·p0.90 | sample | | 1.632 | | ms/op |
| Client.getUser:getUser·p0.95 | sample | | 1.737 | | ms/op |
| Client.getUser:getUser·p0.99 | sample | | 1.997 | | ms/op |
| Client.getUser:getUser·p0.999 | sample | | 2.822 | | ms/op |
| Client.getUser:getUser·p0.9999 | sample | | 16.253 | | ms/op |
| Client.getUser:getUser·p1.00 | sample | | 19.857 | | ms/op |
| Client.listUser | sample | 106368 | 9.021 ± 0.015 | | ms/op |
| Client.listUser:listUser·p0.00 | sample | | 1.608 | | ms/op |
| Client.listUser:listUser·p0.50 | sample | | 9.290 | | ms/op |
| Client.listUser:listUser·p0.90 | sample | | 9.994 | | ms/op |
| Client.listUser:listUser·p0.95 | sample | | 10.256 | | ms/op |
| Client.listUser:listUser·p0.99 | sample | | 11.190 | | ms/op |
| Client.listUser:listUser·p0.999 | sample | | 15.362 | | ms/op |
| Client.listUser:listUser·p0.9999 | sample | | 17.182 | | ms/op |
| Client.listUser:listUser·p1.00 | sample | | 23.167 | | ms/op |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kevinw66 commented on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kevinw66 commented on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-1023925740
## JVM Monitor
### Enable Metrics
<img width="1476" alt="enable-metrics" src="https://user-images.githubusercontent.com/31196226/151498239-fb31566d-1c4f-4abf-9ab6-ac70ab596322.png">
### Disable Metrics
![Uploading disable-metrics.png…]()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kevinw66 edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kevinw66 edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-1023923825
## Throughput
| Benchmark | Mode | Cnt | Score(Normal) | Score(Metrics) | Units |
| :----: | :----: | :----: | :----: | :----: | :----: |
| Client.createUser | thrpt | 3 | 23.067 ± 2.783 | 22.082 ± 2.066 | ops/ms |
| Client.existUser | thrpt | 3 | 41.526 ± 5.468 | 41.490 ± 1.442 | ops/ms |
| Client.getUser | thrpt | 3 | 23.092 ± 4.975 | 22.077 ± 1.809 | ops/ms |
| Client.listUser | thrpt | 3 | 3.548 ± 0.077 | 2.972 ± 0.022 | ops/ms |
| Client.createUser | avgt | 3 | 1.430 ± 0.102 | 1.452 ± 0.351 | ms/op |
| Client.existUser | avgt | 3 | 0.750 ± 0.154 | 0.772 ± 0.100 | ms/op |
| Client.getUser | avgt | 3 | 1.361 ± 0.145 | 1.445 ± 0.173 | ms/op |
| Client.listUser | avgt | 3 | 8.981 ± 0.220 | 10.730 ± 0.700 | ms/op |
| Client.createUser | sample | | 1.394 ± 0.002 | 1.479 ± 0.002 | ms/op |
| Client.createUser:createUser·p0.00 | sample | | 0.600 | 0.509 | ms/op |
| Client.createUser:createUser·p0.50 | sample | | 1.225 | 1.300 | ms/op |
| Client.createUser:createUser·p0.90 | sample | | 2.154 | 2.269 | ms/op |
| Client.createUser:createUser·p0.95 | sample | | 2.294 | 2.425 | ms/op |
| Client.createUser:createUser·p0.99 | sample | | 2.707 | 2.875 | ms/op |
| Client.createUser:createUser·p0.999 | sample | | 3.431 | 3.580 | ms/op |
| Client.createUser:createUser·p0.9999 | sample | | 12.190 | 12.461 | ms/op |
| Client.createUser:createUser·p1.00 | sample | | 14.500 | 14.516 | ms/op |
| Client.existUser | sample | | 0.758 ± 0.001 | 0.771 ± 0.001 | ms/op |
| Client.existUser:existUser·p0.00 | sample | | 0.242 | 0.242 | ms/op |
| Client.existUser:existUser·p0.50 | sample | | 0.735 | 0.753 | ms/op |
| Client.existUser:existUser·p0.90 | sample | | 1.002 | 1.008 | ms/op |
| Client.existUser:existUser·p0.95 | sample | | 1.106 | 1.100 | ms/op |
| Client.existUser:existUser·p0.99 | sample | | 1.286 | 1.274 | ms/op |
| Client.existUser:existUser·p0.999 | sample | | 1.688 | 1.577 | ms/op |
| Client.existUser:existUser·p0.9999 | sample | | 12.468 | 12.297 | ms/op |
| Client.existUser:existUser·p1.00 | sample | | 15.221 | 14.729 | ms/op |
| Client.getUser | sample | | 1.390 ± 0.001 | 1.458 ± 0.001 | ms/op |
| Client.getUser:getUser·p0.00 | sample | | 0.387 | 0.425 | ms/op |
| Client.getUser:getUser·p0.50 | sample | | 1.399 | 1.468 | ms/op |
| Client.getUser:getUser·p0.90 | sample | | 1.632 | 1.686 | ms/op |
| Client.getUser:getUser·p0.95 | sample | | 1.737 | 1.794 | ms/op |
| Client.getUser:getUser·p0.99 | sample | | 1.997 | 2.054 | ms/op |
| Client.getUser:getUser·p0.999 | sample | | 2.822 | 3.262 | ms/op |
| Client.getUser:getUser·p0.9999 | sample | | 16.253 | 12.898 | ms/op |
| Client.getUser:getUser·p1.00 | sample | | 19.857 | 16.040 | ms/op |
| Client.listUser | sample | | 9.021 ± 0.015 | 10.731 ± 0.020 | ms/op |
| Client.listUser:listUser·p0.00 | sample | | 1.608 | 1.884 | ms/op |
| Client.listUser:listUser·p0.50 | sample | | 9.290 | 11.026 | ms/op |
| Client.listUser:listUser·p0.90 | sample | | 9.994 | 11.698 | ms/op |
| Client.listUser:listUser·p0.95 | sample | | 10.256 | 12.091 | ms/op |
| Client.listUser:listUser·p0.99 | sample | | 11.190 | 13.271 | ms/op |
| Client.listUser:listUser·p0.999 | sample | | 15.362 | 19.189 | ms/op |
| Client.listUser:listUser·p0.9999 | sample | | 17.182 | 20.418 | ms/op |
| Client.listUser:listUser·p1.00 | sample | | 23.167 | 21.987 | ms/op |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9e39cbf) into [3.0](https://codecov.io/gh/apache/dubbo/commit/dfe4fcaea107ac292e6f2e967807a0756f59c7e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dfe4fca) will **increase** coverage by `0.02%`.
> The diff coverage is `72.92%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
+ Coverage 65.59% 65.62% +0.02%
- Complexity 297 355 +58
============================================
Files 1191 1211 +20
Lines 52068 52653 +585
Branches 7907 7954 +47
============================================
+ Hits 34154 34552 +398
- Misses 14231 14385 +154
- Partials 3683 3716 +33
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/dubbo/metrics/service/DefaultMetricsService.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9zZXJ2aWNlL0RlZmF1bHRNZXRyaWNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...n/java/org/apache/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvTmV0VXRpbHMuamF2YQ==) | `69.00% <33.33%> (-0.03%)` | :arrow_down: |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `38.46% <38.46%> (ø)` | |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `50.00% <50.00%> (ø)` | |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `82.52% <50.00%> (+0.26%)` | :arrow_up: |
| [...pache/dubbo/common/metrics/event/MetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9NZXRyaWNzRXZlbnQuamF2YQ==) | `57.14% <57.14%> (ø)` | |
| [...common/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `58.33% <58.33%> (ø)` | |
| [.../apache/dubbo/metrics/AbstractMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9BYnN0cmFjdE1ldHJpY3NSZXBvcnRlci5qYXZh) | `61.29% <61.29%> (ø)` | |
| ... and [38 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dfe4fca...9e39cbf](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (659c02a) into [3.0](https://codecov.io/gh/apache/dubbo/commit/dfe4fcaea107ac292e6f2e967807a0756f59c7e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dfe4fca) will **decrease** coverage by `0.07%`.
> The diff coverage is `72.92%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
- Coverage 65.59% 65.51% -0.08%
- Complexity 297 355 +58
============================================
Files 1191 1211 +20
Lines 52068 52653 +585
Branches 7907 7954 +47
============================================
+ Hits 34154 34498 +344
- Misses 14231 14420 +189
- Partials 3683 3735 +52
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/dubbo/metrics/service/DefaultMetricsService.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9zZXJ2aWNlL0RlZmF1bHRNZXRyaWNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...n/java/org/apache/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvTmV0VXRpbHMuamF2YQ==) | `68.05% <33.33%> (-0.99%)` | :arrow_down: |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `38.46% <38.46%> (ø)` | |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `50.00% <50.00%> (ø)` | |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `82.52% <50.00%> (+0.26%)` | :arrow_up: |
| [...pache/dubbo/common/metrics/event/MetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9NZXRyaWNzRXZlbnQuamF2YQ==) | `57.14% <57.14%> (ø)` | |
| [...common/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `58.33% <58.33%> (ø)` | |
| [.../apache/dubbo/metrics/AbstractMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9BYnN0cmFjdE1ldHJpY3NSZXBvcnRlci5qYXZh) | `61.29% <61.29%> (ø)` | |
| ... and [50 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dfe4fca...659c02a](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [WIP][3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (58e746c) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **decrease** coverage by `0.52%`.
> The diff coverage is `15.97%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
- Coverage 64.70% 64.18% -0.53%
- Complexity 327 330 +3
============================================
Files 1206 1226 +20
Lines 51844 52414 +570
Branches 7716 7765 +49
============================================
+ Hits 33546 33640 +94
- Misses 14684 15153 +469
- Partials 3614 3621 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/event/BaseMetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9CYXNlTWV0cmljc0V2ZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../apache/dubbo/common/metrics/event/NewRTEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9OZXdSVEV2ZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...he/dubbo/common/metrics/event/NewRequestEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9OZXdSZXF1ZXN0RXZlbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...he/dubbo/common/metrics/model/InterfaceMetric.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9JbnRlcmZhY2VNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...pache/dubbo/common/metrics/model/MethodMetric.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9NZXRob2RNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...common/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [27 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...58e746c](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r762411552
##########
File path: dubbo-common/src/main/java/org/apache/dubbo/common/metrics/collector/DefaultMetricsCollector.java
##########
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.common.metrics.collector;
+
+import org.apache.dubbo.common.metrics.event.BaseMetricsEvent;
+import org.apache.dubbo.common.metrics.event.NewRTEvent;
+import org.apache.dubbo.common.metrics.event.NewRequestEvent;
+import org.apache.dubbo.common.metrics.listener.MetricsListener;
+import org.apache.dubbo.common.metrics.model.MethodMetric;
+import org.apache.dubbo.common.metrics.model.sample.GaugeMetricSample;
+import org.apache.dubbo.common.metrics.model.sample.MetricSample;
+import org.apache.dubbo.rpc.model.ApplicationModel;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicLong;
+
+import static org.apache.dubbo.common.metrics.model.MetricsCategory.REQUESTS;
+import static org.apache.dubbo.common.metrics.model.MetricsCategory.RT;
+
+/**
+ * Default implementation of {@link MetricsCollector}
+ */
+public class DefaultMetricsCollector implements MetricsCollector {
+
+ private Boolean collectEnabled = false;
+ private final List<MetricsListener> listeners = new ArrayList<>();
+ private final ApplicationModel applicationModel;
+ private final String applicationName;
+
+ private final Map<MethodMetric, AtomicLong> totalRequests = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> succeedRequests = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> failedRequests = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> processingRequests = new HashMap<>();
+
+ private final Map<MethodMetric, AtomicLong> lastRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> minRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> maxRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> avgRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> totalRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> rtCount = new HashMap<>();
+
+ public DefaultMetricsCollector(ApplicationModel applicationModel) {
+ this.applicationModel = applicationModel;
+ this.applicationName = applicationModel.tryGetApplicationName();
+ }
+
+ public void setCollectEnabled(Boolean collectEnabled) {
+ this.collectEnabled = collectEnabled;
+ }
+
+ public Boolean isCollectEnabled() {
+ return collectEnabled;
+ }
+
+ public void addListener(MetricsListener listener) {
+ listeners.add(listener);
+ }
+
+ public void increaseTotalRequests(String interfaceName, String methodName, String parameterTypesDesc, String group, String version) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+ AtomicLong count = totalRequests.computeIfAbsent(metric, k -> new AtomicLong(0L));
+ count.incrementAndGet();
+
+ publishEvent(new NewRequestEvent(metric, NewRequestEvent.Type.TOTAL));
+ }
+ }
+
+ public void increaseSucceedRequests(String interfaceName, String methodName, String parameterTypesDesc, String group, String version) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+ AtomicLong count = succeedRequests.computeIfAbsent(metric, k -> new AtomicLong(0L));
+ count.incrementAndGet();
+
+ publishEvent(new NewRequestEvent(metric, NewRequestEvent.Type.SUCCEED));
+ }
+ }
+
+ public void increaseFailedRequests(String interfaceName, String methodName, String parameterTypesDesc, String group, String version) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+ AtomicLong count = failedRequests.computeIfAbsent(metric, k -> new AtomicLong(0L));
+ count.incrementAndGet();
+
+ publishEvent(new NewRequestEvent(metric, NewRequestEvent.Type.FAILED));
+ }
+ }
+
+ public void increaseProcessingRequests(String interfaceName, String methodName, String parameterTypesDesc, String group, String version) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+ AtomicLong count = processingRequests.computeIfAbsent(metric, k -> new AtomicLong(0L));
+ count.incrementAndGet();
+ }
+ }
+
+ public void decreaseProcessingRequests(String interfaceName, String methodName, String parameterTypesDesc, String group, String version) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+ AtomicLong count = processingRequests.computeIfAbsent(metric, k -> new AtomicLong(0L));
+ count.decrementAndGet();
+ }
+ }
+
+ public void addRT(String interfaceName, String methodName, String parameterTypesDesc, String group, String version, Long responseTime) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+
+ AtomicLong last = lastRT.computeIfAbsent(metric, k -> new AtomicLong());
+ last.set(responseTime);
+
+ AtomicLong min = minRT.computeIfAbsent(metric, k -> new AtomicLong(Long.MAX_VALUE));
+ if (responseTime < min.longValue()) {
+ min.set(responseTime);
+ }
Review comment:
This kind of compare and set is unsafe when execute concurrently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (44ef2f6) into [3.0](https://codecov.io/gh/apache/dubbo/commit/954c715366931dd81cf66592700f6f54b1cbbe09?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (954c715) will **decrease** coverage by `0.23%`.
> The diff coverage is `72.75%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
- Coverage 65.38% 65.14% -0.24%
- Complexity 342 405 +63
============================================
Files 1202 1222 +20
Lines 51844 52485 +641
Branches 7727 7733 +6
============================================
+ Hits 33898 34192 +294
- Misses 14334 14620 +286
- Partials 3612 3673 +61
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `82.58% <0.00%> (+0.26%)` | :arrow_up: |
| [...e/dubbo/metrics/service/DefaultMetricsService.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9zZXJ2aWNlL0RlZmF1bHRNZXRyaWNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...n/java/org/apache/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvTmV0VXRpbHMuamF2YQ==) | `67.94% <33.33%> (-1.09%)` | :arrow_down: |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `38.46% <38.46%> (ø)` | |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `50.00% <50.00%> (ø)` | |
| [...pache/dubbo/common/metrics/event/MetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9NZXRyaWNzRXZlbnQuamF2YQ==) | `57.14% <57.14%> (ø)` | |
| [...common/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `58.33% <58.33%> (ø)` | |
| [.../apache/dubbo/metrics/AbstractMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9BYnN0cmFjdE1ldHJpY3NSZXBvcnRlci5qYXZh) | `61.29% <61.29%> (ø)` | |
| ... and [99 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [954c715...44ef2f6](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9e8b215) into [3.0](https://codecov.io/gh/apache/dubbo/commit/8a7c360475a6fe33697fd4a1c9cae378f977f684?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8a7c360) will **decrease** coverage by `0.05%`.
> The diff coverage is `72.92%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
- Coverage 65.32% 65.27% -0.06%
- Complexity 343 400 +57
============================================
Files 1202 1222 +20
Lines 51841 52429 +588
Branches 7726 7773 +47
============================================
+ Hits 33865 34222 +357
- Misses 14366 14563 +197
- Partials 3610 3644 +34
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/dubbo/metrics/service/DefaultMetricsService.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9zZXJ2aWNlL0RlZmF1bHRNZXRyaWNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...n/java/org/apache/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvTmV0VXRpbHMuamF2YQ==) | `68.05% <33.33%> (-0.99%)` | :arrow_down: |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `38.46% <38.46%> (ø)` | |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `50.00% <50.00%> (ø)` | |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `82.58% <50.00%> (+0.26%)` | :arrow_up: |
| [...pache/dubbo/common/metrics/event/MetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9NZXRyaWNzRXZlbnQuamF2YQ==) | `57.14% <57.14%> (ø)` | |
| [...common/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `58.33% <58.33%> (ø)` | |
| [.../apache/dubbo/metrics/AbstractMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9BYnN0cmFjdE1ldHJpY3NSZXBvcnRlci5qYXZh) | `61.29% <61.29%> (ø)` | |
| ... and [38 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8a7c360...9e8b215](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1c2f709) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **increase** coverage by `0.55%`.
> The diff coverage is `70.89%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
+ Coverage 64.70% 65.26% +0.55%
- Complexity 327 398 +71
============================================
Files 1206 1221 +15
Lines 51844 52251 +407
Branches 7716 7719 +3
============================================
+ Hits 33546 34099 +553
+ Misses 14684 14489 -195
- Partials 3614 3663 +49
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/dubbo/metrics/service/DefaultMetricsService.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9zZXJ2aWNlL0RlZmF1bHRNZXRyaWNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...he/dubbo/common/metrics/model/InterfaceMetric.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9JbnRlcmZhY2VNZXRyaWMuamF2YQ==) | `36.36% <36.36%> (ø)` | |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `38.46% <38.46%> (ø)` | |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `83.06% <50.00%> (+0.26%)` | :arrow_up: |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `52.38% <52.38%> (ø)` | |
| [...e/dubbo/common/metrics/event/BaseMetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9CYXNlTWV0cmljc0V2ZW50LmphdmE=) | `57.14% <57.14%> (ø)` | |
| [.../apache/dubbo/metrics/AbstractMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9BYnN0cmFjdE1ldHJpY3NSZXBvcnRlci5qYXZh) | `61.66% <61.66%> (ø)` | |
| [...pache/dubbo/common/metrics/model/MethodMetric.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9NZXRob2RNZXRyaWMuamF2YQ==) | `65.85% <65.85%> (ø)` | |
| ... and [185 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...1c2f709](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r762412000
##########
File path: dubbo-common/src/main/java/org/apache/dubbo/common/metrics/collector/DefaultMetricsCollector.java
##########
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.common.metrics.collector;
+
+import org.apache.dubbo.common.metrics.event.BaseMetricsEvent;
+import org.apache.dubbo.common.metrics.event.NewRTEvent;
+import org.apache.dubbo.common.metrics.event.NewRequestEvent;
+import org.apache.dubbo.common.metrics.listener.MetricsListener;
+import org.apache.dubbo.common.metrics.model.MethodMetric;
+import org.apache.dubbo.common.metrics.model.sample.GaugeMetricSample;
+import org.apache.dubbo.common.metrics.model.sample.MetricSample;
+import org.apache.dubbo.rpc.model.ApplicationModel;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicLong;
+
+import static org.apache.dubbo.common.metrics.model.MetricsCategory.REQUESTS;
+import static org.apache.dubbo.common.metrics.model.MetricsCategory.RT;
+
+/**
+ * Default implementation of {@link MetricsCollector}
+ */
+public class DefaultMetricsCollector implements MetricsCollector {
+
+ private Boolean collectEnabled = false;
+ private final List<MetricsListener> listeners = new ArrayList<>();
+ private final ApplicationModel applicationModel;
+ private final String applicationName;
+
+ private final Map<MethodMetric, AtomicLong> totalRequests = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> succeedRequests = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> failedRequests = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> processingRequests = new HashMap<>();
+
+ private final Map<MethodMetric, AtomicLong> lastRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> minRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> maxRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> avgRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> totalRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> rtCount = new HashMap<>();
+
+ public DefaultMetricsCollector(ApplicationModel applicationModel) {
+ this.applicationModel = applicationModel;
+ this.applicationName = applicationModel.tryGetApplicationName();
+ }
+
+ public void setCollectEnabled(Boolean collectEnabled) {
+ this.collectEnabled = collectEnabled;
+ }
+
+ public Boolean isCollectEnabled() {
+ return collectEnabled;
+ }
+
+ public void addListener(MetricsListener listener) {
+ listeners.add(listener);
+ }
+
+ public void increaseTotalRequests(String interfaceName, String methodName, String parameterTypesDesc, String group, String version) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+ AtomicLong count = totalRequests.computeIfAbsent(metric, k -> new AtomicLong(0L));
+ count.incrementAndGet();
+
+ publishEvent(new NewRequestEvent(metric, NewRequestEvent.Type.TOTAL));
+ }
+ }
+
+ public void increaseSucceedRequests(String interfaceName, String methodName, String parameterTypesDesc, String group, String version) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+ AtomicLong count = succeedRequests.computeIfAbsent(metric, k -> new AtomicLong(0L));
+ count.incrementAndGet();
+
+ publishEvent(new NewRequestEvent(metric, NewRequestEvent.Type.SUCCEED));
+ }
+ }
+
+ public void increaseFailedRequests(String interfaceName, String methodName, String parameterTypesDesc, String group, String version) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+ AtomicLong count = failedRequests.computeIfAbsent(metric, k -> new AtomicLong(0L));
+ count.incrementAndGet();
+
+ publishEvent(new NewRequestEvent(metric, NewRequestEvent.Type.FAILED));
+ }
+ }
+
+ public void increaseProcessingRequests(String interfaceName, String methodName, String parameterTypesDesc, String group, String version) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+ AtomicLong count = processingRequests.computeIfAbsent(metric, k -> new AtomicLong(0L));
+ count.incrementAndGet();
+ }
+ }
+
+ public void decreaseProcessingRequests(String interfaceName, String methodName, String parameterTypesDesc, String group, String version) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+ AtomicLong count = processingRequests.computeIfAbsent(metric, k -> new AtomicLong(0L));
+ count.decrementAndGet();
+ }
+ }
+
+ public void addRT(String interfaceName, String methodName, String parameterTypesDesc, String group, String version, Long responseTime) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+
+ AtomicLong last = lastRT.computeIfAbsent(metric, k -> new AtomicLong());
+ last.set(responseTime);
+
+ AtomicLong min = minRT.computeIfAbsent(metric, k -> new AtomicLong(Long.MAX_VALUE));
+ if (responseTime < min.longValue()) {
+ min.set(responseTime);
+ }
+
+ AtomicLong max = maxRT.computeIfAbsent(metric, k -> new AtomicLong(Long.MIN_VALUE));
+ if (responseTime > max.longValue()) {
+ max.set(responseTime);
+ }
Review comment:
Unsafe compare and set, see abrove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r762411201
##########
File path: dubbo-common/src/main/java/org/apache/dubbo/common/metrics/collector/DefaultMetricsCollector.java
##########
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.common.metrics.collector;
+
+import org.apache.dubbo.common.metrics.event.BaseMetricsEvent;
+import org.apache.dubbo.common.metrics.event.NewRTEvent;
+import org.apache.dubbo.common.metrics.event.NewRequestEvent;
+import org.apache.dubbo.common.metrics.listener.MetricsListener;
+import org.apache.dubbo.common.metrics.model.MethodMetric;
+import org.apache.dubbo.common.metrics.model.sample.GaugeMetricSample;
+import org.apache.dubbo.common.metrics.model.sample.MetricSample;
+import org.apache.dubbo.rpc.model.ApplicationModel;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicLong;
+
+import static org.apache.dubbo.common.metrics.model.MetricsCategory.REQUESTS;
+import static org.apache.dubbo.common.metrics.model.MetricsCategory.RT;
+
+/**
+ * Default implementation of {@link MetricsCollector}
+ */
+public class DefaultMetricsCollector implements MetricsCollector {
+
+ private Boolean collectEnabled = false;
+ private final List<MetricsListener> listeners = new ArrayList<>();
+ private final ApplicationModel applicationModel;
+ private final String applicationName;
+
+ private final Map<MethodMetric, AtomicLong> totalRequests = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> succeedRequests = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> failedRequests = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> processingRequests = new HashMap<>();
+
+ private final Map<MethodMetric, AtomicLong> lastRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> minRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> maxRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> avgRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> totalRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> rtCount = new HashMap<>();
+
+ public DefaultMetricsCollector(ApplicationModel applicationModel) {
+ this.applicationModel = applicationModel;
+ this.applicationName = applicationModel.tryGetApplicationName();
Review comment:
The `applicationName` is required, should not use `applicationModel.tryGetApplicationName()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r762407353
##########
File path: dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/AbstractMetricsReporter.java
##########
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.metrics;
+
+import org.apache.dubbo.common.URL;
+import org.apache.dubbo.common.lang.ShutdownHookCallbacks;
+import org.apache.dubbo.common.logger.Logger;
+import org.apache.dubbo.common.logger.LoggerFactory;
+import org.apache.dubbo.common.metrics.MetricsReporter;
+import org.apache.dubbo.common.metrics.collector.DefaultMetricsCollector;
+import org.apache.dubbo.common.metrics.collector.MetricsCollector;
+import org.apache.dubbo.common.metrics.model.sample.GaugeMetricSample;
+import org.apache.dubbo.common.metrics.model.sample.MetricSample;
+import org.apache.dubbo.common.utils.NamedThreadFactory;
+import org.apache.dubbo.metrics.collector.AggregateMetricsCollector;
+import org.apache.dubbo.rpc.model.ApplicationModel;
+
+import io.micrometer.core.instrument.Gauge;
+import io.micrometer.core.instrument.MeterRegistry;
+import io.micrometer.core.instrument.Tag;
+import io.micrometer.core.instrument.binder.jvm.ClassLoaderMetrics;
+import io.micrometer.core.instrument.binder.jvm.JvmGcMetrics;
+import io.micrometer.core.instrument.binder.jvm.JvmMemoryMetrics;
+import io.micrometer.core.instrument.binder.jvm.JvmThreadMetrics;
+import io.micrometer.core.instrument.binder.system.ProcessorMetrics;
+import io.micrometer.core.instrument.composite.CompositeMeterRegistry;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+
+import static org.apache.dubbo.common.constants.MetricsConstants.ENABLE_JVM_METRICS_KEY;
+
+/**
+ * AbstractMetricsReporter.
+ */
+public abstract class AbstractMetricsReporter implements MetricsReporter {
+
+ private final Logger logger = LoggerFactory.getLogger(AbstractMetricsReporter.class);
+
+ protected final URL url;
+ protected final List<MetricsCollector> collectors = new ArrayList<>();
+ protected final CompositeMeterRegistry compositeRegistry = new CompositeMeterRegistry();
+
+ private final ApplicationModel applicationModel;
+ private ScheduledExecutorService collectorSyncJobExecutor = null;
+
+ private static final int DEFAULT_SCHEDULE_INITIAL_DELAY = 5;
+ private static final int DEFAULT_SCHEDULE_PERIOD = 30;
+
+ protected AbstractMetricsReporter(URL url, ApplicationModel applicationModel) {
+ this.url = url;
+ this.applicationModel = applicationModel;
+ }
+
+ @Override
+ public void init() {
+ addJvmMetrics();
+ initCollectors();
+ scheduleMetricsCollectorSyncJob();
+
+ doInit();
+
+ registerDubboShutdownHook();
+ }
+
+ protected void addMeterRegistry(MeterRegistry registry) {
+ compositeRegistry.add(registry);
+ }
+
+ protected ApplicationModel getApplicationModel() {
+ return applicationModel;
+ }
+
+ private void addJvmMetrics() {
+ boolean enableJvmMetrics = url.getParameter(ENABLE_JVM_METRICS_KEY, false);
+ if (enableJvmMetrics) {
+ new ClassLoaderMetrics().bindTo(compositeRegistry);
+ new JvmMemoryMetrics().bindTo(compositeRegistry);
+ new JvmGcMetrics().bindTo(compositeRegistry);
+ new ProcessorMetrics().bindTo(compositeRegistry);
+ new JvmThreadMetrics().bindTo(compositeRegistry);
+ }
+ }
+
+ private void initCollectors() {
+ applicationModel.getBeanFactory().getOrRegisterBean(AggregateMetricsCollector.class);
+
+ collectors.add(applicationModel.getBeanFactory().getBean(DefaultMetricsCollector.class));
+ collectors.add(applicationModel.getBeanFactory().getBean(AggregateMetricsCollector.class));
+ }
+
+ private void scheduleMetricsCollectorSyncJob() {
+ NamedThreadFactory threadFactory = new NamedThreadFactory("metrics-collector-sync-job", true);
+ collectorSyncJobExecutor = Executors.newScheduledThreadPool(1, threadFactory);
+ collectorSyncJobExecutor.scheduleAtFixedRate(() -> {
+ collectors.forEach(collector -> {
+ List<MetricSample> samples = collector.collect();
+ for (MetricSample sample : samples) {
+ try {
+ switch (sample.getType()) {
+ case GAUGE:
+ GaugeMetricSample gaugeSample = (GaugeMetricSample) sample;
+ List<Tag> tags = new ArrayList<>();
+ gaugeSample.getTags().forEach((k, v) -> {
+ if (v == null) {
+ v = "";
+ }
+
+ tags.add(Tag.of(k, v));
Review comment:
Ignore tag if value is null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (659c02a) into [3.0](https://codecov.io/gh/apache/dubbo/commit/dfe4fcaea107ac292e6f2e967807a0756f59c7e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dfe4fca) will **increase** coverage by `0.08%`.
> The diff coverage is `72.92%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
+ Coverage 65.59% 65.68% +0.08%
- Complexity 297 355 +58
============================================
Files 1191 1211 +20
Lines 52068 52653 +585
Branches 7907 7954 +47
============================================
+ Hits 34154 34585 +431
- Misses 14231 14354 +123
- Partials 3683 3714 +31
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/dubbo/metrics/service/DefaultMetricsService.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9zZXJ2aWNlL0RlZmF1bHRNZXRyaWNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...n/java/org/apache/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvTmV0VXRpbHMuamF2YQ==) | `68.69% <33.33%> (-0.35%)` | :arrow_down: |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `38.46% <38.46%> (ø)` | |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `50.00% <50.00%> (ø)` | |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `82.52% <50.00%> (+0.26%)` | :arrow_up: |
| [...pache/dubbo/common/metrics/event/MetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9NZXRyaWNzRXZlbnQuamF2YQ==) | `57.14% <57.14%> (ø)` | |
| [...common/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `58.33% <58.33%> (ø)` | |
| [.../apache/dubbo/metrics/AbstractMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9BYnN0cmFjdE1ldHJpY3NSZXBvcnRlci5qYXZh) | `61.29% <61.29%> (ø)` | |
| ... and [34 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dfe4fca...659c02a](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kevinw66 edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kevinw66 edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-1023925740
## JVM Monitor
### Enable Metrics
<img width="1476" alt="enable-metrics" src="https://user-images.githubusercontent.com/31196226/151498239-fb31566d-1c4f-4abf-9ab6-ac70ab596322.png">
### Disable Metrics
<img width="1476" alt="disable-metrics" src="https://user-images.githubusercontent.com/31196226/151498866-0d49e5fe-e34d-4487-96e5-971c85625f53.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [WIP][3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (58e746c) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **decrease** coverage by `0.58%`.
> The diff coverage is `15.97%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
- Coverage 64.70% 64.12% -0.59%
- Complexity 327 330 +3
============================================
Files 1206 1226 +20
Lines 51844 52414 +570
Branches 7716 7765 +49
============================================
+ Hits 33546 33609 +63
- Misses 14684 15180 +496
- Partials 3614 3625 +11
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/event/BaseMetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9CYXNlTWV0cmljc0V2ZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../apache/dubbo/common/metrics/event/NewRTEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9OZXdSVEV2ZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...he/dubbo/common/metrics/event/NewRequestEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9OZXdSZXF1ZXN0RXZlbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...he/dubbo/common/metrics/model/InterfaceMetric.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9JbnRlcmZhY2VNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...pache/dubbo/common/metrics/model/MethodMetric.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9NZXRob2RNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...common/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [31 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...58e746c](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (659c02a) into [3.0](https://codecov.io/gh/apache/dubbo/commit/dfe4fcaea107ac292e6f2e967807a0756f59c7e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dfe4fca) will **increase** coverage by `0.02%`.
> The diff coverage is `72.92%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
+ Coverage 65.59% 65.62% +0.02%
- Complexity 297 355 +58
============================================
Files 1191 1211 +20
Lines 52068 52653 +585
Branches 7907 7954 +47
============================================
+ Hits 34154 34552 +398
- Misses 14231 14384 +153
- Partials 3683 3717 +34
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/dubbo/metrics/service/DefaultMetricsService.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9zZXJ2aWNlL0RlZmF1bHRNZXRyaWNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...n/java/org/apache/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvTmV0VXRpbHMuamF2YQ==) | `68.69% <33.33%> (-0.35%)` | :arrow_down: |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `38.46% <38.46%> (ø)` | |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `50.00% <50.00%> (ø)` | |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `82.52% <50.00%> (+0.26%)` | :arrow_up: |
| [...pache/dubbo/common/metrics/event/MetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9NZXRyaWNzRXZlbnQuamF2YQ==) | `57.14% <57.14%> (ø)` | |
| [...common/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `58.33% <58.33%> (ø)` | |
| [.../apache/dubbo/metrics/AbstractMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9BYnN0cmFjdE1ldHJpY3NSZXBvcnRlci5qYXZh) | `61.29% <61.29%> (ø)` | |
| ... and [35 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dfe4fca...659c02a](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kevinw66 edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kevinw66 edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-1022914821
After some benchmark test by `dubbo-benchmark` framework
The results is shown as below
Jvm parameters:
`JDK Version: 1.8.0_281`
`VM Arguments: -Xmx2g -Xms2g -XX:MaxDirectMemorySize=1g -XX:+UseG1GC`
## Throughput
### Enable Metrics
| Benchmark | Mode | Cnt | Score | Error | Units |
| :----: | :----: | :----: | :----: | :----: | :----: |
| Client.createUser | thrpt | 3 | 22.082 ± 2.066 | | ops/ms |
| Client.existUser | thrpt | 3 | 41.490 ± 1.442 | | ops/ms |
| Client.getUser | thrpt | 3 | 22.077 ± 1.809 | | ops/ms |
| Client.listUser | thrpt | 3 | 2.972 ± 0.022 | | ops/ms |
| Client.createUser | avgt | 3 | 1.452 ± 0.351 | | ms/op |
| Client.existUser | avgt | 3 | 0.772 ± 0.100 | | ms/op |
| Client.getUser | avgt | 3 | 1.445 ± 0.173 | | ms/op |
| Client.listUser | avgt | 3 | 10.730 ± 0.700 | | ms/op |
| Client.createUser | sample | 688220 | 1.479 ± 0.002 | | ms/op |
| Client.createUser:createUser·p0.00 | sample | | 0.509 | | ms/op |
| Client.createUser:createUser·p0.50 | sample | | 1.300 | | ms/op |
| Client.createUser:createUser·p0.90 | sample | | 2.269 | | ms/op |
| Client.createUser:createUser·p0.95 | sample | | 2.425 | | ms/op |
| Client.createUser:createUser·p0.99 | sample | | 2.875 | | ms/op |
| Client.createUser:createUser·p0.999 | sample | | 3.580 | | ms/op |
| Client.createUser:createUser·p0.9999 | sample | | 12.461 | | ms/op |
| Client.createUser:createUser·p1.00 | sample | | 14.516 | | ms/op |
| Client.existUser | sample | 1244807 | 0.771 ± 0.001 | | ms/op |
| Client.existUser:existUser·p0.00 | sample | | 0.242 | | ms/op |
| Client.existUser:existUser·p0.50 | sample | | 0.753 | | ms/op |
| Client.existUser:existUser·p0.90 | sample | | 1.008 | | ms/op |
| Client.existUser:existUser·p0.95 | sample | | 1.100 | | ms/op |
| Client.existUser:existUser·p0.99 | sample | | 1.274 | | ms/op |
| Client.existUser:existUser·p0.999 | sample | | 1.577 | | ms/op |
| Client.existUser:existUser·p0.9999 | sample | | 12.297 | | ms/op |
| Client.existUser:existUser·p1.00 | sample | | 14.729 | | ms/op |
| Client.getUser | sample | 657680 | 1.458 ± 0.001 | | ms/op |
| Client.getUser:getUser·p0.00 | sample | | 0.425 | | ms/op |
| Client.getUser:getUser·p0.50 | sample | | 1.468 | | ms/op |
| Client.getUser:getUser·p0.90 | sample | | 1.686 | | ms/op |
| Client.getUser:getUser·p0.95 | sample | | 1.794 | | ms/op |
| Client.getUser:getUser·p0.99 | sample | | 2.054 | | ms/op |
| Client.getUser:getUser·p0.999 | sample | | 3.262 | | ms/op |
| Client.getUser:getUser·p0.9999 | sample | | 12.898 | | ms/op |
| Client.getUser:getUser·p1.00 | sample | | 16.040 | | ms/op |
| Client.listUser | sample | 89410 | 10.731 ± 0.020 | | ms/op |
| Client.listUser:listUser·p0.00 | sample | | 1.884 | | ms/op |
| Client.listUser:listUser·p0.50 | sample | | 11.026 | | ms/op |
| Client.listUser:listUser·p0.90 | sample | | 11.698 | | ms/op |
| Client.listUser:listUser·p0.95 | sample | | 12.091 | | ms/op |
| Client.listUser:listUser·p0.99 | sample | | 13.271 | | ms/op |
| Client.listUser:listUser·p0.999 | sample | | 19.189 | | ms/op |
| Client.listUser:listUser·p0.9999 | sample | | 20.418 | | ms/op |
| Client.listUser:listUser·p1.00 | sample | | 21.987 | | ms/op |
### Disable Metrics
| Benchmark | Mode | Cnt | Score | Error | Units |
| :----: | :----: | :----: | :----: | :----: | :----: |
| Client.createUser | thrpt | 3 | 23.067 ± 2.783 | | ops/ms |
| Client.existUser | thrpt | 3 | 41.526 ± 5.468 | | ops/ms |
| Client.getUser | thrpt | 3 | 23.092 ± 4.975 | | ops/ms |
| Client.listUser | thrpt | 3 | 3.548 ± 0.077 | | ops/ms |
| Client.createUser | avgt | 3 | 1.430 ± 0.102 | | ms/op |
| Client.existUser | avgt | 3 | 0.750 ± 0.154 | | ms/op |
| Client.getUser | avgt | 3 | 1.361 ± 0.145 | | ms/op |
| Client.listUser | avgt | 3 | 8.981 ± 0.220 | | ms/op |
| Client.createUser | sample | 688350 | 1.394 ± 0.002 | | ms/op |
| Client.createUser:createUser·p0.00 | sample | | 0.600 | | ms/op |
| Client.createUser:createUser·p0.50 | sample | | 1.225 | | ms/op |
| Client.createUser:createUser·p0.90 | sample | | 2.154 | | ms/op |
| Client.createUser:createUser·p0.95 | sample | | 2.294 | | ms/op |
| Client.createUser:createUser·p0.99 | sample | | 2.707 | | ms/op |
| Client.createUser:createUser·p0.999 | sample | | 3.431 | | ms/op |
| Client.createUser:createUser·p0.9999 | sample | | 12.190 | | ms/op |
| Client.createUser:createUser·p1.00 | sample | | 14.500 | | ms/op |
| Client.existUser | sample | 1266489 | 0.758 ± 0.001 | | ms/op |
| Client.existUser:existUser·p0.00 | sample | | 0.242 | | ms/op |
| Client.existUser:existUser·p0.50 | sample | | 0.735 | | ms/op |
| Client.existUser:existUser·p0.90 | sample | | 1.002 | | ms/op |
| Client.existUser:existUser·p0.95 | sample | | 1.106 | | ms/op |
| Client.existUser:existUser·p0.99 | sample | | 1.286 | | ms/op |
| Client.existUser:existUser·p0.999 | sample | | 1.688 | | ms/op |
| Client.existUser:existUser·p0.9999 | sample | | 12.468 | | ms/op |
| Client.existUser:existUser·p1.00 | sample | | 15.221 | | ms/op |
| Client.getUser | sample | 689952 | 1.390 ± 0.001 | | ms/op |
| Client.getUser:getUser·p0.00 | sample | | 0.387 | | ms/op |
| Client.getUser:getUser·p0.50 | sample | | 1.399 | | ms/op |
| Client.getUser:getUser·p0.90 | sample | | 1.632 | | ms/op |
| Client.getUser:getUser·p0.95 | sample | | 1.737 | | ms/op |
| Client.getUser:getUser·p0.99 | sample | | 1.997 | | ms/op |
| Client.getUser:getUser·p0.999 | sample | | 2.822 | | ms/op |
| Client.getUser:getUser·p0.9999 | sample | | 16.253 | | ms/op |
| Client.getUser:getUser·p1.00 | sample | | 19.857 | | ms/op |
| Client.listUser | sample | 106368 | 9.021 ± 0.015 | | ms/op |
| Client.listUser:listUser·p0.00 | sample | | 1.608 | | ms/op |
| Client.listUser:listUser·p0.50 | sample | | 9.290 | | ms/op |
| Client.listUser:listUser·p0.90 | sample | | 9.994 | | ms/op |
| Client.listUser:listUser·p0.95 | sample | | 10.256 | | ms/op |
| Client.listUser:listUser·p0.99 | sample | | 11.190 | | ms/op |
| Client.listUser:listUser·p0.999 | sample | | 15.362 | | ms/op |
| Client.listUser:listUser·p0.9999 | sample | | 17.182 | | ms/op |
| Client.listUser:listUser·p1.00 | sample | | 23.167 | | ms/op |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r771085938
##########
File path: dubbo-metrics/dubbo-metrics-prometheus/src/main/java/org/apache/dubbo/metrics/prometheus/PrometheusMetricsReporter.java
##########
@@ -93,7 +94,8 @@ private void exportHttpServer() {
}
});
- new Thread(prometheusExporterHttpServer::start).start();
+ httpServerThread = new Thread(prometheusExporterHttpServer::start);
+ httpServerThread.start();
Review comment:
The http server management seems a bit strange, see about: https://stackoverflow.com/a/2917297
Use executor service likes better.
```java
this.httpServer = HttpServer.create(addr, 0);
HttpContext context = this.httpServer.createContext("/", new DocumentProcessHandler());
this.httpThreadPool = Executors.newFixedThreadPool(this.noOfThreads);
this.httpServer.setExecutor(this.httpThreadPool);
this.httpServer.start();
```
```java
this.httpServer.stop(1);
this.httpThreadPool.shutdownNow();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (18160d3) into [3.0](https://codecov.io/gh/apache/dubbo/commit/954c715366931dd81cf66592700f6f54b1cbbe09?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (954c715) will **increase** coverage by `0.07%`.
> The diff coverage is `72.92%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
+ Coverage 65.34% 65.42% +0.07%
- Complexity 341 400 +59
============================================
Files 1202 1222 +20
Lines 51844 52429 +585
Branches 7727 7773 +46
============================================
+ Hits 33879 34301 +422
- Misses 14351 14482 +131
- Partials 3614 3646 +32
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/dubbo/metrics/service/DefaultMetricsService.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9zZXJ2aWNlL0RlZmF1bHRNZXRyaWNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...n/java/org/apache/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvTmV0VXRpbHMuamF2YQ==) | `68.69% <33.33%> (-0.35%)` | :arrow_down: |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `38.46% <38.46%> (ø)` | |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `50.00% <50.00%> (ø)` | |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `82.58% <50.00%> (+0.26%)` | :arrow_up: |
| [...pache/dubbo/common/metrics/event/MetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9NZXRyaWNzRXZlbnQuamF2YQ==) | `57.14% <57.14%> (ø)` | |
| [...common/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `58.33% <58.33%> (ø)` | |
| [.../apache/dubbo/metrics/AbstractMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9BYnN0cmFjdE1ldHJpY3NSZXBvcnRlci5qYXZh) | `61.29% <61.29%> (ø)` | |
| ... and [28 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [954c715...18160d3](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1c2f709) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **increase** coverage by `0.66%`.
> The diff coverage is `70.89%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
+ Coverage 64.70% 65.37% +0.66%
- Complexity 327 401 +74
============================================
Files 1206 1221 +15
Lines 51844 52308 +464
Branches 7716 7772 +56
============================================
+ Hits 33546 34195 +649
+ Misses 14684 14465 -219
- Partials 3614 3648 +34
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/dubbo/metrics/service/DefaultMetricsService.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9zZXJ2aWNlL0RlZmF1bHRNZXRyaWNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...he/dubbo/common/metrics/model/InterfaceMetric.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9JbnRlcmZhY2VNZXRyaWMuamF2YQ==) | `36.36% <36.36%> (ø)` | |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `38.46% <38.46%> (ø)` | |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `83.06% <50.00%> (+0.26%)` | :arrow_up: |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `52.38% <52.38%> (ø)` | |
| [...e/dubbo/common/metrics/event/BaseMetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9CYXNlTWV0cmljc0V2ZW50LmphdmE=) | `57.14% <57.14%> (ø)` | |
| [.../apache/dubbo/metrics/AbstractMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9BYnN0cmFjdE1ldHJpY3NSZXBvcnRlci5qYXZh) | `61.66% <61.66%> (ø)` | |
| [...pache/dubbo/common/metrics/model/MethodMetric.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9NZXRob2RNZXRyaWMuamF2YQ==) | `65.85% <65.85%> (ø)` | |
| ... and [161 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...1c2f709](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r762410043
##########
File path: dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/metrics/DefaultMetricsServiceExporter.java
##########
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.config.metrics;
+
+import org.apache.dubbo.common.extension.ExtensionLoader;
+import org.apache.dubbo.common.logger.Logger;
+import org.apache.dubbo.common.logger.LoggerFactory;
+import org.apache.dubbo.common.metrics.service.MetricsService;
+import org.apache.dubbo.common.metrics.service.MetricsServiceExporter;
+import org.apache.dubbo.common.utils.CollectionUtils;
+import org.apache.dubbo.config.ApplicationConfig;
+import org.apache.dubbo.config.MetricsConfig;
+import org.apache.dubbo.config.ProtocolConfig;
+import org.apache.dubbo.config.RegistryConfig;
+import org.apache.dubbo.config.ServiceConfig;
+import org.apache.dubbo.rpc.model.ApplicationModel;
+import org.apache.dubbo.rpc.model.ScopeModelAware;
+
+import java.util.List;
+
+import static org.apache.dubbo.common.constants.CommonConstants.DUBBO_PROTOCOL;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROTOCOL_PROMETHEUS;
+
+/**
+ * Default implementation of {@link MetricsServiceExporter}
+ */
+public class DefaultMetricsServiceExporter implements MetricsServiceExporter, ScopeModelAware {
+
+ private final Logger logger = LoggerFactory.getLogger(getClass());
+
+ private ApplicationModel applicationModel;
+ private MetricsService metricsService;
+ private volatile ServiceConfig<MetricsService> serviceConfig;
+
+ public DefaultMetricsServiceExporter() {
+ }
+
+ @Override
+ public void init() {
+ initialize();
+ }
+
+ private void initialize() {
+ MetricsConfig metricsConfig = applicationModel.getApplicationConfigManager().getMetrics().orElse(null);
+ // TODO compatible with old usage of metrics, remove protocol check after new metrics is ready for use.
+ if (metricsConfig != null && PROTOCOL_PROMETHEUS.equals(metricsConfig.getProtocol())) {
+ ExtensionLoader<MetricsService> extensionLoader = applicationModel.getExtensionLoader(MetricsService.class);
Review comment:
The protocol of metrics maybe changed if user has custom it. The `MetricsService` is not rely on prometheus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r762410542
##########
File path: dubbo-common/src/main/java/org/apache/dubbo/common/metrics/event/NewRequestEvent.java
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.common.metrics.event;
+
+/**
+ * RequestChangedEvent.
+ */
+public class NewRequestEvent extends BaseMetricsEvent {
Review comment:
Suggest rename `NewRequestEvent` to `RequestEvent`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r762412637
##########
File path: dubbo-common/src/main/java/org/apache/dubbo/common/metrics/collector/DefaultMetricsCollector.java
##########
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.common.metrics.collector;
+
+import org.apache.dubbo.common.metrics.event.BaseMetricsEvent;
+import org.apache.dubbo.common.metrics.event.NewRTEvent;
+import org.apache.dubbo.common.metrics.event.NewRequestEvent;
+import org.apache.dubbo.common.metrics.listener.MetricsListener;
+import org.apache.dubbo.common.metrics.model.MethodMetric;
+import org.apache.dubbo.common.metrics.model.sample.GaugeMetricSample;
+import org.apache.dubbo.common.metrics.model.sample.MetricSample;
+import org.apache.dubbo.rpc.model.ApplicationModel;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicLong;
+
+import static org.apache.dubbo.common.metrics.model.MetricsCategory.REQUESTS;
+import static org.apache.dubbo.common.metrics.model.MetricsCategory.RT;
+
+/**
+ * Default implementation of {@link MetricsCollector}
+ */
+public class DefaultMetricsCollector implements MetricsCollector {
+
+ private Boolean collectEnabled = false;
+ private final List<MetricsListener> listeners = new ArrayList<>();
+ private final ApplicationModel applicationModel;
+ private final String applicationName;
+
+ private final Map<MethodMetric, AtomicLong> totalRequests = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> succeedRequests = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> failedRequests = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> processingRequests = new HashMap<>();
+
+ private final Map<MethodMetric, AtomicLong> lastRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> minRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> maxRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> avgRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> totalRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> rtCount = new HashMap<>();
+
+ public DefaultMetricsCollector(ApplicationModel applicationModel) {
+ this.applicationModel = applicationModel;
+ this.applicationName = applicationModel.tryGetApplicationName();
+ }
+
+ public void setCollectEnabled(Boolean collectEnabled) {
+ this.collectEnabled = collectEnabled;
+ }
+
+ public Boolean isCollectEnabled() {
+ return collectEnabled;
+ }
+
+ public void addListener(MetricsListener listener) {
+ listeners.add(listener);
+ }
+
+ public void increaseTotalRequests(String interfaceName, String methodName, String parameterTypesDesc, String group, String version) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+ AtomicLong count = totalRequests.computeIfAbsent(metric, k -> new AtomicLong(0L));
+ count.incrementAndGet();
+
+ publishEvent(new NewRequestEvent(metric, NewRequestEvent.Type.TOTAL));
+ }
+ }
+
+ public void increaseSucceedRequests(String interfaceName, String methodName, String parameterTypesDesc, String group, String version) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+ AtomicLong count = succeedRequests.computeIfAbsent(metric, k -> new AtomicLong(0L));
+ count.incrementAndGet();
+
+ publishEvent(new NewRequestEvent(metric, NewRequestEvent.Type.SUCCEED));
+ }
+ }
+
+ public void increaseFailedRequests(String interfaceName, String methodName, String parameterTypesDesc, String group, String version) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+ AtomicLong count = failedRequests.computeIfAbsent(metric, k -> new AtomicLong(0L));
+ count.incrementAndGet();
+
+ publishEvent(new NewRequestEvent(metric, NewRequestEvent.Type.FAILED));
+ }
+ }
+
+ public void increaseProcessingRequests(String interfaceName, String methodName, String parameterTypesDesc, String group, String version) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+ AtomicLong count = processingRequests.computeIfAbsent(metric, k -> new AtomicLong(0L));
+ count.incrementAndGet();
+ }
+ }
+
+ public void decreaseProcessingRequests(String interfaceName, String methodName, String parameterTypesDesc, String group, String version) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+ AtomicLong count = processingRequests.computeIfAbsent(metric, k -> new AtomicLong(0L));
+ count.decrementAndGet();
+ }
+ }
+
+ public void addRT(String interfaceName, String methodName, String parameterTypesDesc, String group, String version, Long responseTime) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+
+ AtomicLong last = lastRT.computeIfAbsent(metric, k -> new AtomicLong());
+ last.set(responseTime);
+
+ AtomicLong min = minRT.computeIfAbsent(metric, k -> new AtomicLong(Long.MAX_VALUE));
+ if (responseTime < min.longValue()) {
+ min.set(responseTime);
+ }
+
+ AtomicLong max = maxRT.computeIfAbsent(metric, k -> new AtomicLong(Long.MIN_VALUE));
+ if (responseTime > max.longValue()) {
+ max.set(responseTime);
+ }
+
+ AtomicLong total = totalRT.computeIfAbsent(metric, k -> new AtomicLong());
+ long newTotal = total.addAndGet(responseTime);
+
+ AtomicLong count = rtCount.computeIfAbsent(metric, k -> new AtomicLong());
+ AtomicLong avg = avgRT.computeIfAbsent(metric, k -> new AtomicLong());
+ long newAvg = newTotal / count.addAndGet(1);
+ avg.set(newAvg);
Review comment:
The computing of avg value is unsafe when execute concurrently. Lock it or compute avg value when fetching metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r771083988
##########
File path: dubbo-metrics/dubbo-metrics-prometheus/README.md
##########
@@ -0,0 +1,133 @@
+# Prometheus Metrics Reporter
+
+This is about how to use Prometheus to collector metrics from Apache Dubbo.
+
+## Usage
+
+As far as we know, Prometheus support both pull and push mode to collector metrics, Dubbo provided both way to let you
+choose which one you prefer.
+
+### Pull Mode
+
+For pull mode, you can add this config to your code.
+
+```java
+@Configuration
+public class DubboConfiguration {
+ @Bean
+ public MetricsConfig metricsConfig() {
+ MetricsConfig metricsConfig = new MetricsConfig();
+ metricsConfig.setProtocol(MetricsConstants.PROTOCOL_PROMETHEUS);
+
+ // collect jvm metrics
+ metricsConfig.setEnableJvmMetrics(true);
+
+ // add this config if you want to aggregate metrics in local machine.
+ // or you can aggregate by PromQL
+ AggregationConfig aggregationConfig = new AggregationConfig();
+ aggregationConfig.setEnabled(true);
+ aggregationConfig.setTimeWindowSeconds(120);
+ aggregationConfig.setBucketNum(5);
+ metricsConfig.setAggregation(aggregationConfig);
+
+ PrometheusConfig prometheusConfig = new PrometheusConfig();
+ PrometheusConfig.Exporter exporter = new PrometheusConfig.Exporter();
+ // this must be true if you are using exporter.
+ exporter.setEnabled(true);
+
+ // this will expose a httpserver to public, and the metrics url is http://localhost:20888/metrics.
+ exporter.setMetricsPath("/metrics");
+ exporter.setMetricsPort(20888);
+
+ prometheusConfig.setExporter(exporter);
+ metricsConfig.setPrometheus(prometheusConfig);
+
+ return metricsConfig;
+ }
+}
+```
+
+Or if you prefer xml config.
+
+```xml
+<dubbo:metrics protocol="prometheus" enable-jvm-metrics="true">
+ <dubbo:aggregation enabled="true" bucket-num="5" time-window-seconds="120" />
+ <dubbo:prometheus-exporter enabled="true" metrics-port="20888" metrics-path="/metrics" />
+</dubbo:metrics>
+```
Review comment:
Pls add properties or yaml config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r762406517
##########
File path: dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/service/DefaultMetricsService.java
##########
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.metrics.service;
+
+import org.apache.dubbo.common.metrics.collector.DefaultMetricsCollector;
+import org.apache.dubbo.common.metrics.collector.MetricsCollector;
+import org.apache.dubbo.common.metrics.model.MetricsCategory;
+import org.apache.dubbo.common.metrics.model.sample.GaugeMetricSample;
+import org.apache.dubbo.common.metrics.model.sample.MetricSample;
+import org.apache.dubbo.common.metrics.service.MetricsEntity;
+import org.apache.dubbo.common.metrics.service.MetricsService;
+import org.apache.dubbo.metrics.collector.AggregateMetricsCollector;
+import org.apache.dubbo.rpc.model.ApplicationModel;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+/**
+ * Default implementation of {@link MetricsService}
+ */
+public class DefaultMetricsService implements MetricsService {
+
+ protected final List<MetricsCollector> collectors = new ArrayList<>();
+
+ private final ApplicationModel applicationModel;
+
+ public DefaultMetricsService(ApplicationModel applicationModel) {
+ this.applicationModel = applicationModel;
+ collectors.add(applicationModel.getBeanFactory().getBean(DefaultMetricsCollector.class));
+ collectors.add(applicationModel.getBeanFactory().getBean(AggregateMetricsCollector.class));
+ }
+
+ @Override
+ public Map<MetricsCategory, List<MetricsEntity>> getMetricsByCategories(List<MetricsCategory> categories) {
+ return getMetricsByCategories(null, categories);
+ }
+
+ @Override
+ public Map<MetricsCategory, List<MetricsEntity>> getMetricsByCategories(String serviceUniqueName, List<MetricsCategory> categories) {
+ return getMetricsByCategories(serviceUniqueName, null, null, categories);
+ }
+
+ @Override
+ public Map<MetricsCategory, List<MetricsEntity>> getMetricsByCategories(String serviceUniqueName, String methodName, Class<?>[] parameterTypes, List<MetricsCategory> categories) {
+ Map<MetricsCategory, List<MetricsEntity>> result = new HashMap<>();
+ List<MetricSample> samples = getMetrics();
+ for (MetricSample sample : samples) {
+ if (categories.contains(sample.getCategory())) {
+ List<MetricsEntity> entities = result.computeIfAbsent(sample.getCategory(), k -> new ArrayList<>());
+ entities.add(sampleToEntity(sample));
+ }
+ }
+
+ return result;
+ }
+
+ private MetricsEntity sampleToEntity(MetricSample sample) {
+ MetricsEntity entity = new MetricsEntity();
+
+ entity.setName(sample.getName());
+ entity.setTags(sample.getTags());
+ entity.setCategory(sample.getCategory());
+ switch (sample.getType()) {
+ case GAUGE:
+ GaugeMetricSample gaugeSample = (GaugeMetricSample) sample;
+ entity.setValue(gaugeSample.getSupplier().get());
+ break;
+ case COUNTER:
+ case LONG_TASK_TIMER:
+ case TIMER:
+ case DISTRIBUTION_SUMMARY:
+ default:
+ break;
+ }
+
+ return entity;
+ }
+
+ private List<MetricSample> getMetrics() {
+ List<MetricSample> samples = new ArrayList<>();
+ for (MetricsCollector collector : collectors) {
+ samples.addAll(collector.collect());
+ }
Review comment:
The step of merging metrics is unnecessary and will cause memory fragmentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r762410458
##########
File path: dubbo-common/src/main/java/org/apache/dubbo/common/metrics/event/NewRTEvent.java
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.common.metrics.event;
+
+/**
+ * NewRtEvent.
+ */
+public class NewRTEvent extends BaseMetricsEvent {
Review comment:
The word `NewRTEvent` is inappropriate, I think rename to `RTEvent` is ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e96a0c9) into [3.0](https://codecov.io/gh/apache/dubbo/commit/dfe4fcaea107ac292e6f2e967807a0756f59c7e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dfe4fca) will **decrease** coverage by `0.16%`.
> The diff coverage is `72.92%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
- Coverage 65.59% 65.43% -0.17%
- Complexity 297 355 +58
============================================
Files 1191 1211 +20
Lines 52068 52653 +585
Branches 7907 7954 +47
============================================
+ Hits 34154 34451 +297
- Misses 14231 14468 +237
- Partials 3683 3734 +51
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/dubbo/metrics/service/DefaultMetricsService.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9zZXJ2aWNlL0RlZmF1bHRNZXRyaWNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...n/java/org/apache/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvTmV0VXRpbHMuamF2YQ==) | `68.05% <33.33%> (-0.99%)` | :arrow_down: |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `38.46% <38.46%> (ø)` | |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `50.00% <50.00%> (ø)` | |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `82.52% <50.00%> (+0.26%)` | :arrow_up: |
| [...pache/dubbo/common/metrics/event/MetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9NZXRyaWNzRXZlbnQuamF2YQ==) | `57.14% <57.14%> (ø)` | |
| [...common/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `58.33% <58.33%> (ø)` | |
| [.../apache/dubbo/metrics/AbstractMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9BYnN0cmFjdE1ldHJpY3NSZXBvcnRlci5qYXZh) | `61.29% <61.29%> (ø)` | |
| ... and [58 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dfe4fca...e96a0c9](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kevinw66 commented on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kevinw66 commented on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-1022914821
After some benchmark test by `dubbo-benchmark` framework
The Java Heap Space status is shown as below
Jvm parameters:
`JDK Version: 1.8.0_281`
`VM Arguments: -Xmx2g -Xms2g -XX:MaxDirectMemorySize=1g -XX:+UseG1GC`
Metrics enabled
Metrics disabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kevinw66 edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kevinw66 edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-1022914821
After some benchmark test by `dubbo-benchmark` framework
The results is shown as below
Jvm parameters:
`JDK Version: 1.8.0_281`
`VM Arguments: -Xmx2g -Xms2g -XX:MaxDirectMemorySize=1g -XX:+UseG1GC`
Because I tested on my laptop, The results is for reference only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [WIP][3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (58e746c) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **decrease** coverage by `0.54%`.
> The diff coverage is `15.97%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
- Coverage 64.70% 64.16% -0.55%
- Complexity 327 330 +3
============================================
Files 1206 1226 +20
Lines 51844 52414 +570
Branches 7716 7765 +49
============================================
+ Hits 33546 33630 +84
- Misses 14684 15163 +479
- Partials 3614 3621 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/event/BaseMetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9CYXNlTWV0cmljc0V2ZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../apache/dubbo/common/metrics/event/NewRTEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9OZXdSVEV2ZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...he/dubbo/common/metrics/event/NewRequestEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9OZXdSZXF1ZXN0RXZlbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...he/dubbo/common/metrics/model/InterfaceMetric.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9JbnRlcmZhY2VNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...pache/dubbo/common/metrics/model/MethodMetric.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9NZXRob2RNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...common/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [32 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...58e746c](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [WIP][3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (def4009) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **decrease** coverage by `0.51%`.
> The diff coverage is `16.14%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
- Coverage 64.70% 64.19% -0.52%
- Complexity 327 328 +1
============================================
Files 1206 1226 +20
Lines 51844 52414 +570
Branches 7716 7765 +49
============================================
+ Hits 33546 33647 +101
- Misses 14684 15149 +465
- Partials 3614 3618 +4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/event/BaseMetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9CYXNlTWV0cmljc0V2ZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../apache/dubbo/common/metrics/event/NewRTEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9OZXdSVEV2ZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...he/dubbo/common/metrics/event/NewRequestEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9OZXdSZXF1ZXN0RXZlbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...he/dubbo/common/metrics/model/InterfaceMetric.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9JbnRlcmZhY2VNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...pache/dubbo/common/metrics/model/MethodMetric.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9NZXRob2RNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...common/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [27 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...def4009](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kevinw66 edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kevinw66 edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-1023923825
## Throughput
| Benchmark | Mode | Cnt | Score(Normal) | Score(Metrics) | Units |
| :----: | :----: | :----: | :----: | :----: | :----: |
| Client.createUser | thrpt | 3 | 23.067 ± 2.783 | 22.082 ± 2.066 | ops/ms |
| Client.existUser | thrpt | 3 | 41.526 ± 5.468 | 41.490 ± 1.442 | ops/ms |
| Client.getUser | thrpt | 3 | 23.092 ± 4.975 | 22.077 ± 1.809 | ops/ms |
| Client.listUser | thrpt | 3 | 3.548 ± 0.077 | 2.972 ± 0.022 | ops/ms |
| Client.createUser | avgt | 3 | 1.430 ± 0.102 | 1.452 ± 0.351 | ms/op |
| Client.existUser | avgt | 3 | 0.750 ± 0.154 | 0.772 ± 0.100 | ms/op |
| Client.getUser | avgt | 3 | 1.361 ± 0.145 | 1.445 ± 0.173 | ms/op |
| Client.listUser | avgt | 3 | 8.981 ± 0.220 | 10.730 ± 0.700 | ms/op |
| Client.createUser | sample | 688220 | 1.394 ± 0.002 | 1.479 ± 0.002 | ms/op |
| Client.createUser:createUser·p0.00 | sample | | 0.600 | 0.509 | ms/op |
| Client.createUser:createUser·p0.50 | sample | | 1.225 | 1.300 | ms/op |
| Client.createUser:createUser·p0.90 | sample | | 2.154 | 2.269 | ms/op |
| Client.createUser:createUser·p0.95 | sample | | 2.294 | 2.425 | ms/op |
| Client.createUser:createUser·p0.99 | sample | | 2.707 | 2.875 | ms/op |
| Client.createUser:createUser·p0.999 | sample | | 3.431 | 3.580 | ms/op |
| Client.createUser:createUser·p0.9999 | sample | | 12.190 | 12.461 | ms/op |
| Client.createUser:createUser·p1.00 | sample | | 14.500 | 14.516 | ms/op |
| Client.existUser | sample | 1244807 | 0.758 ± 0.001 | 0.771 ± 0.001 | ms/op |
| Client.existUser:existUser·p0.00 | sample | | 0.242 | 0.242 | ms/op |
| Client.existUser:existUser·p0.50 | sample | | 0.735 | 0.753 | ms/op |
| Client.existUser:existUser·p0.90 | sample | | 1.002 | 1.008 | ms/op |
| Client.existUser:existUser·p0.95 | sample | | 1.106 | 1.100 | ms/op |
| Client.existUser:existUser·p0.99 | sample | | 1.286 | 1.274 | ms/op |
| Client.existUser:existUser·p0.999 | sample | | 1.688 | 1.577 | ms/op |
| Client.existUser:existUser·p0.9999 | sample | | 12.468 | 12.297 | ms/op |
| Client.existUser:existUser·p1.00 | sample | | 15.221 | 14.729 | ms/op |
| Client.getUser | sample | 657680 | 1.390 ± 0.001 | 1.458 ± 0.001 | ms/op |
| Client.getUser:getUser·p0.00 | sample | | 0.387 | 0.425 | ms/op |
| Client.getUser:getUser·p0.50 | sample | | 1.399 | 1.468 | ms/op |
| Client.getUser:getUser·p0.90 | sample | | 1.632 | 1.686 | ms/op |
| Client.getUser:getUser·p0.95 | sample | | 1.737 | 1.794 | ms/op |
| Client.getUser:getUser·p0.99 | sample | | 1.997 | 2.054 | ms/op |
| Client.getUser:getUser·p0.999 | sample | | 2.822 | 3.262 | ms/op |
| Client.getUser:getUser·p0.9999 | sample | | 16.253 | 12.898 | ms/op |
| Client.getUser:getUser·p1.00 | sample | | 19.857 | 16.040 | ms/op |
| Client.listUser | sample | 89410 | 9.021 ± 0.015 | 10.731 ± 0.020 | ms/op |
| Client.listUser:listUser·p0.00 | sample | | 1.608 | 1.884 | ms/op |
| Client.listUser:listUser·p0.50 | sample | | 9.290 | 11.026 | ms/op |
| Client.listUser:listUser·p0.90 | sample | | 9.994 | 11.698 | ms/op |
| Client.listUser:listUser·p0.95 | sample | | 10.256 | 12.091 | ms/op |
| Client.listUser:listUser·p0.99 | sample | | 11.190 | 13.271 | ms/op |
| Client.listUser:listUser·p0.999 | sample | | 15.362 | 19.189 | ms/op |
| Client.listUser:listUser·p0.9999 | sample | | 17.182 | 20.418 | ms/op |
| Client.listUser:listUser·p1.00 | sample | | 23.167 | 21.987 | ms/op |
### Disable Metrics
| Benchmark | Mode | Cnt | Score | Error | Units |
| :----: | :----: | :----: | :----: | :----: | :----: |
| Client.createUser | thrpt | 3 | 23.067 ± 2.783 | | ops/ms |
| Client.existUser | thrpt | 3 | 41.526 ± 5.468 | | ops/ms |
| Client.getUser | thrpt | 3 | 23.092 ± 4.975 | | ops/ms |
| Client.listUser | thrpt | 3 | 3.548 ± 0.077 | | ops/ms |
| Client.createUser | avgt | 3 | 1.430 ± 0.102 | | ms/op |
| Client.existUser | avgt | 3 | 0.750 ± 0.154 | | ms/op |
| Client.getUser | avgt | 3 | 1.361 ± 0.145 | | ms/op |
| Client.listUser | avgt | 3 | 8.981 ± 0.220 | | ms/op |
| Client.createUser | sample | 688350 | 1.394 ± 0.002 | | ms/op |
| Client.createUser:createUser·p0.00 | sample | | 0.600 | | ms/op |
| Client.createUser:createUser·p0.50 | sample | | 1.225 | | ms/op |
| Client.createUser:createUser·p0.90 | sample | | 2.154 | | ms/op |
| Client.createUser:createUser·p0.95 | sample | | 2.294 | | ms/op |
| Client.createUser:createUser·p0.99 | sample | | 2.707 | | ms/op |
| Client.createUser:createUser·p0.999 | sample | | 3.431 | | ms/op |
| Client.createUser:createUser·p0.9999 | sample | | 12.190 | | ms/op |
| Client.createUser:createUser·p1.00 | sample | | 14.500 | | ms/op |
| Client.existUser | sample | 1266489 | 0.758 ± 0.001 | | ms/op |
| Client.existUser:existUser·p0.00 | sample | | 0.242 | | ms/op |
| Client.existUser:existUser·p0.50 | sample | | 0.735 | | ms/op |
| Client.existUser:existUser·p0.90 | sample | | 1.002 | | ms/op |
| Client.existUser:existUser·p0.95 | sample | | 1.106 | | ms/op |
| Client.existUser:existUser·p0.99 | sample | | 1.286 | | ms/op |
| Client.existUser:existUser·p0.999 | sample | | 1.688 | | ms/op |
| Client.existUser:existUser·p0.9999 | sample | | 12.468 | | ms/op |
| Client.existUser:existUser·p1.00 | sample | | 15.221 | | ms/op |
| Client.getUser | sample | 689952 | 1.390 ± 0.001 | | ms/op |
| Client.getUser:getUser·p0.00 | sample | | 0.387 | | ms/op |
| Client.getUser:getUser·p0.50 | sample | | 1.399 | | ms/op |
| Client.getUser:getUser·p0.90 | sample | | 1.632 | | ms/op |
| Client.getUser:getUser·p0.95 | sample | | 1.737 | | ms/op |
| Client.getUser:getUser·p0.99 | sample | | 1.997 | | ms/op |
| Client.getUser:getUser·p0.999 | sample | | 2.822 | | ms/op |
| Client.getUser:getUser·p0.9999 | sample | | 16.253 | | ms/op |
| Client.getUser:getUser·p1.00 | sample | | 19.857 | | ms/op |
| Client.listUser | sample | 106368 | 9.021 ± 0.015 | | ms/op |
| Client.listUser:listUser·p0.00 | sample | | 1.608 | | ms/op |
| Client.listUser:listUser·p0.50 | sample | | 9.290 | | ms/op |
| Client.listUser:listUser·p0.90 | sample | | 9.994 | | ms/op |
| Client.listUser:listUser·p0.95 | sample | | 10.256 | | ms/op |
| Client.listUser:listUser·p0.99 | sample | | 11.190 | | ms/op |
| Client.listUser:listUser·p0.999 | sample | | 15.362 | | ms/op |
| Client.listUser:listUser·p0.9999 | sample | | 17.182 | | ms/op |
| Client.listUser:listUser·p1.00 | sample | | 23.167 | | ms/op |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9e39cbf) into [3.0](https://codecov.io/gh/apache/dubbo/commit/dfe4fcaea107ac292e6f2e967807a0756f59c7e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dfe4fca) will **increase** coverage by `0.01%`.
> The diff coverage is `72.92%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
+ Coverage 65.59% 65.61% +0.01%
- Complexity 297 355 +58
============================================
Files 1191 1211 +20
Lines 52068 52653 +585
Branches 7907 7954 +47
============================================
+ Hits 34154 34548 +394
- Misses 14231 14388 +157
- Partials 3683 3717 +34
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/dubbo/metrics/service/DefaultMetricsService.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9zZXJ2aWNlL0RlZmF1bHRNZXRyaWNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...n/java/org/apache/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvTmV0VXRpbHMuamF2YQ==) | `69.00% <33.33%> (-0.03%)` | :arrow_down: |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `38.46% <38.46%> (ø)` | |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `50.00% <50.00%> (ø)` | |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `82.52% <50.00%> (+0.26%)` | :arrow_up: |
| [...pache/dubbo/common/metrics/event/MetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9NZXRyaWNzRXZlbnQuamF2YQ==) | `57.14% <57.14%> (ø)` | |
| [...common/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `58.33% <58.33%> (ø)` | |
| [.../apache/dubbo/metrics/AbstractMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9BYnN0cmFjdE1ldHJpY3NSZXBvcnRlci5qYXZh) | `61.29% <61.29%> (ø)` | |
| ... and [38 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dfe4fca...9e39cbf](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (18160d3) into [3.0](https://codecov.io/gh/apache/dubbo/commit/954c715366931dd81cf66592700f6f54b1cbbe09?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (954c715) will **decrease** coverage by `0.11%`.
> The diff coverage is `72.92%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
- Coverage 65.34% 65.23% -0.12%
- Complexity 341 399 +58
============================================
Files 1202 1222 +20
Lines 51844 52429 +585
Branches 7727 7773 +46
============================================
+ Hits 33879 34203 +324
- Misses 14351 14579 +228
- Partials 3614 3647 +33
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/dubbo/metrics/service/DefaultMetricsService.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9zZXJ2aWNlL0RlZmF1bHRNZXRyaWNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...n/java/org/apache/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvTmV0VXRpbHMuamF2YQ==) | `68.05% <33.33%> (-0.99%)` | :arrow_down: |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `38.46% <38.46%> (ø)` | |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `50.00% <50.00%> (ø)` | |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `82.58% <50.00%> (+0.26%)` | :arrow_up: |
| [...pache/dubbo/common/metrics/event/MetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9NZXRyaWNzRXZlbnQuamF2YQ==) | `57.14% <57.14%> (ø)` | |
| [...common/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `58.33% <58.33%> (ø)` | |
| [.../apache/dubbo/metrics/AbstractMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9BYnN0cmFjdE1ldHJpY3NSZXBvcnRlci5qYXZh) | `61.29% <61.29%> (ø)` | |
| ... and [35 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [954c715...18160d3](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (44ef2f6) into [3.0](https://codecov.io/gh/apache/dubbo/commit/954c715366931dd81cf66592700f6f54b1cbbe09?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (954c715) will **decrease** coverage by `0.17%`.
> The diff coverage is `72.75%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
- Coverage 65.38% 65.21% -0.18%
- Complexity 342 406 +64
============================================
Files 1202 1222 +20
Lines 51844 52544 +700
Branches 7727 7788 +61
============================================
+ Hits 33898 34264 +366
- Misses 14334 14615 +281
- Partials 3612 3665 +53
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `82.58% <0.00%> (+0.26%)` | :arrow_up: |
| [...e/dubbo/metrics/service/DefaultMetricsService.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9zZXJ2aWNlL0RlZmF1bHRNZXRyaWNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...n/java/org/apache/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvTmV0VXRpbHMuamF2YQ==) | `68.05% <33.33%> (-0.99%)` | :arrow_down: |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `38.46% <38.46%> (ø)` | |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `50.00% <50.00%> (ø)` | |
| [...pache/dubbo/common/metrics/event/MetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9NZXRyaWNzRXZlbnQuamF2YQ==) | `57.14% <57.14%> (ø)` | |
| [...common/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `58.33% <58.33%> (ø)` | |
| [.../apache/dubbo/metrics/AbstractMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9BYnN0cmFjdE1ldHJpY3NSZXBvcnRlci5qYXZh) | `61.29% <61.29%> (ø)` | |
| ... and [69 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [954c715...44ef2f6](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r771084099
##########
File path: dubbo-metrics/dubbo-metrics-prometheus/README.md
##########
@@ -0,0 +1,133 @@
+# Prometheus Metrics Reporter
+
+This is about how to use Prometheus to collector metrics from Apache Dubbo.
+
+## Usage
+
+As far as we know, Prometheus support both pull and push mode to collector metrics, Dubbo provided both way to let you
+choose which one you prefer.
+
+### Pull Mode
+
+For pull mode, you can add this config to your code.
+
+```java
+@Configuration
+public class DubboConfiguration {
+ @Bean
+ public MetricsConfig metricsConfig() {
+ MetricsConfig metricsConfig = new MetricsConfig();
+ metricsConfig.setProtocol(MetricsConstants.PROTOCOL_PROMETHEUS);
+
+ // collect jvm metrics
+ metricsConfig.setEnableJvmMetrics(true);
+
+ // add this config if you want to aggregate metrics in local machine.
+ // or you can aggregate by PromQL
+ AggregationConfig aggregationConfig = new AggregationConfig();
+ aggregationConfig.setEnabled(true);
+ aggregationConfig.setTimeWindowSeconds(120);
+ aggregationConfig.setBucketNum(5);
+ metricsConfig.setAggregation(aggregationConfig);
+
+ PrometheusConfig prometheusConfig = new PrometheusConfig();
+ PrometheusConfig.Exporter exporter = new PrometheusConfig.Exporter();
+ // this must be true if you are using exporter.
+ exporter.setEnabled(true);
+
+ // this will expose a httpserver to public, and the metrics url is http://localhost:20888/metrics.
+ exporter.setMetricsPath("/metrics");
+ exporter.setMetricsPort(20888);
+
+ prometheusConfig.setExporter(exporter);
+ metricsConfig.setPrometheus(prometheusConfig);
+
+ return metricsConfig;
+ }
+}
+```
+
+Or if you prefer xml config.
+
+```xml
+<dubbo:metrics protocol="prometheus" enable-jvm-metrics="true">
+ <dubbo:aggregation enabled="true" bucket-num="5" time-window-seconds="120" />
+ <dubbo:prometheus-exporter enabled="true" metrics-port="20888" metrics-path="/metrics" />
+</dubbo:metrics>
+```
+
+After set, add scrape config to your Prometheus config file like this.
+
+```yaml
+scrape_configs:
+ - job_name: 'dubbo'
+ scrape_interval: 15s
+ metrics_path: '/metrics'
+ static_configs:
+ - targets: [ "localhost:20888" ]
+```
+
+### Push Mode
+
+For pull mode, you can add this config to your code.
+
+```java
+@Configuration
+public class DubboConfiguration {
+ @Bean
+ public MetricsConfig metricsConfig() {
+ MetricsConfig metricsConfig = new MetricsConfig();
+ metricsConfig.setProtocol(MetricsConstants.PROTOCOL_PROMETHEUS);
+
+ // collect jvm metrics
+ metricsConfig.setEnableJvmMetrics(true);
+
+ // add this config if you want to aggregate metrics in local machine.
+ // or you can aggregate by PromQL
+ AggregationConfig aggregationConfig = new AggregationConfig();
+ aggregationConfig.setEnabled(true);
+ aggregationConfig.setTimeWindowSeconds(120);
+ aggregationConfig.setBucketNum(5);
+ metricsConfig.setAggregation(aggregationConfig);
+
+ PrometheusConfig prometheusConfig = new PrometheusConfig();
+ PrometheusConfig.Pushgateway pushgateway = new PrometheusConfig.Pushgateway();
+ // this must be true if you are using pushgateway.
+ pushgateway.setEnabled(true);
+ // your prometheus push gateway address
+ pushgateway.setBaseUrl("localhost:9091");
+ // job name display in prometheus
+ pushgateway.setJob("job");
+ // your credential
+ pushgateway.setUsername("username");
+ pushgateway.setPassword("password");
+ // push interval, this means push metrics to pushgateway every 15 seconds
+ pushgateway.setPushInterval(15);
+
+ prometheusConfig.setPushgateway(pushgateway);
+ metricsConfig.setPrometheus(prometheusConfig);
+
+ return metricsConfig;
+ }
+}
+```
+
+Or if you prefer xml config.
+
+```xml
+<dubbo:metrics protocol="prometheus" enable-jvm-metrics="true">
+ <dubbo:aggregation enabled="true" bucket-num="5" time-window-seconds="120" />
+ <dubbo:prometheus-pushgateway enabled="true" base-url="localhost:9091" push-interval="30" username="username" password="password" job="job" />
+</dubbo:metrics>
+```
Review comment:
Pls add properties or yaml config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r762410955
##########
File path: dubbo-common/src/main/java/org/apache/dubbo/common/metrics/collector/DefaultMetricsCollector.java
##########
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.common.metrics.collector;
+
+import org.apache.dubbo.common.metrics.event.BaseMetricsEvent;
+import org.apache.dubbo.common.metrics.event.NewRTEvent;
+import org.apache.dubbo.common.metrics.event.NewRequestEvent;
+import org.apache.dubbo.common.metrics.listener.MetricsListener;
+import org.apache.dubbo.common.metrics.model.MethodMetric;
+import org.apache.dubbo.common.metrics.model.sample.GaugeMetricSample;
+import org.apache.dubbo.common.metrics.model.sample.MetricSample;
+import org.apache.dubbo.rpc.model.ApplicationModel;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicLong;
+
+import static org.apache.dubbo.common.metrics.model.MetricsCategory.REQUESTS;
+import static org.apache.dubbo.common.metrics.model.MetricsCategory.RT;
+
+/**
+ * Default implementation of {@link MetricsCollector}
+ */
+public class DefaultMetricsCollector implements MetricsCollector {
+
+ private Boolean collectEnabled = false;
+ private final List<MetricsListener> listeners = new ArrayList<>();
+ private final ApplicationModel applicationModel;
+ private final String applicationName;
+
+ private final Map<MethodMetric, AtomicLong> totalRequests = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> succeedRequests = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> failedRequests = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> processingRequests = new HashMap<>();
+
+ private final Map<MethodMetric, AtomicLong> lastRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> minRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> maxRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> avgRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> totalRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> rtCount = new HashMap<>();
+
Review comment:
The concurrent write operation of HashMap is unsafe, it's better change to `ConcurrentHashMap`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r762409208
##########
File path: dubbo-metrics/dubbo-metrics-prometheus/src/main/java/org/apache/dubbo/metrics/prometheus/PrometheusMetricsReporter.java
##########
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.metrics.prometheus;
+
+import org.apache.dubbo.common.URL;
+import org.apache.dubbo.common.logger.Logger;
+import org.apache.dubbo.common.logger.LoggerFactory;
+import org.apache.dubbo.common.utils.NamedThreadFactory;
+import org.apache.dubbo.common.utils.StringUtils;
+import org.apache.dubbo.metrics.AbstractMetricsReporter;
+import org.apache.dubbo.rpc.model.ApplicationModel;
+
+import com.sun.net.httpserver.HttpServer;
+import io.micrometer.prometheus.PrometheusConfig;
+import io.micrometer.prometheus.PrometheusMeterRegistry;
+import io.prometheus.client.exporter.BasicAuthHttpConnectionFactory;
+import io.prometheus.client.exporter.PushGateway;
+
+import java.io.IOException;
+import java.io.OutputStream;
+import java.net.InetSocketAddress;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_DEFAULT_JOB_NAME;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_DEFAULT_METRICS_PATH;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_DEFAULT_METRICS_PORT;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_DEFAULT_PUSH_INTERVAL;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_EXPORTER_ENABLED_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_EXPORTER_METRICS_PATH_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_EXPORTER_METRICS_PORT_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_PUSHGATEWAY_BASE_URL_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_PUSHGATEWAY_ENABLED_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_PUSHGATEWAY_JOB_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_PUSHGATEWAY_PASSWORD_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_PUSHGATEWAY_PUSH_INTERVAL_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_PUSHGATEWAY_USERNAME_KEY;
+
+/**
+ * Metrics reporter for prometheus.
+ */
+public class PrometheusMetricsReporter extends AbstractMetricsReporter {
+
+ private final Logger logger = LoggerFactory.getLogger(PrometheusMetricsReporter.class);
+
+ private final PrometheusMeterRegistry prometheusRegistry = new PrometheusMeterRegistry(PrometheusConfig.DEFAULT);
+ private ScheduledExecutorService pushJobExecutor = null;
+ private HttpServer prometheusExporterHttpServer = null;
+
+ public PrometheusMetricsReporter(URL url, ApplicationModel applicationModel) {
+ super(url, applicationModel);
+ }
+
+ @Override
+ public void doInit() {
+ addMeterRegistry(prometheusRegistry);
+ exportHttpServer();
+ schedulePushJob();
+ }
+
+ private void exportHttpServer() {
+ boolean exporterEnabled = url.getParameter(PROMETHEUS_EXPORTER_ENABLED_KEY, false);
+ if (exporterEnabled) {
+ int port = url.getParameter(PROMETHEUS_EXPORTER_METRICS_PORT_KEY, PROMETHEUS_DEFAULT_METRICS_PORT);
+ String path = url.getParameter(PROMETHEUS_EXPORTER_METRICS_PATH_KEY, PROMETHEUS_DEFAULT_METRICS_PATH);
+ if (!path.startsWith("/")) {
+ path = "/" + path;
+ }
+
+ try {
+ prometheusExporterHttpServer = HttpServer.create(new InetSocketAddress(port), 0);
+ prometheusExporterHttpServer.createContext(path, httpExchange -> {
+ String response = prometheusRegistry.scrape();
+ httpExchange.sendResponseHeaders(200, response.getBytes().length);
+ try (OutputStream os = httpExchange.getResponseBody()) {
+ os.write(response.getBytes());
+ }
+ });
+
+ new Thread(prometheusExporterHttpServer::start).start();
Review comment:
The thread of Http server is out of managed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r762410955
##########
File path: dubbo-common/src/main/java/org/apache/dubbo/common/metrics/collector/DefaultMetricsCollector.java
##########
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.common.metrics.collector;
+
+import org.apache.dubbo.common.metrics.event.BaseMetricsEvent;
+import org.apache.dubbo.common.metrics.event.NewRTEvent;
+import org.apache.dubbo.common.metrics.event.NewRequestEvent;
+import org.apache.dubbo.common.metrics.listener.MetricsListener;
+import org.apache.dubbo.common.metrics.model.MethodMetric;
+import org.apache.dubbo.common.metrics.model.sample.GaugeMetricSample;
+import org.apache.dubbo.common.metrics.model.sample.MetricSample;
+import org.apache.dubbo.rpc.model.ApplicationModel;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicLong;
+
+import static org.apache.dubbo.common.metrics.model.MetricsCategory.REQUESTS;
+import static org.apache.dubbo.common.metrics.model.MetricsCategory.RT;
+
+/**
+ * Default implementation of {@link MetricsCollector}
+ */
+public class DefaultMetricsCollector implements MetricsCollector {
+
+ private Boolean collectEnabled = false;
+ private final List<MetricsListener> listeners = new ArrayList<>();
+ private final ApplicationModel applicationModel;
+ private final String applicationName;
+
+ private final Map<MethodMetric, AtomicLong> totalRequests = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> succeedRequests = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> failedRequests = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> processingRequests = new HashMap<>();
+
+ private final Map<MethodMetric, AtomicLong> lastRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> minRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> maxRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> avgRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> totalRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> rtCount = new HashMap<>();
+
Review comment:
The HashMap concurrent write operation are unsafe, it's better change to `ConcurrentHashMap`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r762412985
##########
File path: dubbo-common/src/test/java/org/apache/dubbo/common/metrics/collector/DefaultMetricsCollectorTest.java
##########
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.common.metrics.collector;
+
+import org.apache.dubbo.common.metrics.event.BaseMetricsEvent;
+import org.apache.dubbo.common.metrics.event.NewRTEvent;
+import org.apache.dubbo.common.metrics.event.NewRequestEvent;
+import org.apache.dubbo.common.metrics.listener.MetricsListener;
+import org.apache.dubbo.common.metrics.model.sample.GaugeMetricSample;
+import org.apache.dubbo.common.metrics.model.sample.MetricSample;
+import org.apache.dubbo.rpc.model.ApplicationModel;
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.Test;
+
+import java.util.List;
+import java.util.Map;
+import java.util.function.Supplier;
+import java.util.stream.Collectors;
+
+import static org.apache.dubbo.common.constants.MetricsConstants.TAG_GROUP_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.TAG_INTERFACE_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.TAG_METHOD_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.TAG_PARAMETER_TYPES_DESC;
+import static org.apache.dubbo.common.constants.MetricsConstants.TAG_VERSION_KEY;
+
+public class DefaultMetricsCollectorTest {
Review comment:
Please add a performance test with multiple threads for metris collecting and query
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r762408885
##########
File path: dubbo-metrics/dubbo-metrics-prometheus/src/main/java/org/apache/dubbo/metrics/prometheus/PrometheusMetricsReporter.java
##########
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.metrics.prometheus;
+
+import org.apache.dubbo.common.URL;
+import org.apache.dubbo.common.logger.Logger;
+import org.apache.dubbo.common.logger.LoggerFactory;
+import org.apache.dubbo.common.utils.NamedThreadFactory;
+import org.apache.dubbo.common.utils.StringUtils;
+import org.apache.dubbo.metrics.AbstractMetricsReporter;
+import org.apache.dubbo.rpc.model.ApplicationModel;
+
+import com.sun.net.httpserver.HttpServer;
+import io.micrometer.prometheus.PrometheusConfig;
+import io.micrometer.prometheus.PrometheusMeterRegistry;
+import io.prometheus.client.exporter.BasicAuthHttpConnectionFactory;
+import io.prometheus.client.exporter.PushGateway;
+
+import java.io.IOException;
+import java.io.OutputStream;
+import java.net.InetSocketAddress;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_DEFAULT_JOB_NAME;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_DEFAULT_METRICS_PATH;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_DEFAULT_METRICS_PORT;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_DEFAULT_PUSH_INTERVAL;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_EXPORTER_ENABLED_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_EXPORTER_METRICS_PATH_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_EXPORTER_METRICS_PORT_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_PUSHGATEWAY_BASE_URL_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_PUSHGATEWAY_ENABLED_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_PUSHGATEWAY_JOB_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_PUSHGATEWAY_PASSWORD_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_PUSHGATEWAY_PUSH_INTERVAL_KEY;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROMETHEUS_PUSHGATEWAY_USERNAME_KEY;
+
+/**
+ * Metrics reporter for prometheus.
+ */
+public class PrometheusMetricsReporter extends AbstractMetricsReporter {
+
+ private final Logger logger = LoggerFactory.getLogger(PrometheusMetricsReporter.class);
+
+ private final PrometheusMeterRegistry prometheusRegistry = new PrometheusMeterRegistry(PrometheusConfig.DEFAULT);
+ private ScheduledExecutorService pushJobExecutor = null;
+ private HttpServer prometheusExporterHttpServer = null;
+
+ public PrometheusMetricsReporter(URL url, ApplicationModel applicationModel) {
+ super(url, applicationModel);
+ }
+
+ @Override
+ public void doInit() {
+ addMeterRegistry(prometheusRegistry);
+ exportHttpServer();
+ schedulePushJob();
+ }
+
+ private void exportHttpServer() {
+ boolean exporterEnabled = url.getParameter(PROMETHEUS_EXPORTER_ENABLED_KEY, false);
+ if (exporterEnabled) {
+ int port = url.getParameter(PROMETHEUS_EXPORTER_METRICS_PORT_KEY, PROMETHEUS_DEFAULT_METRICS_PORT);
+ String path = url.getParameter(PROMETHEUS_EXPORTER_METRICS_PATH_KEY, PROMETHEUS_DEFAULT_METRICS_PATH);
+ if (!path.startsWith("/")) {
+ path = "/" + path;
+ }
+
+ try {
+ prometheusExporterHttpServer = HttpServer.create(new InetSocketAddress(port), 0);
+ prometheusExporterHttpServer.createContext(path, httpExchange -> {
+ String response = prometheusRegistry.scrape();
+ httpExchange.sendResponseHeaders(200, response.getBytes().length);
+ try (OutputStream os = httpExchange.getResponseBody()) {
+ os.write(response.getBytes());
+ }
+ });
+
+ new Thread(prometheusExporterHttpServer::start).start();
+ } catch (IOException e) {
+ throw new RuntimeException(e);
+ }
+ }
+ }
+
+ private void schedulePushJob() {
+ boolean pushEnabled = url.getParameter(PROMETHEUS_PUSHGATEWAY_ENABLED_KEY, false);
+ if (pushEnabled) {
+ String baseUrl = url.getParameter(PROMETHEUS_PUSHGATEWAY_BASE_URL_KEY);
+ String job = url.getParameter(PROMETHEUS_PUSHGATEWAY_JOB_KEY, PROMETHEUS_DEFAULT_JOB_NAME);
+ int pushInterval = url.getParameter(PROMETHEUS_PUSHGATEWAY_PUSH_INTERVAL_KEY, PROMETHEUS_DEFAULT_PUSH_INTERVAL);
+ String username = url.getParameter(PROMETHEUS_PUSHGATEWAY_USERNAME_KEY);
+ String password = url.getParameter(PROMETHEUS_PUSHGATEWAY_PASSWORD_KEY);
+
+ NamedThreadFactory threadFactory = new NamedThreadFactory("prometheus-push-job", true);
+ pushJobExecutor = Executors.newScheduledThreadPool(1, threadFactory);
+ PushGateway pushGateway = new PushGateway(baseUrl);
+ if (!StringUtils.isBlank(username)) {
+ pushGateway.setConnectionFactory(new BasicAuthHttpConnectionFactory(username, password));
+ }
+
+ pushJobExecutor.scheduleAtFixedRate(() -> push(pushGateway, job), pushInterval, pushInterval, TimeUnit.SECONDS);
Review comment:
It's better to schedule with scheduleWithFixedDelay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [WIP][3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (def4009) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **decrease** coverage by `0.56%`.
> The diff coverage is `16.14%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
- Coverage 64.70% 64.14% -0.57%
- Complexity 327 328 +1
============================================
Files 1206 1226 +20
Lines 51844 52414 +570
Branches 7716 7765 +49
============================================
+ Hits 33546 33621 +75
- Misses 14684 15172 +488
- Partials 3614 3621 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/event/BaseMetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9CYXNlTWV0cmljc0V2ZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../apache/dubbo/common/metrics/event/NewRTEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9OZXdSVEV2ZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...he/dubbo/common/metrics/event/NewRequestEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9OZXdSZXF1ZXN0RXZlbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...he/dubbo/common/metrics/model/InterfaceMetric.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9JbnRlcmZhY2VNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...pache/dubbo/common/metrics/model/MethodMetric.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9NZXRob2RNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...common/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [30 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...def4009](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-986008204
Should we add a integration test with Prometheus? What about adding a sample to `dubbo-samples` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r762409624
##########
File path: dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/metrics/DefaultMetricsServiceExporter.java
##########
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.config.metrics;
+
+import org.apache.dubbo.common.extension.ExtensionLoader;
+import org.apache.dubbo.common.logger.Logger;
+import org.apache.dubbo.common.logger.LoggerFactory;
+import org.apache.dubbo.common.metrics.service.MetricsService;
+import org.apache.dubbo.common.metrics.service.MetricsServiceExporter;
+import org.apache.dubbo.common.utils.CollectionUtils;
+import org.apache.dubbo.config.ApplicationConfig;
+import org.apache.dubbo.config.MetricsConfig;
+import org.apache.dubbo.config.ProtocolConfig;
+import org.apache.dubbo.config.RegistryConfig;
+import org.apache.dubbo.config.ServiceConfig;
+import org.apache.dubbo.rpc.model.ApplicationModel;
+import org.apache.dubbo.rpc.model.ScopeModelAware;
+
+import java.util.List;
+
+import static org.apache.dubbo.common.constants.CommonConstants.DUBBO_PROTOCOL;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROTOCOL_PROMETHEUS;
+
+/**
+ * Default implementation of {@link MetricsServiceExporter}
+ */
+public class DefaultMetricsServiceExporter implements MetricsServiceExporter, ScopeModelAware {
+
+ private final Logger logger = LoggerFactory.getLogger(getClass());
+
+ private ApplicationModel applicationModel;
+ private MetricsService metricsService;
+ private volatile ServiceConfig<MetricsService> serviceConfig;
+
+ public DefaultMetricsServiceExporter() {
+ }
+
+ @Override
+ public void init() {
+ initialize();
+ }
+
+ private void initialize() {
+ MetricsConfig metricsConfig = applicationModel.getApplicationConfigManager().getMetrics().orElse(null);
+ // TODO compatible with old usage of metrics, remove protocol check after new metrics is ready for use.
+ if (metricsConfig != null && PROTOCOL_PROMETHEUS.equals(metricsConfig.getProtocol())) {
+ ExtensionLoader<MetricsService> extensionLoader = applicationModel.getExtensionLoader(MetricsService.class);
+ if (!extensionLoader.hasExtension(MetricsService.DEFAULT_EXTENSION_NAME)) {
+ throw new IllegalStateException("Metrics config exist, but the dubbo-metrics-api dependency is missing. Please check your project dependencies.");
+ } else {
+ this.metricsService = extensionLoader.getDefaultExtension();
+ }
+ }
Review comment:
Print warnning message if it's unsupported protocol of metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r762401444
##########
File path: dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/metrics/DefaultMetricsServiceExporter.java
##########
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.config.metrics;
+
+import org.apache.dubbo.common.extension.ExtensionLoader;
+import org.apache.dubbo.common.logger.Logger;
+import org.apache.dubbo.common.logger.LoggerFactory;
+import org.apache.dubbo.common.metrics.service.MetricsService;
+import org.apache.dubbo.common.metrics.service.MetricsServiceExporter;
+import org.apache.dubbo.common.utils.CollectionUtils;
+import org.apache.dubbo.config.ApplicationConfig;
+import org.apache.dubbo.config.MetricsConfig;
+import org.apache.dubbo.config.ProtocolConfig;
+import org.apache.dubbo.config.RegistryConfig;
+import org.apache.dubbo.config.ServiceConfig;
+import org.apache.dubbo.rpc.model.ApplicationModel;
+import org.apache.dubbo.rpc.model.ScopeModelAware;
+
+import java.util.List;
+
+import static org.apache.dubbo.common.constants.CommonConstants.DUBBO_PROTOCOL;
+import static org.apache.dubbo.common.constants.MetricsConstants.PROTOCOL_PROMETHEUS;
+
+/**
+ * Default implementation of {@link MetricsServiceExporter}
+ */
+public class DefaultMetricsServiceExporter implements MetricsServiceExporter, ScopeModelAware {
+
+ private final Logger logger = LoggerFactory.getLogger(getClass());
+
+ private ApplicationModel applicationModel;
+ private MetricsService metricsService;
+ private volatile ServiceConfig<MetricsService> serviceConfig;
+
+ public DefaultMetricsServiceExporter() {
+ }
+
+ @Override
+ public void init() {
+ initialize();
+ }
+
+ private void initialize() {
+ MetricsConfig metricsConfig = applicationModel.getApplicationConfigManager().getMetrics().orElse(null);
+ // TODO compatible with old usage of metrics, remove protocol check after new metrics is ready for use.
+ if (metricsConfig != null && PROTOCOL_PROMETHEUS.equals(metricsConfig.getProtocol())) {
+ ExtensionLoader<MetricsService> extensionLoader = applicationModel.getExtensionLoader(MetricsService.class);
+ if (!extensionLoader.hasExtension(MetricsService.DEFAULT_EXTENSION_NAME)) {
+ throw new IllegalStateException("Metrics config exist, but the dubbo-metrics-api dependency is missing. Please check your project dependencies.");
+ } else {
+ this.metricsService = extensionLoader.getDefaultExtension();
+ }
+ }
+ }
+
+ @Override
+ public void setApplicationModel(ApplicationModel applicationModel) {
+ this.applicationModel = applicationModel;
+ }
+
+ @Override
+ public MetricsServiceExporter export() {
+ if (metricsService != null) {
+ if (!isExported()) {
+ ApplicationConfig applicationConfig = getApplicationConfig();
+ ServiceConfig<MetricsService> serviceConfig = new ServiceConfig<>();
+ serviceConfig.setScopeModel(applicationModel.getInternalModule());
+ serviceConfig.setApplication(applicationConfig);
+ serviceConfig.setRegistry(new RegistryConfig("N/A"));
+ serviceConfig.setProtocol(generateMetricsProtocol());
+ serviceConfig.setInterface(MetricsService.class);
+ serviceConfig.setDelay(0);
+ serviceConfig.setRef(metricsService);
+ serviceConfig.setGroup(applicationConfig.getName());
+ serviceConfig.setVersion(MetricsService.VERSION);
+
+ // export
+ serviceConfig.export();
Review comment:
It's better to add the service config of `MetricsService` to internal module instead of export it directly.
```java
applicationModel.getInternalModule().getConfigManager().addService(serviceConfig);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r762411552
##########
File path: dubbo-common/src/main/java/org/apache/dubbo/common/metrics/collector/DefaultMetricsCollector.java
##########
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.common.metrics.collector;
+
+import org.apache.dubbo.common.metrics.event.BaseMetricsEvent;
+import org.apache.dubbo.common.metrics.event.NewRTEvent;
+import org.apache.dubbo.common.metrics.event.NewRequestEvent;
+import org.apache.dubbo.common.metrics.listener.MetricsListener;
+import org.apache.dubbo.common.metrics.model.MethodMetric;
+import org.apache.dubbo.common.metrics.model.sample.GaugeMetricSample;
+import org.apache.dubbo.common.metrics.model.sample.MetricSample;
+import org.apache.dubbo.rpc.model.ApplicationModel;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicLong;
+
+import static org.apache.dubbo.common.metrics.model.MetricsCategory.REQUESTS;
+import static org.apache.dubbo.common.metrics.model.MetricsCategory.RT;
+
+/**
+ * Default implementation of {@link MetricsCollector}
+ */
+public class DefaultMetricsCollector implements MetricsCollector {
+
+ private Boolean collectEnabled = false;
+ private final List<MetricsListener> listeners = new ArrayList<>();
+ private final ApplicationModel applicationModel;
+ private final String applicationName;
+
+ private final Map<MethodMetric, AtomicLong> totalRequests = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> succeedRequests = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> failedRequests = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> processingRequests = new HashMap<>();
+
+ private final Map<MethodMetric, AtomicLong> lastRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> minRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> maxRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> avgRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> totalRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> rtCount = new HashMap<>();
+
+ public DefaultMetricsCollector(ApplicationModel applicationModel) {
+ this.applicationModel = applicationModel;
+ this.applicationName = applicationModel.tryGetApplicationName();
+ }
+
+ public void setCollectEnabled(Boolean collectEnabled) {
+ this.collectEnabled = collectEnabled;
+ }
+
+ public Boolean isCollectEnabled() {
+ return collectEnabled;
+ }
+
+ public void addListener(MetricsListener listener) {
+ listeners.add(listener);
+ }
+
+ public void increaseTotalRequests(String interfaceName, String methodName, String parameterTypesDesc, String group, String version) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+ AtomicLong count = totalRequests.computeIfAbsent(metric, k -> new AtomicLong(0L));
+ count.incrementAndGet();
+
+ publishEvent(new NewRequestEvent(metric, NewRequestEvent.Type.TOTAL));
+ }
+ }
+
+ public void increaseSucceedRequests(String interfaceName, String methodName, String parameterTypesDesc, String group, String version) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+ AtomicLong count = succeedRequests.computeIfAbsent(metric, k -> new AtomicLong(0L));
+ count.incrementAndGet();
+
+ publishEvent(new NewRequestEvent(metric, NewRequestEvent.Type.SUCCEED));
+ }
+ }
+
+ public void increaseFailedRequests(String interfaceName, String methodName, String parameterTypesDesc, String group, String version) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+ AtomicLong count = failedRequests.computeIfAbsent(metric, k -> new AtomicLong(0L));
+ count.incrementAndGet();
+
+ publishEvent(new NewRequestEvent(metric, NewRequestEvent.Type.FAILED));
+ }
+ }
+
+ public void increaseProcessingRequests(String interfaceName, String methodName, String parameterTypesDesc, String group, String version) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+ AtomicLong count = processingRequests.computeIfAbsent(metric, k -> new AtomicLong(0L));
+ count.incrementAndGet();
+ }
+ }
+
+ public void decreaseProcessingRequests(String interfaceName, String methodName, String parameterTypesDesc, String group, String version) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+ AtomicLong count = processingRequests.computeIfAbsent(metric, k -> new AtomicLong(0L));
+ count.decrementAndGet();
+ }
+ }
+
+ public void addRT(String interfaceName, String methodName, String parameterTypesDesc, String group, String version, Long responseTime) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+
+ AtomicLong last = lastRT.computeIfAbsent(metric, k -> new AtomicLong());
+ last.set(responseTime);
+
+ AtomicLong min = minRT.computeIfAbsent(metric, k -> new AtomicLong(Long.MAX_VALUE));
+ if (responseTime < min.longValue()) {
+ min.set(responseTime);
+ }
Review comment:
This kind of compare and set is unsafe when execute concurrently. See about:
```java
LongAccumulator maxId = new LongAccumulator(Long::max, 0); //replace 0 with desired initial value
maxId.accumulate(newValue); //from each thread
```
pick from: https://stackoverflow.com/a/49027525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r762410757
##########
File path: dubbo-common/src/main/java/org/apache/dubbo/common/metrics/event/BaseMetricsEvent.java
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.common.metrics.event;
+
+/**
+ * BaseMetricsEvent.
+ */
+public class BaseMetricsEvent {
Review comment:
The `BaseMetricsEvent` can rename to `MetricsEvent`, and make it as abstract class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fe9009c) into [3.0](https://codecov.io/gh/apache/dubbo/commit/954c715366931dd81cf66592700f6f54b1cbbe09?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (954c715) will **decrease** coverage by `0.21%`.
> The diff coverage is `72.75%`.
> :exclamation: Current head fe9009c differs from pull request most recent head 44ef2f6. Consider uploading reports for the commit 44ef2f6 to get more accurate results
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
- Coverage 65.38% 65.17% -0.22%
- Complexity 342 407 +65
============================================
Files 1202 1222 +20
Lines 51844 52485 +641
Branches 7727 7733 +6
============================================
+ Hits 33898 34205 +307
- Misses 14334 14612 +278
- Partials 3612 3668 +56
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `82.58% <0.00%> (+0.26%)` | :arrow_up: |
| [...e/dubbo/metrics/service/DefaultMetricsService.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9zZXJ2aWNlL0RlZmF1bHRNZXRyaWNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...n/java/org/apache/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvTmV0VXRpbHMuamF2YQ==) | `67.94% <33.33%> (-1.09%)` | :arrow_down: |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `38.46% <38.46%> (ø)` | |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `50.00% <50.00%> (ø)` | |
| [...pache/dubbo/common/metrics/event/MetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9NZXRyaWNzRXZlbnQuamF2YQ==) | `57.14% <57.14%> (ø)` | |
| [...common/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `58.33% <58.33%> (ø)` | |
| [.../apache/dubbo/metrics/AbstractMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9BYnN0cmFjdE1ldHJpY3NSZXBvcnRlci5qYXZh) | `61.29% <61.29%> (ø)` | |
| ... and [98 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [954c715...44ef2f6](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (afb2cf3) into [3.0](https://codecov.io/gh/apache/dubbo/commit/954c715366931dd81cf66592700f6f54b1cbbe09?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (954c715) will **decrease** coverage by `0.23%`.
> The diff coverage is `72.75%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
- Coverage 65.38% 65.15% -0.24%
- Complexity 342 407 +65
============================================
Files 1202 1222 +20
Lines 51844 52473 +629
Branches 7727 7734 +7
============================================
+ Hits 33898 34187 +289
- Misses 14334 14620 +286
- Partials 3612 3666 +54
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `82.52% <0.00%> (+0.20%)` | :arrow_up: |
| [...e/dubbo/metrics/service/DefaultMetricsService.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9zZXJ2aWNlL0RlZmF1bHRNZXRyaWNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...n/java/org/apache/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvTmV0VXRpbHMuamF2YQ==) | `67.94% <33.33%> (-1.09%)` | :arrow_down: |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `38.46% <38.46%> (ø)` | |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `50.00% <50.00%> (ø)` | |
| [...pache/dubbo/common/metrics/event/MetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9NZXRyaWNzRXZlbnQuamF2YQ==) | `57.14% <57.14%> (ø)` | |
| [...common/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `58.33% <58.33%> (ø)` | |
| [.../apache/dubbo/metrics/AbstractMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9BYnN0cmFjdE1ldHJpY3NSZXBvcnRlci5qYXZh) | `61.29% <61.29%> (ø)` | |
| ... and [114 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [954c715...afb2cf3](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r771085938
##########
File path: dubbo-metrics/dubbo-metrics-prometheus/src/main/java/org/apache/dubbo/metrics/prometheus/PrometheusMetricsReporter.java
##########
@@ -93,7 +94,8 @@ private void exportHttpServer() {
}
});
- new Thread(prometheusExporterHttpServer::start).start();
+ httpServerThread = new Thread(prometheusExporterHttpServer::start);
+ httpServerThread.start();
Review comment:
The http server management seems a bit strange, see about: https://stackoverflow.com/a/2917297
Use executor service seems better.
```java
this.httpServer = HttpServer.create(addr, 0);
HttpContext context = this.httpServer.createContext("/", new DocumentProcessHandler());
this.httpThreadPool = Executors.newFixedThreadPool(this.noOfThreads);
this.httpServer.setExecutor(this.httpThreadPool);
this.httpServer.start();
```
```java
this.httpServer.stop(1);
this.httpThreadPool.shutdownNow();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [WIP][3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (def4009) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **decrease** coverage by `0.53%`.
> The diff coverage is `16.14%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
- Coverage 64.70% 64.16% -0.54%
- Complexity 327 328 +1
============================================
Files 1206 1226 +20
Lines 51844 52414 +570
Branches 7716 7765 +49
============================================
+ Hits 33546 33633 +87
- Misses 14684 15161 +477
- Partials 3614 3620 +6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/event/BaseMetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9CYXNlTWV0cmljc0V2ZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../apache/dubbo/common/metrics/event/NewRTEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9OZXdSVEV2ZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...he/dubbo/common/metrics/event/NewRequestEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9OZXdSZXF1ZXN0RXZlbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...he/dubbo/common/metrics/model/InterfaceMetric.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9JbnRlcmZhY2VNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...pache/dubbo/common/metrics/model/MethodMetric.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9NZXRob2RNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...common/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [29 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...def4009](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r762401070
##########
File path: dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/deploy/DefaultApplicationDeployer.java
##########
@@ -306,6 +318,26 @@ private void startMetadataCenter() {
}
}
+ private void initMetricsService() {
+ this.metricsServiceExporter = getExtensionLoader(MetricsServiceExporter.class).getDefaultExtension();
Review comment:
The `MetricsServiceExporter` should convert to a scoped bean but not a SPI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kevinw66 commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kevinw66 commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r763693532
##########
File path: dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/AbstractMetricsReporter.java
##########
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.metrics;
+
+import org.apache.dubbo.common.URL;
+import org.apache.dubbo.common.lang.ShutdownHookCallbacks;
+import org.apache.dubbo.common.logger.Logger;
+import org.apache.dubbo.common.logger.LoggerFactory;
+import org.apache.dubbo.common.metrics.MetricsReporter;
+import org.apache.dubbo.common.metrics.collector.DefaultMetricsCollector;
+import org.apache.dubbo.common.metrics.collector.MetricsCollector;
+import org.apache.dubbo.common.metrics.model.sample.GaugeMetricSample;
+import org.apache.dubbo.common.metrics.model.sample.MetricSample;
+import org.apache.dubbo.common.utils.NamedThreadFactory;
+import org.apache.dubbo.metrics.collector.AggregateMetricsCollector;
+import org.apache.dubbo.rpc.model.ApplicationModel;
+
+import io.micrometer.core.instrument.Gauge;
+import io.micrometer.core.instrument.MeterRegistry;
+import io.micrometer.core.instrument.Tag;
+import io.micrometer.core.instrument.binder.jvm.ClassLoaderMetrics;
+import io.micrometer.core.instrument.binder.jvm.JvmGcMetrics;
+import io.micrometer.core.instrument.binder.jvm.JvmMemoryMetrics;
+import io.micrometer.core.instrument.binder.jvm.JvmThreadMetrics;
+import io.micrometer.core.instrument.binder.system.ProcessorMetrics;
+import io.micrometer.core.instrument.composite.CompositeMeterRegistry;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+
+import static org.apache.dubbo.common.constants.MetricsConstants.ENABLE_JVM_METRICS_KEY;
+
+/**
+ * AbstractMetricsReporter.
+ */
+public abstract class AbstractMetricsReporter implements MetricsReporter {
+
+ private final Logger logger = LoggerFactory.getLogger(AbstractMetricsReporter.class);
+
+ protected final URL url;
+ protected final List<MetricsCollector> collectors = new ArrayList<>();
+ protected final CompositeMeterRegistry compositeRegistry = new CompositeMeterRegistry();
+
+ private final ApplicationModel applicationModel;
+ private ScheduledExecutorService collectorSyncJobExecutor = null;
+
+ private static final int DEFAULT_SCHEDULE_INITIAL_DELAY = 5;
+ private static final int DEFAULT_SCHEDULE_PERIOD = 30;
+
+ protected AbstractMetricsReporter(URL url, ApplicationModel applicationModel) {
+ this.url = url;
+ this.applicationModel = applicationModel;
+ }
+
+ @Override
+ public void init() {
+ addJvmMetrics();
+ initCollectors();
+ scheduleMetricsCollectorSyncJob();
+
+ doInit();
+
+ registerDubboShutdownHook();
+ }
+
+ protected void addMeterRegistry(MeterRegistry registry) {
+ compositeRegistry.add(registry);
+ }
+
+ protected ApplicationModel getApplicationModel() {
+ return applicationModel;
+ }
+
+ private void addJvmMetrics() {
+ boolean enableJvmMetrics = url.getParameter(ENABLE_JVM_METRICS_KEY, false);
+ if (enableJvmMetrics) {
+ new ClassLoaderMetrics().bindTo(compositeRegistry);
+ new JvmMemoryMetrics().bindTo(compositeRegistry);
+ new JvmGcMetrics().bindTo(compositeRegistry);
+ new ProcessorMetrics().bindTo(compositeRegistry);
+ new JvmThreadMetrics().bindTo(compositeRegistry);
+ }
+ }
+
+ private void initCollectors() {
+ applicationModel.getBeanFactory().getOrRegisterBean(AggregateMetricsCollector.class);
+
+ collectors.add(applicationModel.getBeanFactory().getBean(DefaultMetricsCollector.class));
+ collectors.add(applicationModel.getBeanFactory().getBean(AggregateMetricsCollector.class));
+ }
+
+ private void scheduleMetricsCollectorSyncJob() {
+ NamedThreadFactory threadFactory = new NamedThreadFactory("metrics-collector-sync-job", true);
+ collectorSyncJobExecutor = Executors.newScheduledThreadPool(1, threadFactory);
+ collectorSyncJobExecutor.scheduleAtFixedRate(() -> {
+ collectors.forEach(collector -> {
+ List<MetricSample> samples = collector.collect();
+ for (MetricSample sample : samples) {
+ try {
+ switch (sample.getType()) {
+ case GAUGE:
+ GaugeMetricSample gaugeSample = (GaugeMetricSample) sample;
+ List<Tag> tags = new ArrayList<>();
+ gaugeSample.getTags().forEach((k, v) -> {
+ if (v == null) {
+ v = "";
+ }
+
+ tags.add(Tag.of(k, v));
Review comment:
This will cause error and thread will be block, but without any exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (18160d3) into [3.0](https://codecov.io/gh/apache/dubbo/commit/954c715366931dd81cf66592700f6f54b1cbbe09?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (954c715) will **increase** coverage by `0.09%`.
> The diff coverage is `72.92%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
+ Coverage 65.34% 65.44% +0.09%
- Complexity 341 401 +60
============================================
Files 1202 1222 +20
Lines 51844 52429 +585
Branches 7727 7773 +46
============================================
+ Hits 33879 34310 +431
- Misses 14351 14473 +122
- Partials 3614 3646 +32
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/dubbo/metrics/service/DefaultMetricsService.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9zZXJ2aWNlL0RlZmF1bHRNZXRyaWNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...n/java/org/apache/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvTmV0VXRpbHMuamF2YQ==) | `68.69% <33.33%> (-0.35%)` | :arrow_down: |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `38.46% <38.46%> (ø)` | |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `50.00% <50.00%> (ø)` | |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `82.58% <50.00%> (+0.26%)` | :arrow_up: |
| [...pache/dubbo/common/metrics/event/MetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9NZXRyaWNzRXZlbnQuamF2YQ==) | `57.14% <57.14%> (ø)` | |
| [...common/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `58.33% <58.33%> (ø)` | |
| [.../apache/dubbo/metrics/AbstractMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9BYnN0cmFjdE1ldHJpY3NSZXBvcnRlci5qYXZh) | `61.29% <61.29%> (ø)` | |
| ... and [30 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [954c715...18160d3](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kevinw66 edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kevinw66 edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-1023923825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (659c02a) into [3.0](https://codecov.io/gh/apache/dubbo/commit/dfe4fcaea107ac292e6f2e967807a0756f59c7e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dfe4fca) will **decrease** coverage by `0.05%`.
> The diff coverage is `72.92%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
- Coverage 65.59% 65.53% -0.06%
- Complexity 297 355 +58
============================================
Files 1191 1211 +20
Lines 52068 52653 +585
Branches 7907 7954 +47
============================================
+ Hits 34154 34507 +353
- Misses 14231 14414 +183
- Partials 3683 3732 +49
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/dubbo/metrics/service/DefaultMetricsService.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9zZXJ2aWNlL0RlZmF1bHRNZXRyaWNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...n/java/org/apache/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvTmV0VXRpbHMuamF2YQ==) | `68.05% <33.33%> (-0.99%)` | :arrow_down: |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `38.46% <38.46%> (ø)` | |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `50.00% <50.00%> (ø)` | |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `82.52% <50.00%> (+0.26%)` | :arrow_up: |
| [...pache/dubbo/common/metrics/event/MetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9NZXRyaWNzRXZlbnQuamF2YQ==) | `57.14% <57.14%> (ø)` | |
| [...common/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `58.33% <58.33%> (ø)` | |
| [.../apache/dubbo/metrics/AbstractMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9BYnN0cmFjdE1ldHJpY3NSZXBvcnRlci5qYXZh) | `61.29% <61.29%> (ø)` | |
| ... and [50 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dfe4fca...659c02a](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kevinw66 commented on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kevinw66 commented on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-987684812
> Should we add a integration test with Prometheus? What about adding a sample to `dubbo-samples` ?
After this feature is ready to use, yes. But not now I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9e8b215) into [3.0](https://codecov.io/gh/apache/dubbo/commit/8a7c360475a6fe33697fd4a1c9cae378f977f684?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8a7c360) will **decrease** coverage by `0.12%`.
> The diff coverage is `72.92%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
- Coverage 65.32% 65.19% -0.13%
- Complexity 343 400 +57
============================================
Files 1202 1222 +20
Lines 51841 52370 +529
Branches 7726 7718 -8
============================================
+ Hits 33865 34144 +279
- Misses 14366 14577 +211
- Partials 3610 3649 +39
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/dubbo/metrics/service/DefaultMetricsService.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9zZXJ2aWNlL0RlZmF1bHRNZXRyaWNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...n/java/org/apache/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvTmV0VXRpbHMuamF2YQ==) | `67.94% <33.33%> (-1.09%)` | :arrow_down: |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `38.46% <38.46%> (ø)` | |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `50.00% <50.00%> (ø)` | |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `82.58% <50.00%> (+0.26%)` | :arrow_up: |
| [...pache/dubbo/common/metrics/event/MetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9NZXRyaWNzRXZlbnQuamF2YQ==) | `57.14% <57.14%> (ø)` | |
| [...common/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `58.33% <58.33%> (ø)` | |
| [.../apache/dubbo/metrics/AbstractMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9BYnN0cmFjdE1ldHJpY3NSZXBvcnRlci5qYXZh) | `61.29% <61.29%> (ø)` | |
| ... and [69 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8a7c360...9e8b215](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9e39cbf) into [3.0](https://codecov.io/gh/apache/dubbo/commit/dfe4fcaea107ac292e6f2e967807a0756f59c7e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dfe4fca) will **increase** coverage by `0.08%`.
> The diff coverage is `72.92%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
+ Coverage 65.59% 65.68% +0.08%
- Complexity 297 355 +58
============================================
Files 1191 1211 +20
Lines 52068 52653 +585
Branches 7907 7954 +47
============================================
+ Hits 34154 34585 +431
- Misses 14231 14353 +122
- Partials 3683 3715 +32
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/dubbo/metrics/service/DefaultMetricsService.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9zZXJ2aWNlL0RlZmF1bHRNZXRyaWNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...n/java/org/apache/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvTmV0VXRpbHMuamF2YQ==) | `69.00% <33.33%> (-0.03%)` | :arrow_down: |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `38.46% <38.46%> (ø)` | |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `50.00% <50.00%> (ø)` | |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `82.52% <50.00%> (+0.26%)` | :arrow_up: |
| [...pache/dubbo/common/metrics/event/MetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9NZXRyaWNzRXZlbnQuamF2YQ==) | `57.14% <57.14%> (ø)` | |
| [...common/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `58.33% <58.33%> (ø)` | |
| [.../apache/dubbo/metrics/AbstractMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9BYnN0cmFjdE1ldHJpY3NSZXBvcnRlci5qYXZh) | `61.29% <61.29%> (ø)` | |
| ... and [35 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dfe4fca...9e39cbf](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (659c02a) into [3.0](https://codecov.io/gh/apache/dubbo/commit/dfe4fcaea107ac292e6f2e967807a0756f59c7e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dfe4fca) will **decrease** coverage by `0.90%`.
> The diff coverage is `72.92%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
- Coverage 65.59% 64.69% -0.91%
- Complexity 297 354 +57
============================================
Files 1191 1211 +20
Lines 52068 52653 +585
Branches 7907 7929 +22
============================================
- Hits 34154 34062 -92
- Misses 14231 14869 +638
- Partials 3683 3722 +39
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/dubbo/metrics/service/DefaultMetricsService.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9zZXJ2aWNlL0RlZmF1bHRNZXRyaWNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...n/java/org/apache/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvTmV0VXRpbHMuamF2YQ==) | `68.05% <33.33%> (-0.99%)` | :arrow_down: |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `38.46% <38.46%> (ø)` | |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `50.00% <50.00%> (ø)` | |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `82.52% <50.00%> (+0.26%)` | :arrow_up: |
| [...pache/dubbo/common/metrics/event/MetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9NZXRyaWNzRXZlbnQuamF2YQ==) | `57.14% <57.14%> (ø)` | |
| [...common/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `58.33% <58.33%> (ø)` | |
| [.../apache/dubbo/metrics/AbstractMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9BYnN0cmFjdE1ldHJpY3NSZXBvcnRlci5qYXZh) | `61.29% <61.29%> (ø)` | |
| ... and [92 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dfe4fca...659c02a](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #8983: [WIP][3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (def4009) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **decrease** coverage by `0.64%`.
> The diff coverage is `16.14%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
- Coverage 64.70% 64.06% -0.65%
Complexity 327 327
============================================
Files 1206 1226 +20
Lines 51844 52378 +534
Branches 7716 7734 +18
============================================
+ Hits 33546 33555 +9
- Misses 14684 15191 +507
- Partials 3614 3632 +18
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/event/BaseMetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9CYXNlTWV0cmljc0V2ZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../apache/dubbo/common/metrics/event/NewRTEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9OZXdSVEV2ZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...he/dubbo/common/metrics/event/NewRequestEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9OZXdSZXF1ZXN0RXZlbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...he/dubbo/common/metrics/model/InterfaceMetric.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9JbnRlcmZhY2VNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...pache/dubbo/common/metrics/model/MethodMetric.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9NZXRob2RNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...common/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [57 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...def4009](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [WIP][3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (58e746c) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **decrease** coverage by `0.62%`.
> The diff coverage is `15.97%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
- Coverage 64.70% 64.07% -0.63%
- Complexity 327 330 +3
============================================
Files 1206 1226 +20
Lines 51844 52378 +534
Branches 7716 7734 +18
============================================
+ Hits 33546 33563 +17
- Misses 14684 15181 +497
- Partials 3614 3634 +20
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/event/BaseMetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9CYXNlTWV0cmljc0V2ZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../apache/dubbo/common/metrics/event/NewRTEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9OZXdSVEV2ZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...he/dubbo/common/metrics/event/NewRequestEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9OZXdSZXF1ZXN0RXZlbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...he/dubbo/common/metrics/model/InterfaceMetric.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9JbnRlcmZhY2VNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...pache/dubbo/common/metrics/model/MethodMetric.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9NZXRob2RNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...common/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [57 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...58e746c](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1c2f709) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **increase** coverage by `0.68%`.
> The diff coverage is `70.89%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
+ Coverage 64.70% 65.39% +0.68%
- Complexity 327 401 +74
============================================
Files 1206 1221 +15
Lines 51844 52308 +464
Branches 7716 7772 +56
============================================
+ Hits 33546 34207 +661
+ Misses 14684 14453 -231
- Partials 3614 3648 +34
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/dubbo/metrics/service/DefaultMetricsService.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9zZXJ2aWNlL0RlZmF1bHRNZXRyaWNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...he/dubbo/common/metrics/model/InterfaceMetric.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9JbnRlcmZhY2VNZXRyaWMuamF2YQ==) | `36.36% <36.36%> (ø)` | |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `38.46% <38.46%> (ø)` | |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `83.06% <50.00%> (+0.26%)` | :arrow_up: |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `52.38% <52.38%> (ø)` | |
| [...e/dubbo/common/metrics/event/BaseMetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9CYXNlTWV0cmljc0V2ZW50LmphdmE=) | `57.14% <57.14%> (ø)` | |
| [.../apache/dubbo/metrics/AbstractMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9BYnN0cmFjdE1ldHJpY3NSZXBvcnRlci5qYXZh) | `61.66% <61.66%> (ø)` | |
| [...pache/dubbo/common/metrics/model/MethodMetric.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9NZXRob2RNZXRyaWMuamF2YQ==) | `65.85% <65.85%> (ø)` | |
| ... and [158 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...1c2f709](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#issuecomment-968088996
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8983](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1c2f709) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **increase** coverage by `0.61%`.
> The diff coverage is `70.89%`.
[](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8983 +/- ##
============================================
+ Coverage 64.70% 65.32% +0.61%
- Complexity 327 401 +74
============================================
Files 1206 1221 +15
Lines 51844 52308 +464
Branches 7716 7772 +56
============================================
+ Hits 33546 34170 +624
+ Misses 14684 14487 -197
- Partials 3614 3651 +37
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/common/metrics/nop/NopMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/metrics/nop/NopMetricsReporterFactory.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ub3AvTm9wTWV0cmljc1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/dubbo/metrics/service/DefaultMetricsService.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9zZXJ2aWNlL0RlZmF1bHRNZXRyaWNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...he/dubbo/common/metrics/model/InterfaceMetric.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9JbnRlcmZhY2VNZXRyaWMuamF2YQ==) | `36.36% <36.36%> (ø)` | |
| [...he/dubbo/common/metrics/service/MetricsEntity.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9zZXJ2aWNlL01ldHJpY3NFbnRpdHkuamF2YQ==) | `38.46% <38.46%> (ø)` | |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `83.06% <50.00%> (+0.26%)` | :arrow_up: |
| [...ubbo/common/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `52.38% <52.38%> (ø)` | |
| [...e/dubbo/common/metrics/event/BaseMetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9CYXNlTWV0cmljc0V2ZW50LmphdmE=) | `57.14% <57.14%> (ø)` | |
| [.../apache/dubbo/metrics/AbstractMetricsReporter.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9BYnN0cmFjdE1ldHJpY3NSZXBvcnRlci5qYXZh) | `61.66% <61.66%> (ø)` | |
| [...pache/dubbo/common/metrics/model/MethodMetric.java](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9NZXRob2RNZXRyaWMuamF2YQ==) | `65.85% <65.85%> (ø)` | |
| ... and [164 more](https://codecov.io/gh/apache/dubbo/pull/8983/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...1c2f709](https://codecov.io/gh/apache/dubbo/pull/8983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r773583303
##########
File path: dubbo-metrics/dubbo-metrics-prometheus/src/main/java/org/apache/dubbo/metrics/prometheus/PrometheusMetricsReporter.java
##########
@@ -93,7 +94,8 @@ private void exportHttpServer() {
}
});
- new Thread(prometheusExporterHttpServer::start).start();
+ httpServerThread = new Thread(prometheusExporterHttpServer::start);
+ httpServerThread.start();
Review comment:
The `httpServerThread` is terminated after stop http server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r762401877
##########
File path: dubbo-common/src/main/java/org/apache/dubbo/common/metrics/model/InterfaceMetric.java
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.common.metrics.model;
+
+import java.util.Objects;
+
+public class InterfaceMetric {
Review comment:
The `InterfaceMetric` doesn't seem to be used. Remove it if its useless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r762406932
##########
File path: dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/AbstractMetricsReporter.java
##########
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.metrics;
+
+import org.apache.dubbo.common.URL;
+import org.apache.dubbo.common.lang.ShutdownHookCallbacks;
+import org.apache.dubbo.common.logger.Logger;
+import org.apache.dubbo.common.logger.LoggerFactory;
+import org.apache.dubbo.common.metrics.MetricsReporter;
+import org.apache.dubbo.common.metrics.collector.DefaultMetricsCollector;
+import org.apache.dubbo.common.metrics.collector.MetricsCollector;
+import org.apache.dubbo.common.metrics.model.sample.GaugeMetricSample;
+import org.apache.dubbo.common.metrics.model.sample.MetricSample;
+import org.apache.dubbo.common.utils.NamedThreadFactory;
+import org.apache.dubbo.metrics.collector.AggregateMetricsCollector;
+import org.apache.dubbo.rpc.model.ApplicationModel;
+
+import io.micrometer.core.instrument.Gauge;
+import io.micrometer.core.instrument.MeterRegistry;
+import io.micrometer.core.instrument.Tag;
+import io.micrometer.core.instrument.binder.jvm.ClassLoaderMetrics;
+import io.micrometer.core.instrument.binder.jvm.JvmGcMetrics;
+import io.micrometer.core.instrument.binder.jvm.JvmMemoryMetrics;
+import io.micrometer.core.instrument.binder.jvm.JvmThreadMetrics;
+import io.micrometer.core.instrument.binder.system.ProcessorMetrics;
+import io.micrometer.core.instrument.composite.CompositeMeterRegistry;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+
+import static org.apache.dubbo.common.constants.MetricsConstants.ENABLE_JVM_METRICS_KEY;
+
+/**
+ * AbstractMetricsReporter.
+ */
+public abstract class AbstractMetricsReporter implements MetricsReporter {
+
+ private final Logger logger = LoggerFactory.getLogger(AbstractMetricsReporter.class);
+
+ protected final URL url;
+ protected final List<MetricsCollector> collectors = new ArrayList<>();
+ protected final CompositeMeterRegistry compositeRegistry = new CompositeMeterRegistry();
+
+ private final ApplicationModel applicationModel;
+ private ScheduledExecutorService collectorSyncJobExecutor = null;
+
+ private static final int DEFAULT_SCHEDULE_INITIAL_DELAY = 5;
+ private static final int DEFAULT_SCHEDULE_PERIOD = 30;
+
+ protected AbstractMetricsReporter(URL url, ApplicationModel applicationModel) {
+ this.url = url;
+ this.applicationModel = applicationModel;
+ }
+
+ @Override
+ public void init() {
Review comment:
Need to prevent repeated initialization, for example check if inited before do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #8983: [3.0] Add micrometer-prometheus metrics support
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #8983:
URL: https://github.com/apache/dubbo/pull/8983#discussion_r762412755
##########
File path: dubbo-common/src/main/java/org/apache/dubbo/common/metrics/collector/DefaultMetricsCollector.java
##########
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.common.metrics.collector;
+
+import org.apache.dubbo.common.metrics.event.BaseMetricsEvent;
+import org.apache.dubbo.common.metrics.event.NewRTEvent;
+import org.apache.dubbo.common.metrics.event.NewRequestEvent;
+import org.apache.dubbo.common.metrics.listener.MetricsListener;
+import org.apache.dubbo.common.metrics.model.MethodMetric;
+import org.apache.dubbo.common.metrics.model.sample.GaugeMetricSample;
+import org.apache.dubbo.common.metrics.model.sample.MetricSample;
+import org.apache.dubbo.rpc.model.ApplicationModel;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicLong;
+
+import static org.apache.dubbo.common.metrics.model.MetricsCategory.REQUESTS;
+import static org.apache.dubbo.common.metrics.model.MetricsCategory.RT;
+
+/**
+ * Default implementation of {@link MetricsCollector}
+ */
+public class DefaultMetricsCollector implements MetricsCollector {
+
+ private Boolean collectEnabled = false;
+ private final List<MetricsListener> listeners = new ArrayList<>();
+ private final ApplicationModel applicationModel;
+ private final String applicationName;
+
+ private final Map<MethodMetric, AtomicLong> totalRequests = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> succeedRequests = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> failedRequests = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> processingRequests = new HashMap<>();
+
+ private final Map<MethodMetric, AtomicLong> lastRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> minRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> maxRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> avgRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> totalRT = new HashMap<>();
+ private final Map<MethodMetric, AtomicLong> rtCount = new HashMap<>();
+
+ public DefaultMetricsCollector(ApplicationModel applicationModel) {
+ this.applicationModel = applicationModel;
+ this.applicationName = applicationModel.tryGetApplicationName();
+ }
+
+ public void setCollectEnabled(Boolean collectEnabled) {
+ this.collectEnabled = collectEnabled;
+ }
+
+ public Boolean isCollectEnabled() {
+ return collectEnabled;
+ }
+
+ public void addListener(MetricsListener listener) {
+ listeners.add(listener);
+ }
+
+ public void increaseTotalRequests(String interfaceName, String methodName, String parameterTypesDesc, String group, String version) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+ AtomicLong count = totalRequests.computeIfAbsent(metric, k -> new AtomicLong(0L));
+ count.incrementAndGet();
+
+ publishEvent(new NewRequestEvent(metric, NewRequestEvent.Type.TOTAL));
+ }
+ }
+
+ public void increaseSucceedRequests(String interfaceName, String methodName, String parameterTypesDesc, String group, String version) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+ AtomicLong count = succeedRequests.computeIfAbsent(metric, k -> new AtomicLong(0L));
+ count.incrementAndGet();
+
+ publishEvent(new NewRequestEvent(metric, NewRequestEvent.Type.SUCCEED));
+ }
+ }
+
+ public void increaseFailedRequests(String interfaceName, String methodName, String parameterTypesDesc, String group, String version) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+ AtomicLong count = failedRequests.computeIfAbsent(metric, k -> new AtomicLong(0L));
+ count.incrementAndGet();
+
+ publishEvent(new NewRequestEvent(metric, NewRequestEvent.Type.FAILED));
+ }
+ }
+
+ public void increaseProcessingRequests(String interfaceName, String methodName, String parameterTypesDesc, String group, String version) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+ AtomicLong count = processingRequests.computeIfAbsent(metric, k -> new AtomicLong(0L));
+ count.incrementAndGet();
+ }
+ }
+
+ public void decreaseProcessingRequests(String interfaceName, String methodName, String parameterTypesDesc, String group, String version) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+ AtomicLong count = processingRequests.computeIfAbsent(metric, k -> new AtomicLong(0L));
+ count.decrementAndGet();
+ }
+ }
+
+ public void addRT(String interfaceName, String methodName, String parameterTypesDesc, String group, String version, Long responseTime) {
+ if (isCollectEnabled()) {
+ MethodMetric metric = new MethodMetric(applicationName, interfaceName, methodName, parameterTypesDesc, group, version);
+
+ AtomicLong last = lastRT.computeIfAbsent(metric, k -> new AtomicLong());
+ last.set(responseTime);
+
+ AtomicLong min = minRT.computeIfAbsent(metric, k -> new AtomicLong(Long.MAX_VALUE));
+ if (responseTime < min.longValue()) {
+ min.set(responseTime);
+ }
+
+ AtomicLong max = maxRT.computeIfAbsent(metric, k -> new AtomicLong(Long.MIN_VALUE));
+ if (responseTime > max.longValue()) {
+ max.set(responseTime);
+ }
+
+ AtomicLong total = totalRT.computeIfAbsent(metric, k -> new AtomicLong());
+ long newTotal = total.addAndGet(responseTime);
+
+ AtomicLong count = rtCount.computeIfAbsent(metric, k -> new AtomicLong());
+ AtomicLong avg = avgRT.computeIfAbsent(metric, k -> new AtomicLong());
+ long newAvg = newTotal / count.addAndGet(1);
+ avg.set(newAvg);
+
+ publishEvent(new NewRTEvent(metric, responseTime));
+ }
+ }
+
+ private void publishEvent(BaseMetricsEvent event) {
+ for (MetricsListener listener : listeners) {
+ listener.onEvent(event);
+ }
+ }
+
+ @Override
+ public List<MetricSample> collect() {
+ List<MetricSample> list = new ArrayList<>();
+ collectRequests(list);
+ collectRT(list);
+
+ return list;
+ }
+
+ private void collectRequests(List<MetricSample> list) {
+ totalRequests.forEach((k, v) -> list.add(new GaugeMetricSample("requests.total", "Total Requests", k.getTags(), REQUESTS, v::get)));
+ succeedRequests.forEach((k, v) -> list.add(new GaugeMetricSample("requests.succeed", "Succeed Requests", k.getTags(), REQUESTS, v::get)));
+ failedRequests.forEach((k, v) -> list.add(new GaugeMetricSample("requests.failed", "Failed Requests", k.getTags(), REQUESTS, v::get)));
+ processingRequests.forEach((k, v) -> list.add(new GaugeMetricSample("requests.processing", "Processing Requests", k.getTags(), REQUESTS, v::get)));
+ }
+
+ private void collectRT(List<MetricSample> list) {
+ lastRT.forEach((k, v) -> list.add(new GaugeMetricSample("rt.last", "Last Response Time", k.getTags(), RT, v::get)));
+ minRT.forEach((k, v) -> list.add(new GaugeMetricSample("rt.min", "Min Response Time", k.getTags(), RT, v::get)));
+ maxRT.forEach((k, v) -> list.add(new GaugeMetricSample("rt.max", "Max Response Time", k.getTags(), RT, v::get)));
+ avgRT.forEach((k, v) -> list.add(new GaugeMetricSample("rt.avg", "Avg Response Time", k.getTags(), RT, v::get)));
+ totalRT.forEach((k, v) -> list.add(new GaugeMetricSample("rt.total", "Total Response Time", k.getTags(), RT, v::get)));
+ }
+}
Review comment:
Please extract metrics name as string constrants
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org