You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/28 21:09:40 UTC
[GitHub] [airflow] RNHTTR opened a new pull request, #23339: fix cli airflow show dags for mapped operator
RNHTTR opened a new pull request, #23339:
URL: https://github.com/apache/airflow/pull/23339
For mapped operators, `airflow show dags <dag_id>` is broken (see #23315 )
Task expansion creates a MappedOperator, which ultimately inherits from AbstractOperator and not BaseOperator.
`airflow dags show` ultimately calls [dot_renderer.py](https://github.com/apache/airflow/blob/main/airflow/utils/dot_renderer.py#L117-L118) to draw the DAG, and it checks that each node is either a `TaskGroup` or a `BaseOperator`, thus the error. Adding a check to see if the node is an `AbstractOperator` fixes this.
closes: #23315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham merged pull request #23339: fix cli airflow show dags for mapped operator
Posted by GitBox <gi...@apache.org>.
jedcunningham merged PR #23339:
URL: https://github.com/apache/airflow/pull/23339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #23339: fix cli airflow show dags for mapped operator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23339:
URL: https://github.com/apache/airflow/pull/23339#issuecomment-1113710362
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org