[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #16572: [improve][doc]add more explanation for retention configuration

[GitBox <gi...@apache.org>]

Anonymitaet commented on code in PR #16572:
URL: https://github.com/apache/pulsar/pull/16572#discussion_r921742303


##########
conf/broker.conf:
##########
@@ -1258,10 +1258,12 @@ replicatorPrefix=pulsar.repl
 # due to missing ZooKeeper watch (disable with value 0)
 replicationPolicyCheckDurationSeconds=600
 
-# Default message retention time
+# Default message retention time, less than 0 means never expire.
+# Default is 0, which means the data will be removed after all the subscriptions are consumed.

Review Comment:
   Same comments for the other occurrences in this PR.



##########
conf/broker.conf:
##########
@@ -1258,10 +1258,12 @@ replicatorPrefix=pulsar.repl
 # due to missing ZooKeeper watch (disable with value 0)
 replicationPolicyCheckDurationSeconds=600
 
-# Default message retention time
+# Default message retention time, less than 0 means never expire.
+# Default is 0, which means the data will be removed after all the subscriptions are consumed.

Review Comment:
   ```suggestion
   # Default message retention time.
   # The default value is 0, which means the data is removed after all the subscriptions are consumed.
   # Value less than 0 means messages never expire.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org