[GitHub] [ozone] neils-dev commented on a diff in pull request #4362: HDDS-8035. Intermittent timeout in TestOzoneManagerHAWithData.testOMHAMetrics

["neils-dev (via GitHub)" <gi...@apache.org>]

neils-dev commented on code in PR #4362:
URL: https://github.com/apache/ozone/pull/4362#discussion_r1138088370


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHAWithData.java:
##########
@@ -107,7 +107,6 @@ public void testMultipartUpload() throws Exception {
   }
 
   @Test
-  @Flaky("HDDS-8035")
   public void testOMHAMetrics() throws InterruptedException,
       TimeoutException, IOException {
     waitForLeaderToBeReady();

Review Comment:
   Should also fix `waitForLeaderToBeReady()`.  Currently unnecessarily checking `isLeaderReady() `within the method.  
   Specifically, the line 
   https://github.com/apache/ozone/blob/ce418581a8b4533a47de741d543072903562a4c6/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHAWithData.java#L181
   `isLeaderReady() `is redundant as it is called within the `getCluster().getOMLeader()`
   https://github.com/apache/ozone/blob/ce418581a8b4533a47de741d543072903562a4c6/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneHAClusterImpl.java#L197
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org