You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@orc.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2024/12/29 09:36:53 UTC

Re: [PR] ORC-1810: [C++] Add environment variable ORC_FORMAT_URL [orc]

kou commented on code in PR #2094:
URL: https://github.com/apache/orc/pull/2094#discussion_r1899094258


##########
cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -33,7 +33,6 @@ option(ORC_PREFER_STATIC_LZ4      "Prefer static lz4 library, if available"
 option(ORC_PREFER_STATIC_ZSTD     "Prefer static zstd library, if available"     ON)
 option(ORC_PREFER_STATIC_ZLIB     "Prefer static zlib library, if available"     ON)
 option(ORC_PREFER_STATIC_GMOCK    "Prefer static gmock library, if available"    ON)
-

Review Comment:
   We may want to revert this needless change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org