You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2019/01/23 06:05:45 UTC

[GitHub] shardul-cr7 opened a new pull request #3097: [CARBONDATA-3246]Fix sdk reader issue if batch size is given as zero and vectorRead False.

shardul-cr7 opened a new pull request #3097:  [CARBONDATA-3246]Fix sdk reader issue if batch size is given as zero and vectorRead False.
URL: https://github.com/apache/carbondata/pull/3097
 
 
   #3070 was wrongly merged.Some earlier commit was merged rather than the original one which got LGTM. So this PR is to fix that issue.
    
   This PR is to fix sdk reader issue when batch size is given as zero and vectorRead False.
   
   Problem SDK reader is failing if vectorRead is false and detail query batch size is given as 0.Compiler is giving stack overflow error after getting stuck in ChunkRowIterator.hasnext recurssion.
   
   Solution Since 0 is wrong batch size, we should take DETAIL_QUERY_BATCH_SIZE_DEFAULT as the batch size
   
   Be sure to do all of the following checklist to help us incorporate 
   your contribution quickly and easily:
   
    - [x] Any interfaces changed?- No
    
    - [x] Any backward compatibility impacted? - No
    
    - [x] Document update required? - No
   
   
    - [x] Testing done
           added test case 
          
    - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services