You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/06/05 05:13:08 UTC
[GitHub] [incubator-superset] codecov-io commented on issue #7641: [SQL Lab]
Clarify SQL Lab query and display limits
codecov-io commented on issue #7641: [SQL Lab] Clarify SQL Lab query and display limits
URL: https://github.com/apache/incubator-superset/pull/7641#issuecomment-498941213
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7641?src=pr&el=h1) Report
> Merging [#7641](https://codecov.io/gh/apache/incubator-superset/pull/7641?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f99ae1ad247298c8b8df3721768f69b13152aef0?src=pr&el=desc) will **decrease** coverage by `8.85%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/7641?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7641 +/- ##
==========================================
- Coverage 65.57% 56.72% -8.86%
==========================================
Files 435 351 -84
Lines 21744 10409 -11335
Branches 2393 2396 +3
==========================================
- Hits 14259 5904 -8355
+ Misses 7364 4384 -2980
Partials 121 121
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7641?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset/assets/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TcWxFZGl0b3IuanN4) | `55.11% <100%> (+1.08%)` | :arrow_up: |
| [superset/data/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/7641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YS9iaXJ0aF9uYW1lcy5weQ==) | | |
| [superset/data/long\_lat.py](https://codecov.io/gh/apache/incubator-superset/pull/7641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YS9sb25nX2xhdC5weQ==) | | |
| [superset/tasks/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/7641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvX19pbml0X18ucHk=) | | |
| [superset/views/datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/7641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | | |
| [superset/data/bart\_lines.py](https://codecov.io/gh/apache/incubator-superset/pull/7641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YS9iYXJ0X2xpbmVzLnB5) | | |
| [superset/data/country\_map.py](https://codecov.io/gh/apache/incubator-superset/pull/7641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YS9jb3VudHJ5X21hcC5weQ==) | | |
| [superset/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/7641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZm9ybXMucHk=) | | |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/incubator-superset/pull/7641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | | |
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/7641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | | |
| ... and [71 more](https://codecov.io/gh/apache/incubator-superset/pull/7641/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7641?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7641?src=pr&el=footer). Last update [f99ae1a...bd97d4f](https://codecov.io/gh/apache/incubator-superset/pull/7641?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org