[GitHub] [iceberg] shangxinli commented on a change in pull request #2062: [CORE] Add in a NOT_STARTS_WITH operator with filter pushdown

[GitBox <gi...@apache.org>]

shangxinli commented on a change in pull request #2062:
URL: https://github.com/apache/iceberg/pull/2062#discussion_r554696316



##########
File path: api/src/main/java/org/apache/iceberg/expressions/InclusiveMetricsEvaluator.java
##########
@@ -372,6 +372,38 @@ public Boolean or(Boolean leftResult, Boolean rightResult) {
       return ROWS_MIGHT_MATCH;
     }
 
+    @Override
+    public <T> Boolean notStartsWith(BoundReference<T> ref, Literal<T> lit) {

Review comment:
       if notStartsWith can be negated from startsWith, why not replace the whole method body with "return !startsWith(ref, lit);", instead of replicating so much code?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org