You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@joshua.apache.org by fhieber <gi...@git.apache.org> on 2016/06/21 10:19:26 UTC
[GitHub] incubator-joshua pull request #26: Owner Ids are maintained in separate mapp...
GitHub user fhieber opened a pull request:
https://github.com/apache/incubator-joshua/pull/26
Owner Ids are maintained in separate mapping now
Removed owner ids from Vocabulary. These are now maintained in their own mapping. Fixes a bug with multiple packed grammars that would overwrite each others owner Vocab id. Also cleaned up grammar constructors a little bit.
The owner id is now strongly typed to prevent users to accidentally use ints that do not represent an actual OwnerId. Further OwnerIds can only be returned by the OwnerMap.register() method.
@mjpost I am obviously not a Github PR expert. This PR includes the other one about class LMs. Lets coordinate merging if you are ok with both.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhieber/incubator-joshua owner
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-joshua/pull/26.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #26
----
commit 8fc7544eaaf35f71367b48778eaa1f22772ca390
Author: Felix Hieber <fh...@amazon.com>
Date: 2016-06-20T09:21:03Z
ClassLMs: fixed a bug with class-based lms not mapping to class ids when estimateCost(). Also refactored the code a little bit to have StateMinimizingLanguageModels support classes as well. Added some unit tests. The existing regression test output was changed to the new output.
commit 1011bbb03b29b57eb2903e4817a4d6a3d553354e
Author: Felix Hieber <fh...@amazon.com>
Date: 2016-06-20T15:55:23Z
Removed owner ids from Vocabulary. These are now maintained in their own mapping. Fixes a bug with multiple packed grammars that would overwrite each others owner Vocab id. Also cleaned up grammar constructors a little bit.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-joshua issue #26: Owner Ids are maintained in separate mapping now
Posted by fhieber <gi...@git.apache.org>.
Github user fhieber commented on the issue:
https://github.com/apache/incubator-joshua/pull/26
Alright, I can rebase this PR once the ClassLM PR is merged so that we have a clean separation of those two commits on Github
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-joshua issue #26: Owner Ids are maintained in separate mapping now
Posted by mjpost <gi...@git.apache.org>.
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/26
Great, this checks out for me. Since it contains the class LM fix, too, though, I'll wait to merge until those tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-joshua pull request #26: Owner Ids are maintained in separate mapp...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-joshua/pull/26
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---