You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/04/24 20:11:54 UTC

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4645: Api v3

ocket8888 commented on a change in pull request #4645:
URL: https://github.com/apache/trafficcontrol/pull/4645#discussion_r414835083



##########
File path: grove/grovetccfg/grovetccfg.go
##########
@@ -35,7 +35,7 @@ import (
 	"time"
 
 	"github.com/apache/trafficcontrol/lib/go-tc"
-	to "github.com/apache/trafficcontrol/traffic_ops/client"
+	to "github.com/apache/trafficcontrol/traffic_ops/v2-client"

Review comment:
       Yeah, honestly I think upgrading all the clients to v2 right away was probably a mistake. Might let us get rid of Perl sooner, though, so well worth it
   
   > _"use v2 for most things then attempt v3"_
   
   That's an option, but tbh it depends on what you mean by "needs". TM changes will be capable of reading either 2.0 or 3.0 response payloads, so TM will continue to function with 2.0 for the forseeable future. But then it won't be able to provide the new feature.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org