You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/19 01:30:34 UTC
[GitHub] [skywalking-python] Superskyyy opened a new pull request #166: Remove places that mentions Python 3.5 support due to EOL
Superskyyy opened a new pull request #166:
URL: https://github.com/apache/skywalking-python/pull/166
Will test Python 3.10 when officially releases next month.
Signed-off-by: Superskyyy <Su...@outlook.com>
<!-- Uncomment the following checklist WHEN AND ONLY WHEN you're adding a new plugin -->
<!--
- [ ] Add a test case for the new plugin
- [ ] Add a component id in [the main repo](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml#L415)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
- [ ] Rebuild the `requirements.txt` by running `tools/env/build_requirements_(linux|windows).sh`
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng commented on pull request #166: Remove places that mentions Python 3.5 support due to EOL
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #166:
URL: https://github.com/apache/skywalking-python/pull/166#issuecomment-922459129
As you said we will drop 3.5 supports, https://twitter.com/ASFSkyWalking/status/1439553219210792963.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 commented on pull request #166: Remove places that mentions Python 3.5 support due to EOL
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #166:
URL: https://github.com/apache/skywalking-python/pull/166#issuecomment-922400334
We can say 3.5 is EOL and is not in our test matrix, it works in versions prior to 1.0, but it may or may not work with the codebase evolves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 commented on pull request #166: Remove places that mentions Python 3.5 support due to EOL
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #166:
URL: https://github.com/apache/skywalking-python/pull/166#issuecomment-938657457
> Will test Python 3.10 when officially releases next month.
>
Seems 3.10 is out. @Superskyyy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 commented on pull request #166: Remove places that mentions Python 3.5 support due to EOL
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #166:
URL: https://github.com/apache/skywalking-python/pull/166#issuecomment-922406581
> > We can say 3.5 is EOL and is not in our test matrix, it works in versions prior to 1.0, but it may or may not work with the codebase evolves.
>
>
>
> Ok, I intend to swap existing string formatting(`%` `.format` `+` etc.) to f-strings since they are much faster, but that does blocks all Python 3.5 users from v1.0.0, should I do that?
That's awesome. We can do that, and just say since 1.0 we don't support 3.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 merged pull request #166: Remove places that mentions Python 3.5 support due to EOL
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #166:
URL: https://github.com/apache/skywalking-python/pull/166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 commented on a change in pull request #166: Remove places that mentions Python 3.5 support due to EOL
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #166:
URL: https://github.com/apache/skywalking-python/pull/166#discussion_r711731706
##########
File path: README.md
##########
@@ -19,7 +19,7 @@ microservices, cloud native and container-based (Docker, Kubernetes, Mesos) arch
## Installation Requirements
-SkyWalking Python Agent requires SkyWalking 8.0+ and Python 3.5+.
+SkyWalking Python Agent requires SkyWalking 8.0+ and Python 3.6+.
Review comment:
OK, since the requirement here is version-ed, users should check the corresponding doc of their versions, this PR is good to me now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #166: Remove places that mentions Python 3.5 support due to EOL
Posted by GitBox <gi...@apache.org>.
Superskyyy commented on pull request #166:
URL: https://github.com/apache/skywalking-python/pull/166#issuecomment-922403989
> We can say 3.5 is EOL and is not in our test matrix, it works in versions prior to 1.0, but it may or may not work with the codebase evolves.
Ok, I intend to swap existing string formatting(`%` `.format` `+` etc.) to f-strings since they are much faster, but that does blocks all Python 3.5 users from v1.0.0, should I do that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org