You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:48:55 UTC
[GitHub] [pulsar] jerrypeng commented on a change in pull request #7201: During Function update, cleanup should only happen for temp files that were generated
jerrypeng commented on a change in pull request #7201:
URL: https://github.com/apache/pulsar/pull/7201#discussion_r437574956
##########
File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/FunctionsImpl.java
##########
@@ -419,9 +419,10 @@ public void updateFunction(final String tenant,
updateRequest(functionMetaDataBuilder.build());
} finally {
- if (!(functionPkgUrl != null && functionPkgUrl.startsWith(Utils.FILE))
- && componentPackageFile != null && componentPackageFile.exists()) {
- componentPackageFile.delete();
+ if (componentPackageFile != null && componentPackageFile.exists()) {
+ if ((functionPkgUrl != null && !functionPkgUrl.startsWith(Utils.FILE)) || uploadedInputStream != null) {
Review comment:
Do we also need to exclude "http" ?
##########
File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/FunctionsImpl.java
##########
@@ -419,9 +419,10 @@ public void updateFunction(final String tenant,
updateRequest(functionMetaDataBuilder.build());
} finally {
- if (!(functionPkgUrl != null && functionPkgUrl.startsWith(Utils.FILE))
- && componentPackageFile != null && componentPackageFile.exists()) {
- componentPackageFile.delete();
+ if (componentPackageFile != null && componentPackageFile.exists()) {
+ if ((functionPkgUrl != null && !functionPkgUrl.startsWith(Utils.FILE)) || uploadedInputStream != null) {
Review comment:
Do we need to add this for sources and sinks as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org