You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "aaronlindsey (GitHub)" <gi...@apache.org> on 2019/08/15 20:59:52 UTC

[GitHub] [geode] aaronlindsey opened pull request #3935: GEODE-7091: Add Micrometer binders to meter registry

Add the following Micrometer binders:
- JvmGcMetrics
- ProcessorMetrics
- JvmThreadMetrics
- UptimeMetrics
- FileDescriptorMetrics

Co-authored-by: Aaron Lindsey <al...@pivotal.io>
Co-authored-by: Kirk Lund <kl...@apache.org>

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [x] Have you written or updated unit tests to verify your changes?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3935 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mhansonp commented on issue #3935: GEODE-7091: Add Micrometer binders to meter registry

Posted by "mhansonp (GitHub)" <gi...@apache.org>.
My bad. :(

Thanks,
Mark


[ Full content available at: https://github.com/apache/geode/pull/3935 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mhansonp closed pull request #3935: GEODE-7091: Add Micrometer binders to meter registry

Posted by "mhansonp (GitHub)" <gi...@apache.org>.
[ pull request closed by mhansonp ]

[ Full content available at: https://github.com/apache/geode/pull/3935 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mhansonp commented on issue #3935: GEODE-7091: Add Micrometer binders to meter registry

Posted by "mhansonp (GitHub)" <gi...@apache.org>.
My bad. :(

Thanks,
Mark

> On Aug 15, 2019, at 2:56 PM, M. Oleske <no...@github.com> wrote:
> 
> It may have been good to let the acceptance test and distributed test finish (especially since there was a new acceptance test)
> 
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub <https://github.com/apache/geode/pull/3935?email_source=notifications&email_token=AGKUD7M7MDIALAGYI566HRTQEXGKRA5CNFSM4IMB2VE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4NDQAY#issuecomment-521811971>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGKUD7LH6PJIPWQL4ZZ562DQEXGKRANCNFSM4IMB2VEQ>.
> 



[ Full content available at: https://github.com/apache/geode/pull/3935 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org