[GitHub] [inlong] fuweng11 commented on a diff in pull request #7390: [INLONG-7389][Manager][Sort] Add audit id info for source

["fuweng11 (via GitHub)" <gi...@apache.org>]

fuweng11 commented on code in PR #7390:
URL: https://github.com/apache/inlong/pull/7390#discussion_r1129099648


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/sort/DefaultSortConfigOperator.java:
##########
@@ -121,6 +124,15 @@ private GroupInfo getGroupInfo(InlongGroupInfo groupInfo, List<InlongStreamInfo>
             // build a stream info from the nodes and relations
             List<StreamSource> sources = sourceMap.get(streamId);
             List<StreamSink> sinks = sinkMap.get(streamId);
+            // get audit list by sink type
+            List<String> auditIds = new ArrayList<>();
+            for (StreamSink sink : sinks) {
+                auditIds.add(auditService.getAuditId(sink.getSinkType(), false));

Review Comment:
   It wouldn't.



##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/sort/DefaultSortConfigOperator.java:
##########
@@ -121,6 +124,15 @@ private GroupInfo getGroupInfo(InlongGroupInfo groupInfo, List<InlongStreamInfo>
             // build a stream info from the nodes and relations
             List<StreamSource> sources = sourceMap.get(streamId);
             List<StreamSink> sinks = sinkMap.get(streamId);
+            // get audit list by sink type
+            List<String> auditIds = new ArrayList<>();
+            for (StreamSink sink : sinks) {
+                auditIds.add(auditService.getAuditId(sink.getSinkType(), false));

Review Comment:
   It wouldn't.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org