You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2010/03/12 14:10:31 UTC
Re: svn commit: r922245 - /subversion/trunk/subversion/libsvn_subr/mergeinfo.c
On Fri, Mar 12, 2010 at 08:01, <ju...@apache.org> wrote:
>...
> +++ subversion/trunk/subversion/libsvn_subr/mergeinfo.c Fri Mar 12 13:01:18 2010
> @@ -848,10 +848,7 @@ svn_mergeinfo__set_inheritance(svn_merge
> hi;
> hi = apr_hash_next(hi))
> {
> - apr_array_header_t *rangelist;
> - const char *path = svn__apr_hash_index_key(hi);
> -
> - rangelist = apr_hash_get(mergeinfo, path, APR_HASH_KEY_STRING);
> + apr_array_header_t *rangelist = svn__apr_hash_index_val(hi);
hehe... const?
:-)
>...
Cheers,
-g
Re: svn commit: r922245 -
/subversion/trunk/subversion/libsvn_subr/mergeinfo.c
Posted by Julian Foad <ju...@wandisco.com>.
Greg Stein wrote:
> On Fri, Mar 12, 2010 at 08:01, <ju...@apache.org> wrote:
> >...
> > +++ subversion/trunk/subversion/libsvn_subr/mergeinfo.c Fri Mar 12 13:01:18 2010
> > @@ -848,10 +848,7 @@ svn_mergeinfo__set_inheritance(svn_merge
> > hi;
> > hi = apr_hash_next(hi))
> > {
> > - apr_array_header_t *rangelist;
> > - const char *path = svn__apr_hash_index_key(hi);
> > -
> > - rangelist = apr_hash_get(mergeinfo, path, APR_HASH_KEY_STRING);
> > + apr_array_header_t *rangelist = svn__apr_hash_index_val(hi);
>
> hehe... const?
>
> :-)
Certainly not! This function is modifying the rangelist. (Not
modifying the "apr_array_header_t" structure itself, but modifying data
that an array element points to, so logically modifying "the rangelist
array".)
- Julian