You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by patricker <gi...@git.apache.org> on 2016/08/15 22:01:47 UTC

[GitHub] nifi pull request #869: NIFI-2576 - PutSQL assumes all Timestamps are provid...

GitHub user patricker opened a pull request:

    https://github.com/apache/nifi/pull/869

    NIFI-2576 - PutSQL assumes all Timestamps are provided in Epoch

    This change allows for either epoch timestamps or "yyyy-MM-dd hh:mm:ss.SSS" format; which is the format you get when you call ResultSet.getString on a JDBC Timestamp column.
    
    Also include a unit test for PutSQL to test both flavors of Timestamps.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/patricker/nifi master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/869.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #869
    
----
commit 92eb864c96dc3096c28f6d3a2e13402d7bc0a292
Author: Peter Wicks <pw...@micron.com>
Date:   2016-08-15T16:49:37Z

    NIFI-2356

commit b28806b52f0a7c7d35e2713db0495c9af6a55641
Author: Peter Wicks <pw...@micron.com>
Date:   2016-08-15T17:47:46Z

    Sync

commit ab0568341c5639998f1a292311a58069ead21e7a
Author: Peter Wicks <pw...@micron.com>
Date:   2016-08-15T21:50:47Z

    NIFI-2576

commit 1c7ea31346ce1dbd80b2fd392be1d2f4dfccbabe
Author: Peter Wicks <pw...@micron.com>
Date:   2016-08-15T21:52:45Z

    Merge remote-tracking branch 'upstream/master'

commit 4ce80fa69ac8524756818dd6d530954985b430c5
Author: Peter Wicks <pw...@micron.com>
Date:   2016-08-15T22:00:31Z

    NIFI-2576

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #869: NIFI-2576 - PutSQL assumes all Timestamps are provid...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/869


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #869: NIFI-2576 - PutSQL assumes all Timestamps are provided in E...

Posted by bbende <gi...@git.apache.org>.
Github user bbende commented on the issue:

    https://github.com/apache/nifi/pull/869
  
    @patricker thanks for the contribution! Definitely makes sense to support both formats... 
    
    What do you think about using a regex to determine if it is a long, and if so then parseLong, otherwise attempt to parse a date? (could be the other way around, but I was thinking the regex for a long is easiest) 
    
    I'm thinking of the case where someone is always sending in longs and it is continuously throwing/catching the parse exception, that may end up being expensive.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #869: NIFI-2576 - PutSQL assumes all Timestamps are provided in E...

Posted by bbende <gi...@git.apache.org>.
Github user bbende commented on the issue:

    https://github.com/apache/nifi/pull/869
  
    Thanks for update, merged to master!
    
    Just an FYI, I had a bit of trouble getting the changes to apply from the PR onto master... for future it would be easiest to have a specific branch with only one commit for the initial PR, rather than submitting from your master to NiFi master. Thanks again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #869: NIFI-2576 - PutSQL assumes all Timestamps are provided in E...

Posted by patricker <gi...@git.apache.org>.
Github user patricker commented on the issue:

    https://github.com/apache/nifi/pull/869
  
    I can go for that. Updated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---