You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/11/28 05:50:24 UTC

[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #8404: fix: the x-forwarded-* header will be influenced by ai plugin

monkeyDluffy6017 commented on code in PR #8404:
URL: https://github.com/apache/apisix/pull/8404#discussion_r1033148245


##########
t/plugin/proxy-rewrite3.t:
##########
@@ -455,3 +454,51 @@ passed
 GET /echo HTTP/1.1
 --- response_headers
 test: test_in_set
+
+
+
+=== TEST 21: set route (test if X-Forwarded-Port can be set before proxy)

Review Comment:
   `var_x_forwarded_port` is set in `set_upstream_headers`, `set_upstream_headers` is called in `handle_upstream`, and `handle_upstream` is replaced in the ai module.
   It will fail in the ci env if the ai module is triggered.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org