You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/08/25 22:20:20 UTC
[GitHub] [pulsar] sijie commented on a change in pull request #5019: Fix
code inspection issues in pulsar broker tests
sijie commented on a change in pull request #5019: Fix code inspection issues in pulsar broker tests
URL: https://github.com/apache/pulsar/pull/5019#discussion_r317417057
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/PulsarBrokerStarterTest.java
##########
@@ -44,7 +44,7 @@
private File createValidBrokerConfigFile() throws FileNotFoundException {
File testConfigFile = new File("tmp." + System.currentTimeMillis() + ".properties");
if (testConfigFile.exists()) {
- testConfigFile.delete();
+ assert testConfigFile.delete();
Review comment:
don't use `assert`. please use testng assertions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services