You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by tison <wa...@gmail.com> on 2023/05/14 07:28:43 UTC
[DISCUSS] Replace stale bot with ping-pong workflow
Hi devs,
Recently, I have handled a large number of stale issues and noticed that
periodically notifying users that "the issue is stale" without any human
reaction can be a frustrating experience, e.g., ISSUE-13925[1].
Learning from the INFRA JIRA project experience, I propose we replace the
stale bot with a ping-pong workflow. That is -
ping - Labeling waiting-for-reviewer on issue created and commented by
non-committers
pong - Labeling waiting-for-user on issue responded by committers
Here is a demo implementation[2] you can refer to and you can try the
workflow in my fork[3].
Previous references -
* The triage guide[4]
* [DISCUSS] Does stale bot make value for you?[5]
* [COMMITTER ATTENTION] You can close stale issues as not planned [6]
Looking forward to your feedback :D
Best,
tison.
[1] https://github.com/apache/pulsar/issues/13925
[2] https://github.com/apache/pulsar/pull/20319
[3] https://github.com/tisonkun/pulsar
[4] https://pulsar.apache.org/contribute/develop-triage
[5] https://lists.apache.org/thread/tv774jqohdpx8x0dymsskrd90xwwfvgp
[6] https://lists.apache.org/thread/x2c7xod8y0wvh14nsb6bknf0dq3r9gls
Re: [DISCUSS] Replace stale bot with ping-pong workflow
Posted by tison <wa...@gmail.com>.
Thank you!
I saw a few other complains for this "noise" from the issue author recently
also.
Since the real-world solution is handling issues effectively, I support
disable this action. Keep the PR open for a while to accept comments.
I'll merge this patch in the next monday if no more objection.
Best,
tison.
Asaf Mesika <as...@gmail.com> 于2023年11月9日周四 21:21写道：
> Submitted a PR to disable it: https://github.com/apache/pulsar/pull/21549
>
> On Tue, Nov 7, 2023 at 3:58 PM Asaf Mesika <as...@gmail.com> wrote:
>
> > Tison let's start as you suggested by disabling it
> >
> >
> > On Tue, May 16, 2023 at 5:13 AM Yunze Xu <xy...@apache.org> wrote:
> >
> >> +1 to me
> >>
> >> Thanks,
> >> Yunze
> >>
> >> On Sun, May 14, 2023 at 9:28 PM Dave Fisher <wa...@comcast.net>
> >> wrote:
> >> >
> >> > Hi -
> >> >
> >> > I have not looked at all your links but I think this is a great idea.
> >> This will help everyone pay attention better.
> >> >
> >> > Best,
> >> > Dave
> >> >
> >> > Sent from my iPhone
> >> >
> >> > > On May 14, 2023, at 12:33 AM, tison <wa...@gmail.com> wrote:
> >> > >
> >> > > Of course, changing the workflow cannot magically increase the
> >> bandwidth to
> >> > > handle stale issues. That is what the triage guide wants to
> encourage
> >> > > committers to practice. But such a move can reduce the frustrating
> >> > > experience and explicitly express who is responsible for taking the
> >> next
> >> > > action to nudge the conversation.
> >> > >
> >> > > Best,
> >> > > tison.
> >> > >
> >> > >
> >> > > tison <wa...@gmail.com> 于2023年5月14日周日 15:28写道：
> >> > >
> >> > >> Hi devs,
> >> > >>
> >> > >> Recently, I have handled a large number of stale issues and noticed
> >> that
> >> > >> periodically notifying users that "the issue is stale" without any
> >> human
> >> > >> reaction can be a frustrating experience, e.g., ISSUE-13925[1].
> >> > >>
> >> > >> Learning from the INFRA JIRA project experience, I propose we
> >> replace the
> >> > >> stale bot with a ping-pong workflow. That is -
> >> > >>
> >> > >> ping - Labeling waiting-for-reviewer on issue created and commented
> >> by
> >> > >> non-committers
> >> > >> pong - Labeling waiting-for-user on issue responded by committers
> >> > >>
> >> > >> Here is a demo implementation[2] you can refer to and you can try
> the
> >> > >> workflow in my fork[3].
> >> > >>
> >> > >> Previous references -
> >> > >>
> >> > >> * The triage guide[4]
> >> > >> * [DISCUSS] Does stale bot make value for you?[5]
> >> > >> * [COMMITTER ATTENTION] You can close stale issues as not planned
> [6]
> >> > >>
> >> > >> Looking forward to your feedback :D
> >> > >>
> >> > >> Best,
> >> > >> tison.
> >> > >>
> >> > >> [1] https://github.com/apache/pulsar/issues/13925
> >> > >> [2] https://github.com/apache/pulsar/pull/20319
> >> > >> [3] https://github.com/tisonkun/pulsar
> >> > >> [4] https://pulsar.apache.org/contribute/develop-triage
> >> > >> [5]
> https://lists.apache.org/thread/tv774jqohdpx8x0dymsskrd90xwwfvgp
> >> > >> [6]
> https://lists.apache.org/thread/x2c7xod8y0wvh14nsb6bknf0dq3r9gls
> >> > >>
> >> > >>
> >> >
> >>
> >
>
Re: [DISCUSS] Replace stale bot with ping-pong workflow
Posted by Asaf Mesika <as...@gmail.com>.
Submitted a PR to disable it: https://github.com/apache/pulsar/pull/21549
On Tue, Nov 7, 2023 at 3:58 PM Asaf Mesika <as...@gmail.com> wrote:
> Tison let's start as you suggested by disabling it
>
>
> On Tue, May 16, 2023 at 5:13 AM Yunze Xu <xy...@apache.org> wrote:
>
>> +1 to me
>>
>> Thanks,
>> Yunze
>>
>> On Sun, May 14, 2023 at 9:28 PM Dave Fisher <wa...@comcast.net>
>> wrote:
>> >
>> > Hi -
>> >
>> > I have not looked at all your links but I think this is a great idea.
>> This will help everyone pay attention better.
>> >
>> > Best,
>> > Dave
>> >
>> > Sent from my iPhone
>> >
>> > > On May 14, 2023, at 12:33 AM, tison <wa...@gmail.com> wrote:
>> > >
>> > > Of course, changing the workflow cannot magically increase the
>> bandwidth to
>> > > handle stale issues. That is what the triage guide wants to encourage
>> > > committers to practice. But such a move can reduce the frustrating
>> > > experience and explicitly express who is responsible for taking the
>> next
>> > > action to nudge the conversation.
>> > >
>> > > Best,
>> > > tison.
>> > >
>> > >
>> > > tison <wa...@gmail.com> 于2023年5月14日周日 15:28写道：
>> > >
>> > >> Hi devs,
>> > >>
>> > >> Recently, I have handled a large number of stale issues and noticed
>> that
>> > >> periodically notifying users that "the issue is stale" without any
>> human
>> > >> reaction can be a frustrating experience, e.g., ISSUE-13925[1].
>> > >>
>> > >> Learning from the INFRA JIRA project experience, I propose we
>> replace the
>> > >> stale bot with a ping-pong workflow. That is -
>> > >>
>> > >> ping - Labeling waiting-for-reviewer on issue created and commented
>> by
>> > >> non-committers
>> > >> pong - Labeling waiting-for-user on issue responded by committers
>> > >>
>> > >> Here is a demo implementation[2] you can refer to and you can try the
>> > >> workflow in my fork[3].
>> > >>
>> > >> Previous references -
>> > >>
>> > >> * The triage guide[4]
>> > >> * [DISCUSS] Does stale bot make value for you?[5]
>> > >> * [COMMITTER ATTENTION] You can close stale issues as not planned [6]
>> > >>
>> > >> Looking forward to your feedback :D
>> > >>
>> > >> Best,
>> > >> tison.
>> > >>
>> > >> [1] https://github.com/apache/pulsar/issues/13925
>> > >> [2] https://github.com/apache/pulsar/pull/20319
>> > >> [3] https://github.com/tisonkun/pulsar
>> > >> [4] https://pulsar.apache.org/contribute/develop-triage
>> > >> [5] https://lists.apache.org/thread/tv774jqohdpx8x0dymsskrd90xwwfvgp
>> > >> [6] https://lists.apache.org/thread/x2c7xod8y0wvh14nsb6bknf0dq3r9gls
>> > >>
>> > >>
>> >
>>
>
Re: [DISCUSS] Replace stale bot with ping-pong workflow
Posted by Asaf Mesika <as...@gmail.com>.
Tison let's start as you suggested by disabling it
On Tue, May 16, 2023 at 5:13 AM Yunze Xu <xy...@apache.org> wrote:
> +1 to me
>
> Thanks,
> Yunze
>
> On Sun, May 14, 2023 at 9:28 PM Dave Fisher <wa...@comcast.net> wrote:
> >
> > Hi -
> >
> > I have not looked at all your links but I think this is a great idea.
> This will help everyone pay attention better.
> >
> > Best,
> > Dave
> >
> > Sent from my iPhone
> >
> > > On May 14, 2023, at 12:33 AM, tison <wa...@gmail.com> wrote:
> > >
> > > Of course, changing the workflow cannot magically increase the
> bandwidth to
> > > handle stale issues. That is what the triage guide wants to encourage
> > > committers to practice. But such a move can reduce the frustrating
> > > experience and explicitly express who is responsible for taking the
> next
> > > action to nudge the conversation.
> > >
> > > Best,
> > > tison.
> > >
> > >
> > > tison <wa...@gmail.com> 于2023年5月14日周日 15:28写道：
> > >
> > >> Hi devs,
> > >>
> > >> Recently, I have handled a large number of stale issues and noticed
> that
> > >> periodically notifying users that "the issue is stale" without any
> human
> > >> reaction can be a frustrating experience, e.g., ISSUE-13925[1].
> > >>
> > >> Learning from the INFRA JIRA project experience, I propose we replace
> the
> > >> stale bot with a ping-pong workflow. That is -
> > >>
> > >> ping - Labeling waiting-for-reviewer on issue created and commented by
> > >> non-committers
> > >> pong - Labeling waiting-for-user on issue responded by committers
> > >>
> > >> Here is a demo implementation[2] you can refer to and you can try the
> > >> workflow in my fork[3].
> > >>
> > >> Previous references -
> > >>
> > >> * The triage guide[4]
> > >> * [DISCUSS] Does stale bot make value for you?[5]
> > >> * [COMMITTER ATTENTION] You can close stale issues as not planned [6]
> > >>
> > >> Looking forward to your feedback :D
> > >>
> > >> Best,
> > >> tison.
> > >>
> > >> [1] https://github.com/apache/pulsar/issues/13925
> > >> [2] https://github.com/apache/pulsar/pull/20319
> > >> [3] https://github.com/tisonkun/pulsar
> > >> [4] https://pulsar.apache.org/contribute/develop-triage
> > >> [5] https://lists.apache.org/thread/tv774jqohdpx8x0dymsskrd90xwwfvgp
> > >> [6] https://lists.apache.org/thread/x2c7xod8y0wvh14nsb6bknf0dq3r9gls
> > >>
> > >>
> >
>
Re: [DISCUSS] Replace stale bot with ping-pong workflow
Posted by Yunze Xu <xy...@apache.org>.
+1 to me
Thanks,
Yunze
On Sun, May 14, 2023 at 9:28 PM Dave Fisher <wa...@comcast.net> wrote:
>
> Hi -
>
> I have not looked at all your links but I think this is a great idea. This will help everyone pay attention better.
>
> Best,
> Dave
>
> Sent from my iPhone
>
> > On May 14, 2023, at 12:33 AM, tison <wa...@gmail.com> wrote:
> >
> > Of course, changing the workflow cannot magically increase the bandwidth to
> > handle stale issues. That is what the triage guide wants to encourage
> > committers to practice. But such a move can reduce the frustrating
> > experience and explicitly express who is responsible for taking the next
> > action to nudge the conversation.
> >
> > Best,
> > tison.
> >
> >
> > tison <wa...@gmail.com> 于2023年5月14日周日 15:28写道：
> >
> >> Hi devs,
> >>
> >> Recently, I have handled a large number of stale issues and noticed that
> >> periodically notifying users that "the issue is stale" without any human
> >> reaction can be a frustrating experience, e.g., ISSUE-13925[1].
> >>
> >> Learning from the INFRA JIRA project experience, I propose we replace the
> >> stale bot with a ping-pong workflow. That is -
> >>
> >> ping - Labeling waiting-for-reviewer on issue created and commented by
> >> non-committers
> >> pong - Labeling waiting-for-user on issue responded by committers
> >>
> >> Here is a demo implementation[2] you can refer to and you can try the
> >> workflow in my fork[3].
> >>
> >> Previous references -
> >>
> >> * The triage guide[4]
> >> * [DISCUSS] Does stale bot make value for you?[5]
> >> * [COMMITTER ATTENTION] You can close stale issues as not planned [6]
> >>
> >> Looking forward to your feedback :D
> >>
> >> Best,
> >> tison.
> >>
> >> [1] https://github.com/apache/pulsar/issues/13925
> >> [2] https://github.com/apache/pulsar/pull/20319
> >> [3] https://github.com/tisonkun/pulsar
> >> [4] https://pulsar.apache.org/contribute/develop-triage
> >> [5] https://lists.apache.org/thread/tv774jqohdpx8x0dymsskrd90xwwfvgp
> >> [6] https://lists.apache.org/thread/x2c7xod8y0wvh14nsb6bknf0dq3r9gls
> >>
> >>
>
Re: [DISCUSS] Replace stale bot with ping-pong workflow
Posted by Dave Fisher <wa...@comcast.net>.
Hi -
I have not looked at all your links but I think this is a great idea. This will help everyone pay attention better.
Best,
Dave
Sent from my iPhone
> On May 14, 2023, at 12:33 AM, tison <wa...@gmail.com> wrote:
>
> Of course, changing the workflow cannot magically increase the bandwidth to
> handle stale issues. That is what the triage guide wants to encourage
> committers to practice. But such a move can reduce the frustrating
> experience and explicitly express who is responsible for taking the next
> action to nudge the conversation.
>
> Best,
> tison.
>
>
> tison <wa...@gmail.com> 于2023年5月14日周日 15:28写道：
>
>> Hi devs,
>>
>> Recently, I have handled a large number of stale issues and noticed that
>> periodically notifying users that "the issue is stale" without any human
>> reaction can be a frustrating experience, e.g., ISSUE-13925[1].
>>
>> Learning from the INFRA JIRA project experience, I propose we replace the
>> stale bot with a ping-pong workflow. That is -
>>
>> ping - Labeling waiting-for-reviewer on issue created and commented by
>> non-committers
>> pong - Labeling waiting-for-user on issue responded by committers
>>
>> Here is a demo implementation[2] you can refer to and you can try the
>> workflow in my fork[3].
>>
>> Previous references -
>>
>> * The triage guide[4]
>> * [DISCUSS] Does stale bot make value for you?[5]
>> * [COMMITTER ATTENTION] You can close stale issues as not planned [6]
>>
>> Looking forward to your feedback :D
>>
>> Best,
>> tison.
>>
>> [1] https://github.com/apache/pulsar/issues/13925
>> [2] https://github.com/apache/pulsar/pull/20319
>> [3] https://github.com/tisonkun/pulsar
>> [4] https://pulsar.apache.org/contribute/develop-triage
>> [5] https://lists.apache.org/thread/tv774jqohdpx8x0dymsskrd90xwwfvgp
>> [6] https://lists.apache.org/thread/x2c7xod8y0wvh14nsb6bknf0dq3r9gls
>>
>>
Re: [DISCUSS] Replace stale bot with ping-pong workflow
Posted by tison <wa...@gmail.com>.
Of course, changing the workflow cannot magically increase the bandwidth to
handle stale issues. That is what the triage guide wants to encourage
committers to practice. But such a move can reduce the frustrating
experience and explicitly express who is responsible for taking the next
action to nudge the conversation.
Best,
tison.
tison <wa...@gmail.com> 于2023年5月14日周日 15:28写道：
> Hi devs,
>
> Recently, I have handled a large number of stale issues and noticed that
> periodically notifying users that "the issue is stale" without any human
> reaction can be a frustrating experience, e.g., ISSUE-13925[1].
>
> Learning from the INFRA JIRA project experience, I propose we replace the
> stale bot with a ping-pong workflow. That is -
>
> ping - Labeling waiting-for-reviewer on issue created and commented by
> non-committers
> pong - Labeling waiting-for-user on issue responded by committers
>
> Here is a demo implementation[2] you can refer to and you can try the
> workflow in my fork[3].
>
> Previous references -
>
> * The triage guide[4]
> * [DISCUSS] Does stale bot make value for you?[5]
> * [COMMITTER ATTENTION] You can close stale issues as not planned [6]
>
> Looking forward to your feedback :D
>
> Best,
> tison.
>
> [1] https://github.com/apache/pulsar/issues/13925
> [2] https://github.com/apache/pulsar/pull/20319
> [3] https://github.com/tisonkun/pulsar
> [4] https://pulsar.apache.org/contribute/develop-triage
> [5] https://lists.apache.org/thread/tv774jqohdpx8x0dymsskrd90xwwfvgp
> [6] https://lists.apache.org/thread/x2c7xod8y0wvh14nsb6bknf0dq3r9gls
>
>