You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zclllyybb (via GitHub)" <gi...@apache.org> on 2025/10/22 09:25:51 UTC
[PR] [Fix](function) Fix wrong nullable of floor/ceil functions [doris]
zclllyybb opened a new pull request, #57238:
URL: https://github.com/apache/doris/pull/57238
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
before:
```sql
mysql> select minute_ceil(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0)), nullable(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0))));
ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.3)[INTERNAL_ERROR]Column VectorizedFnCall[minute_ceil](arguments=DateTimeV2(0), VectorizedFnCall[nullable](arguments=DateTimeV2(0),return=Nullable(DateTimeV2(0))),return=Nullable(DateTimeV2(0))) in block is not compatible with its column type :Const(DATETIMEV2), data type :Nullable(DateTimeV2(0)), error: Column type Const(DATETIMEV2) is not compatible with data type Nullable(DateTimeV2(0))
```
now:
```sql
mysql> select minute_ceil(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0)), nullable(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0))));
+-------------------------------------------------------------------------------------------------------------------+
| minute_ceil(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0)), nullable(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0)))) |
+-------------------------------------------------------------------------------------------------------------------+
| 2021-12-31 12:23:34 |
+-------------------------------------------------------------------------------------------------------------------+
```
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [x] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](function) Fix wrong nullable of floor/ceil functions [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57238:
URL: https://github.com/apache/doris/pull/57238#issuecomment-3432077068
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (2/2)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57238_b8486c8abbf0144be80c6e21d609f68d38258310_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57238_b8486c8abbf0144be80c6e21d609f68d38258310_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.43% (23891/33446) |
| Line Coverage | 57.85% (248597/429752) |
| Region Coverage | 53.02% (206529/389567) |
| Branch Coverage | 54.77% (88905/162315) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](function) Fix wrong nullable of floor/ceil functions [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57238:
URL: https://github.com/apache/doris/pull/57238#issuecomment-3431348008
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](function) Fix wrong nullable of floor/ceil functions [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb merged PR #57238:
URL: https://github.com/apache/doris/pull/57238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](function) Fix wrong nullable of floor/ceil functions [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57238:
URL: https://github.com/apache/doris/pull/57238#issuecomment-3431347731
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](function) Fix wrong nullable of floor/ceil functions [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57238:
URL: https://github.com/apache/doris/pull/57238#issuecomment-3431531019
<details>
<summary>ClickBench: <b>Total hot run time: 27.43 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b8486c8abbf0144be80c6e21d609f68d38258310, data reload: false
query1 0.06 0.05 0.04
query2 0.10 0.06 0.05
query3 0.26 0.09 0.08
query4 1.61 0.13 0.12
query5 0.29 0.26 0.26
query6 1.17 0.66 0.65
query7 0.04 0.03 0.03
query8 0.06 0.05 0.05
query9 0.63 0.53 0.52
query10 0.60 0.59 0.58
query11 0.18 0.11 0.12
query12 0.15 0.13 0.12
query13 0.62 0.62 0.59
query14 1.01 1.02 1.02
query15 0.87 0.85 0.86
query16 0.40 0.39 0.38
query17 1.03 1.04 1.04
query18 0.22 0.21 0.20
query19 1.97 1.74 1.88
query20 0.01 0.01 0.02
query21 15.42 0.19 0.13
query22 5.05 0.07 0.06
query23 15.66 0.27 0.10
query24 3.24 0.86 0.30
query25 0.09 0.06 0.06
query26 0.15 0.13 0.14
query27 0.07 0.06 0.05
query28 4.39 1.16 0.94
query29 12.57 3.95 3.28
query30 0.29 0.13 0.12
query31 2.82 0.60 0.38
query32 3.24 0.55 0.47
query33 3.02 3.15 3.05
query34 15.91 5.16 4.51
query35 4.62 4.65 4.55
query36 0.68 0.51 0.49
query37 0.11 0.07 0.08
query38 0.06 0.05 0.04
query39 0.04 0.04 0.03
query40 0.18 0.15 0.14
query41 0.09 0.04 0.03
query42 0.05 0.04 0.03
query43 0.05 0.03 0.03
Total cold run time: 99.08 s
Total hot run time: 27.43 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](function) Fix wrong nullable of floor/ceil functions [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #57238:
URL: https://github.com/apache/doris/pull/57238#issuecomment-3431333425
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](function) Fix wrong nullable of floor/ceil functions [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #57238:
URL: https://github.com/apache/doris/pull/57238#issuecomment-3431333616
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](function) Fix wrong nullable of floor/ceil functions [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57238:
URL: https://github.com/apache/doris/pull/57238#issuecomment-3431631659
# BE UT Coverage Report
Increment line coverage `50.00% (1/2)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/b8486c8abbf0144be80c6e21d609f68d38258310_b8486c8abbf0144be80c6e21d609f68d38258310/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/b8486c8abbf0144be80c6e21d609f68d38258310_b8486c8abbf0144be80c6e21d609f68d38258310/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.64% (17933/34065) |
| Line Coverage | 37.89% (162703/429459) |
| Region Coverage | 32.31% (124181/384318) |
| Branch Coverage | 33.70% (54375/161340) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org