You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "holdenk (via GitHub)" <gi...@apache.org> on 2026/09/26 02:26:54 UTC
[PR] [SPARK-59087][4.0][CONNECT][FOLLOWUP] Add extraServerConfs hook to SparkConnectServerTest [spark]
holdenk opened a new pull request, #59065:
URL: https://github.com/apache/spark/pull/59065
### What changes were proposed in this pull request?
Backport the `extraServerConfs` hook in `SparkConnectServerTest` from master (added by SPARK-58094) so the SPARK-59087 backport's `SparkConnectAuthSuite` compiles on this branch.
### Why are the changes needed?
The SPARK-59087 backport broke the connect test compile here: `SparkConnectAuthSuite` overrides `extraServerConfs`, which only exists on branches that have SPARK-58094 (master, branch-4.x, branch-4.3).
```
[error] sql/connect/server/src/test/scala/org/apache/spark/sql/connect/service/SparkConnectAuthSuite.scala:56:26: method extraServerConfs overrides nothing
```
### Does this PR introduce _any_ user-facing change?
No, test code only.
### How was this patch tested?
`build/sbt -Phive connect/Test/compile` (red before, green now) and `build/sbt -Phive 'connect/testOnly *SparkConnectAuthSuite'` -- 3/3 pass.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Cursor
Made with [Cursor](https://cursor.com)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59087][4.0][CONNECT][FOLLOWUP] Add extraServerConfs hook to SparkConnectServerTest [spark]
Posted by "holdenk (via GitHub)" <gi...@apache.org>.
holdenk commented on PR #59065:
URL: https://github.com/apache/spark/pull/59065#issuecomment-5842811384
Merged to 4.0 (compile passes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59087][4.0][CONNECT][FOLLOWUP] Add extraServerConfs hook to SparkConnectServerTest [spark]
Posted by "holdenk (via GitHub)" <gi...@apache.org>.
holdenk closed pull request #59065: [SPARK-59087][4.0][CONNECT][FOLLOWUP] Add extraServerConfs hook to SparkConnectServerTest
URL: https://github.com/apache/spark/pull/59065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org