You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/12/22 09:35:37 UTC
[GitHub] [commons-lang] arturobernalg opened a new pull request #682: [LANG-1631] - Check if Character is defined
arturobernalg opened a new pull request #682:
URL: https://github.com/apache/commons-lang/pull/682
Crash when search value it's out of range >= '\u0000' <= '\uFFFF'
Getting -->
java.lang.IllegalArgumentException: Not a valid Unicode code point: 0xFFFFF936
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #682: [LANG-1631] - Check if Character is defined
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #682:
URL: https://github.com/apache/commons-lang/pull/682#issuecomment-749489826
[](https://coveralls.io/builds/35895508)
Coverage increased (+0.007%) to 95.022% when pulling **d21636a09afcf0739c400e01d266c00311bc5d17 on arturobernalg:bugfix/LANG-1631** into **0a4505fa97ef0ff67d3b932b7e6a015a630275ac on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] arturobernalg commented on a change in pull request #682: [LANG-1631] - Check if Character is defined
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #682:
URL: https://github.com/apache/commons-lang/pull/682#discussion_r547399966
##########
File path: src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java
##########
@@ -506,42 +510,57 @@ public void testIndexOfIgnoreCase_StringInt() {
assertEquals(4, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 2));
assertEquals(4, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 3));
assertEquals(4, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 4));
- assertEquals(-1, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 5));
- assertEquals(-1, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 6));
- assertEquals(-1, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 7));
- assertEquals(-1, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 8));
+ assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 5));
+ assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 6));
+ assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 7));
+ assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 8));
assertEquals(1, StringUtils.indexOfIgnoreCase("aab", "AB", 1));
assertEquals(5, StringUtils.indexOfIgnoreCase("aabaabaa", "", 5));
- assertEquals(-1, StringUtils.indexOfIgnoreCase("ab", "AAB", 0));
- assertEquals(-1, StringUtils.indexOfIgnoreCase("aab", "AAB", 1));
- assertEquals(-1, StringUtils.indexOfIgnoreCase("abc", "", 9));
+ assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("ab", "AAB", 0));
+ assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("aab", "AAB", 1));
+ assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("abc", "", 9));
}
@Test
public void testLastIndexOf_char() {
- assertEquals(-1, StringUtils.lastIndexOf(null, ' '));
- assertEquals(-1, StringUtils.lastIndexOf("", ' '));
+ assertEquals(NOT_FOUND, StringUtils.lastIndexOf(null, ' '));
+ assertEquals(NOT_FOUND, StringUtils.lastIndexOf("", ' '));
assertEquals(7, StringUtils.lastIndexOf("aabaabaa", 'a'));
assertEquals(5, StringUtils.lastIndexOf("aabaabaa", 'b'));
assertEquals(5, StringUtils.lastIndexOf(new StringBuilder("aabaabaa"), 'b'));
+ char[] charArray = new char[9];
+ charArray[0] = '[';
+ charArray[1] = '&';
+ charArray[7] = '{';
+ charArray[3] = '.';
+ charArray[4] = 'c';
+ charArray[5] = '.';
+ charArray[6] = '0';
+ charArray[7] = 'r';
+ charArray[8] = 'o';
+ CharBuffer charBuffer = CharBuffer.wrap(charArray);
+ assertEquals(NOT_FOUND, StringUtils.lastIndexOf (charBuffer, (-1738), 982));
Review comment:
mmm
- The parentheses was a mistake
- The Character in the test there are not valid unicode values
- I'll change the test for --> CharBuffer.wrap(String)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] arturobernalg commented on a change in pull request #682: [LANG-1631] - Check if Character is defined
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #682:
URL: https://github.com/apache/commons-lang/pull/682#discussion_r547365219
##########
File path: src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java
##########
@@ -506,42 +510,57 @@ public void testIndexOfIgnoreCase_StringInt() {
assertEquals(4, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 2));
assertEquals(4, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 3));
assertEquals(4, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 4));
- assertEquals(-1, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 5));
- assertEquals(-1, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 6));
- assertEquals(-1, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 7));
- assertEquals(-1, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 8));
+ assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 5));
+ assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 6));
+ assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 7));
+ assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 8));
assertEquals(1, StringUtils.indexOfIgnoreCase("aab", "AB", 1));
assertEquals(5, StringUtils.indexOfIgnoreCase("aabaabaa", "", 5));
- assertEquals(-1, StringUtils.indexOfIgnoreCase("ab", "AAB", 0));
- assertEquals(-1, StringUtils.indexOfIgnoreCase("aab", "AAB", 1));
- assertEquals(-1, StringUtils.indexOfIgnoreCase("abc", "", 9));
+ assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("ab", "AAB", 0));
+ assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("aab", "AAB", 1));
+ assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("abc", "", 9));
}
@Test
public void testLastIndexOf_char() {
- assertEquals(-1, StringUtils.lastIndexOf(null, ' '));
- assertEquals(-1, StringUtils.lastIndexOf("", ' '));
+ assertEquals(NOT_FOUND, StringUtils.lastIndexOf(null, ' '));
+ assertEquals(NOT_FOUND, StringUtils.lastIndexOf("", ' '));
assertEquals(7, StringUtils.lastIndexOf("aabaabaa", 'a'));
assertEquals(5, StringUtils.lastIndexOf("aabaabaa", 'b'));
assertEquals(5, StringUtils.lastIndexOf(new StringBuilder("aabaabaa"), 'b'));
+ char[] charArray = new char[9];
+ charArray[0] = '[';
+ charArray[1] = '&';
+ charArray[7] = '{';
+ charArray[3] = '.';
+ charArray[4] = 'c';
+ charArray[5] = '.';
+ charArray[6] = '0';
+ charArray[7] = 'r';
+ charArray[8] = 'o';
+ CharBuffer charBuffer = CharBuffer.wrap(charArray);
+ assertEquals(NOT_FOUND, StringUtils.lastIndexOf (charBuffer, (-1738), 982));
Review comment:
HI @garydgregory
sorry for the noise. When I created the PR it seemed logical. But you're right. Better keep the PRs separate
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a change in pull request #682: [LANG-1631] - Check if Character is defined
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #682:
URL: https://github.com/apache/commons-lang/pull/682#discussion_r547390532
##########
File path: src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java
##########
@@ -506,42 +510,57 @@ public void testIndexOfIgnoreCase_StringInt() {
assertEquals(4, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 2));
assertEquals(4, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 3));
assertEquals(4, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 4));
- assertEquals(-1, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 5));
- assertEquals(-1, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 6));
- assertEquals(-1, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 7));
- assertEquals(-1, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 8));
+ assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 5));
+ assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 6));
+ assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 7));
+ assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 8));
assertEquals(1, StringUtils.indexOfIgnoreCase("aab", "AB", 1));
assertEquals(5, StringUtils.indexOfIgnoreCase("aabaabaa", "", 5));
- assertEquals(-1, StringUtils.indexOfIgnoreCase("ab", "AAB", 0));
- assertEquals(-1, StringUtils.indexOfIgnoreCase("aab", "AAB", 1));
- assertEquals(-1, StringUtils.indexOfIgnoreCase("abc", "", 9));
+ assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("ab", "AAB", 0));
+ assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("aab", "AAB", 1));
+ assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("abc", "", 9));
}
@Test
public void testLastIndexOf_char() {
- assertEquals(-1, StringUtils.lastIndexOf(null, ' '));
- assertEquals(-1, StringUtils.lastIndexOf("", ' '));
+ assertEquals(NOT_FOUND, StringUtils.lastIndexOf(null, ' '));
+ assertEquals(NOT_FOUND, StringUtils.lastIndexOf("", ' '));
assertEquals(7, StringUtils.lastIndexOf("aabaabaa", 'a'));
assertEquals(5, StringUtils.lastIndexOf("aabaabaa", 'b'));
assertEquals(5, StringUtils.lastIndexOf(new StringBuilder("aabaabaa"), 'b'));
+ char[] charArray = new char[9];
+ charArray[0] = '[';
+ charArray[1] = '&';
+ charArray[7] = '{';
+ charArray[3] = '.';
+ charArray[4] = 'c';
+ charArray[5] = '.';
+ charArray[6] = '0';
+ charArray[7] = 'r';
+ charArray[8] = 'o';
+ CharBuffer charBuffer = CharBuffer.wrap(charArray);
+ assertEquals(NOT_FOUND, StringUtils.lastIndexOf (charBuffer, (-1738), 982));
Review comment:
Hi @arturobernalg
You've not answered all my question.
Also why are you building the char[] one char at a time? Why not call CharBuffer.wrap(String)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] arturobernalg commented on a change in pull request #682: [LANG-1631] - Check if Character is defined
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #682:
URL: https://github.com/apache/commons-lang/pull/682#discussion_r547511368
##########
File path: src/main/java/org/apache/commons/lang3/CharSequenceUtils.java
##########
@@ -109,6 +109,7 @@ static int indexOf(final CharSequence cs, final int searchChar, int start) {
return i;
}
}
+ return NOT_FOUND;
Review comment:
idem @garydgregory
##########
File path: src/main/java/org/apache/commons/lang3/CharSequenceUtils.java
##########
@@ -195,6 +196,7 @@ static int lastIndexOf(final CharSequence cs, final int searchChar, int start) {
return i;
}
}
+ return NOT_FOUND;
Review comment:
mm . Maybe it's my fault.
The idea it's exit the loop and return -1 (NOT_FOUND) if not found the charset
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a change in pull request #682: [LANG-1631] - Check if Character is defined
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #682:
URL: https://github.com/apache/commons-lang/pull/682#discussion_r548012329
##########
File path: src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java
##########
@@ -48,6 +49,8 @@
private static final String[] FOOBAR_SUB_ARRAY = new String[] {"ob", "ba"};
+ private static final int NOT_FOUND = -1;
Review comment:
This is already defined in `ArrayUtils`, please reuse.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #682: [LANG-1631] - Check if Character is defined
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #682:
URL: https://github.com/apache/commons-lang/pull/682#issuecomment-749489826
[](https://coveralls.io/builds/35920178)
Coverage increased (+0.0006%) to 95.018% when pulling **410591674133539c5d053c61bd22f0a3b0282e27 on arturobernalg:bugfix/LANG-1631** into **157ba27be7bfff51dd55c4e322bbe795ee9689fd on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory merged pull request #682: [LANG-1631] - Check if Character is defined
Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #682:
URL: https://github.com/apache/commons-lang/pull/682
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] arturobernalg commented on a change in pull request #682: [LANG-1631] - Check if Character is defined
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #682:
URL: https://github.com/apache/commons-lang/pull/682#discussion_r547590065
##########
File path: src/main/java/org/apache/commons/lang3/CharSequenceUtils.java
##########
@@ -195,6 +196,7 @@ static int lastIndexOf(final CharSequence cs, final int searchChar, int start) {
return i;
}
}
+ return NOT_FOUND;
Review comment:
sorry. my fault for mixing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a change in pull request #682: [LANG-1631] - Check if Character is defined
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #682:
URL: https://github.com/apache/commons-lang/pull/682#discussion_r547589700
##########
File path: src/main/java/org/apache/commons/lang3/CharSequenceUtils.java
##########
@@ -195,6 +196,7 @@ static int lastIndexOf(final CharSequence cs, final int searchChar, int start) {
return i;
}
}
+ return NOT_FOUND;
Review comment:
ah, I see, this is a new line, and the other mods are updates. ok, I'll take a look tomorrow probably...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a change in pull request #682: [LANG-1631] - Check if Character is defined
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #682:
URL: https://github.com/apache/commons-lang/pull/682#discussion_r547325346
##########
File path: src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java
##########
@@ -506,42 +510,57 @@ public void testIndexOfIgnoreCase_StringInt() {
assertEquals(4, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 2));
assertEquals(4, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 3));
assertEquals(4, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 4));
- assertEquals(-1, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 5));
- assertEquals(-1, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 6));
- assertEquals(-1, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 7));
- assertEquals(-1, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 8));
+ assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 5));
+ assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 6));
+ assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 7));
+ assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 8));
assertEquals(1, StringUtils.indexOfIgnoreCase("aab", "AB", 1));
assertEquals(5, StringUtils.indexOfIgnoreCase("aabaabaa", "", 5));
- assertEquals(-1, StringUtils.indexOfIgnoreCase("ab", "AAB", 0));
- assertEquals(-1, StringUtils.indexOfIgnoreCase("aab", "AAB", 1));
- assertEquals(-1, StringUtils.indexOfIgnoreCase("abc", "", 9));
+ assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("ab", "AAB", 0));
+ assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("aab", "AAB", 1));
+ assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("abc", "", 9));
}
@Test
public void testLastIndexOf_char() {
- assertEquals(-1, StringUtils.lastIndexOf(null, ' '));
- assertEquals(-1, StringUtils.lastIndexOf("", ' '));
+ assertEquals(NOT_FOUND, StringUtils.lastIndexOf(null, ' '));
+ assertEquals(NOT_FOUND, StringUtils.lastIndexOf("", ' '));
assertEquals(7, StringUtils.lastIndexOf("aabaabaa", 'a'));
assertEquals(5, StringUtils.lastIndexOf("aabaabaa", 'b'));
assertEquals(5, StringUtils.lastIndexOf(new StringBuilder("aabaabaa"), 'b'));
+ char[] charArray = new char[9];
+ charArray[0] = '[';
+ charArray[1] = '&';
+ charArray[7] = '{';
+ charArray[3] = '.';
+ charArray[4] = 'c';
+ charArray[5] = '.';
+ charArray[6] = '0';
+ charArray[7] = 'r';
+ charArray[8] = 'o';
+ CharBuffer charBuffer = CharBuffer.wrap(charArray);
+ assertEquals(NOT_FOUND, StringUtils.lastIndexOf (charBuffer, (-1738), 982));
Review comment:
Hi @arturobernalg
Thank you for your PR.
PS: It's harder to deal with a PR like this because it mixes a change with some clean ups (-1 -> NOT_FOUND) so I am not sure where the new test is without trolling through all the noise :-(
Why is the number in parentheses? If this is a test for the actual bug fix, then you should add a sanity check to validates that the char is indeed bogus.
TY.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #682: [LANG-1631] - Check if Character is defined
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #682:
URL: https://github.com/apache/commons-lang/pull/682#issuecomment-749489826
[](https://coveralls.io/builds/35895145)
Coverage increased (+0.0006%) to 95.015% when pulling **6efe5c5e8b8595895adcb825c5b3d802b961d88e on arturobernalg:bugfix/LANG-1631** into **0a4505fa97ef0ff67d3b932b7e6a015a630275ac on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls commented on pull request #682: [LANG-1631] - Check if Character is defined
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #682:
URL: https://github.com/apache/commons-lang/pull/682#issuecomment-749489826
[](https://coveralls.io/builds/35888850)
Coverage increased (+0.007%) to 95.022% when pulling **ced8a0b0f78e80c906363a20027fdea2cf474b69 on arturobernalg:bugfix/LANG-1631** into **b4456352bcbe3672afba526ea143fca7a53f7843 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory removed a comment on pull request #682: [LANG-1631] - Check if Character is defined
Posted by GitBox <gi...@apache.org>.
garydgregory removed a comment on pull request #682:
URL: https://github.com/apache/commons-lang/pull/682#issuecomment-749752800
@arturobernalg
Now, I'm confused. There are now no changes here for "Check if Character is defined".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #682: [LANG-1631] - Check if Character is defined
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #682:
URL: https://github.com/apache/commons-lang/pull/682#issuecomment-749752800
@arturobernalg
Now, I'm confused. There are now no changes here for "Check if Character is defined".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #682: [LANG-1631] - Check if Character is defined
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #682:
URL: https://github.com/apache/commons-lang/pull/682#issuecomment-749489826
[](https://coveralls.io/builds/35897806)
Coverage increased (+0.0006%) to 95.015% when pulling **599fefad2712e0f1019b2bceecce0da74716201a on arturobernalg:bugfix/LANG-1631** into **0a4505fa97ef0ff67d3b932b7e6a015a630275ac on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a change in pull request #682: [LANG-1631] - Check if Character is defined
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #682:
URL: https://github.com/apache/commons-lang/pull/682#discussion_r548012329
##########
File path: src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java
##########
@@ -48,6 +49,8 @@
private static final String[] FOOBAR_SUB_ARRAY = new String[] {"ob", "ba"};
+ private static final int NOT_FOUND = -1;
Review comment:
This is already defined in `ArrayUtils`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a change in pull request #682: [LANG-1631] - Check if Character is defined
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #682:
URL: https://github.com/apache/commons-lang/pull/682#discussion_r548012329
##########
File path: src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java
##########
@@ -48,6 +49,8 @@
private static final String[] FOOBAR_SUB_ARRAY = new String[] {"ob", "ba"};
+ private static final int NOT_FOUND = -1;
Review comment:
This is already defined in `StringUtils.INDEX_NOT_FOUND`, please reuse.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #682: [LANG-1631] - Check if Character is defined
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #682:
URL: https://github.com/apache/commons-lang/pull/682#issuecomment-749489826
[](https://coveralls.io/builds/35895329)
Coverage increased (+0.0006%) to 95.015% when pulling **6efe5c5e8b8595895adcb825c5b3d802b961d88e on arturobernalg:bugfix/LANG-1631** into **0a4505fa97ef0ff67d3b932b7e6a015a630275ac on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a change in pull request #682: [LANG-1631] - Check if Character is defined
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #682:
URL: https://github.com/apache/commons-lang/pull/682#discussion_r548012329
##########
File path: src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java
##########
@@ -48,6 +49,8 @@
private static final String[] FOOBAR_SUB_ARRAY = new String[] {"ob", "ba"};
+ private static final int NOT_FOUND = -1;
Review comment:
This is already defined in `StringUtils.INDEX_NOT_FOUND` and `ArrayUtils`, please reuse.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] arturobernalg commented on a change in pull request #682: [LANG-1631] - Check if Character is defined
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #682:
URL: https://github.com/apache/commons-lang/pull/682#discussion_r548039151
##########
File path: src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java
##########
@@ -48,6 +49,8 @@
private static final String[] FOOBAR_SUB_ARRAY = new String[] {"ob", "ba"};
+ private static final int NOT_FOUND = -1;
Review comment:
true. changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org