You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/07/11 04:43:56 UTC

[GitHub] [incubator-mxnet] kshitij12345 commented on issue #15331: [fix] missing input log higher order.

kshitij12345 commented on issue #15331: [fix] missing input log higher order.
URL: https://github.com/apache/incubator-mxnet/pull/15331#issuecomment-510326851
 
 
   https://github.com/apache/incubator-mxnet/blob/5171e1d92cfc5eefa2c20dfe8ac3fac5351ad19a/src/operator/tensor/elemwise_unary_op_basic.cc#L1120
   `dL/dygrad` for this one right?
   
   @larroy @apeforest , I was also wondering if we can check the number of inputs passed at compile time? I have observed the `MakeNode` gets the Op from dynamic registry based on the name. However we actually have information about the number of inputs and outputs for a given Op at compile time.  I tried but couldn't actually figure out. What are your thoughts? How easy or hard would it be to check for valid number of inputs in `MakeNode`? This would help catch these sort of errors at compile time itself. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services