You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:13:22 UTC
[GitHub] [arrow] bridgream opened a new issue #10555: Quotation Marks around CMake Variable?
bridgream opened a new issue #10555:
URL: https://github.com/apache/arrow/issues/10555
https://github.com/apache/arrow/blob/f1e3c2e557bb3622b203fb270bf0329f53f1e617/cpp/src/arrow/io/CMakeLists.txt#L33
Should this line be `if(NOT ("${ARROW_SIMD_LEVEL}" STREQUAL "NONE"))` where `${ARROW_SIMD_LEVEL}` be wrapped by quotation marks? Otherwise if `${ARROW_SIMD_LEVEL}` is empty (observed if processed with `ExternalProject_Add`), `STREQUAL` will compare `(` and `"NONE"`, leaving an unmatched right parenthesis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bridgream commented on issue #10555: Quotation Marks around CMake Variable?
Posted by GitBox <gi...@apache.org>.
bridgream commented on issue #10555:
URL: https://github.com/apache/arrow/issues/10555#issuecomment-865097735
I wasn't able to reproduce the issue using the same code. The original code works in a loop test using the same code where I spotted the problem. Could be a cache issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bridgream commented on issue #10555: Quotation Marks around CMake Variable?
Posted by GitBox <gi...@apache.org>.
bridgream commented on issue #10555:
URL: https://github.com/apache/arrow/issues/10555#issuecomment-865097735
I wasn't able to reproduce the issue using the same code. The original code works in a loop test using the same code where I spotted the problem. Could be a cache issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #10555: Quotation Marks around CMake Variable?
Posted by GitBox <gi...@apache.org>.
kou commented on issue #10555:
URL: https://github.com/apache/arrow/issues/10555#issuecomment-864260204
We use `SSE4_2` as the default `ARROW_SIMD_LEVEL`. Why does `ExternalProject_Add` set an empty string to it? Could you show the `ExternalProject_Add(...)` that reproduces the case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bridgream closed issue #10555: Quotation Marks around CMake Variable?
Posted by GitBox <gi...@apache.org>.
bridgream closed issue #10555:
URL: https://github.com/apache/arrow/issues/10555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bridgream closed issue #10555: Quotation Marks around CMake Variable?
Posted by GitBox <gi...@apache.org>.
bridgream closed issue #10555:
URL: https://github.com/apache/arrow/issues/10555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org