You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/08/31 05:18:35 UTC
[GitHub] [ozone] kerneltime commented on a diff in pull request #3731: HDDS-7186. Add support for Rocksdb user info LOG configure.
kerneltime commented on code in PR #3731:
URL: https://github.com/apache/ozone/pull/3731#discussion_r959168637
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -72,6 +73,16 @@ public class DatanodeConfiguration {
Duration.ofMinutes(10).toMillis();
static final boolean CONTAINER_SCHEMA_V3_ENABLED_DEFAULT = false;
+ static final long ROCKSDB_LOG_MAX_FILE_SIZE_DEFAULT = 8 * 1024 * 1024;
+ static final int ROCKSDB_LOG_MAX_FILE_NUM_DEFAULT = 100;
+ static final long ROCKSDB_DELETE_OBSOLETE_FILES_PERIOD_DEFAULT =
+ 6 * 60 * 60 * 1000 * 1000;
+ public static final String ROCKSDB_LOG_MAX_FILE_SIZE_KEY =
Review Comment:
```suggestion
public static final String ROCKSDB_LOG_MAX_FILE_BYTES_SIZE_KEY =
```
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -72,6 +73,16 @@ public class DatanodeConfiguration {
Duration.ofMinutes(10).toMillis();
static final boolean CONTAINER_SCHEMA_V3_ENABLED_DEFAULT = false;
+ static final long ROCKSDB_LOG_MAX_FILE_SIZE_DEFAULT = 8 * 1024 * 1024;
Review Comment:
```suggestion
static final long ROCKSDB_LOG_MAX_FILE_SIZE_BYTES_DEFAULT = 8 * 1024 * 1024;
```
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -72,6 +73,16 @@ public class DatanodeConfiguration {
Duration.ofMinutes(10).toMillis();
static final boolean CONTAINER_SCHEMA_V3_ENABLED_DEFAULT = false;
+ static final long ROCKSDB_LOG_MAX_FILE_SIZE_DEFAULT = 8 * 1024 * 1024;
+ static final int ROCKSDB_LOG_MAX_FILE_NUM_DEFAULT = 100;
+ static final long ROCKSDB_DELETE_OBSOLETE_FILES_PERIOD_DEFAULT =
Review Comment:
Guessing this is micro seconds
```suggestion
static final long ROCKSDB_DELETE_OBSOLETE_FILES_PERIOD_MICRO_SECONDS_DEFAULT =
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org