You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Henri Yandell (JIRA)" <ji...@apache.org> on 2008/05/08 08:50:55 UTC
[jira] Commented: (CLI-149) MissingOptionException.getMessage()
changed from CLI 1.0 > 1.1
[ https://issues.apache.org/jira/browse/CLI-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595130#action_12595130 ]
Henri Yandell commented on CLI-149:
-----------------------------------
Agreed on the whitespace. I don't see why it should be:
Missing required options: format, source, properties
> MissingOptionException.getMessage() changed from CLI 1.0 > 1.1
> --------------------------------------------------------------
>
> Key: CLI-149
> URL: https://issues.apache.org/jira/browse/CLI-149
> Project: Commons CLI
> Issue Type: Bug
> Components: CLI-1.x
> Affects Versions: 1.1
> Reporter: Nathan Niesen
> Fix For: 1.2
>
>
> The MissingOptionException.getMessage() string changed from CLI 1.0 > 1.1.
> CLI 1.0 was poorly formatted but readable:
> Missing required options: -format-source-properties
> CLI 1.1 is almost unreadable:
> Missing required options: formatsourceproperties
> In CLI 1.0 Options.addOption(Option) prefixed the stored options with a "-" and in CLI 1.1 it doesn't.
> I would suggest changing Parser.checkRequiredOptions() to add the options to the error message with a prefix of " -":
> OLD:
> // loop through the required options
> while (iter.hasNext())
> {
> buff.append(iter.next());
> }
> NEW:
> // loop through the required options
> while (iter.hasNext())
> {
> buff.append(" -" + iter.next());
> }
> Resulting in:
> Missing required options: -format -source -properties
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.