You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/09/06 12:08:27 UTC
[GitHub] [incubator-doris] ccoffline opened a new pull request #6577: Custom config handler #6508
ccoffline opened a new pull request #6577:
URL: https://github.com/apache/incubator-doris/pull/6577
## Proposed changes
Support custom config handler callback and types.
## Types of changes
- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [ ] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
- [x] I have created an issue on (Fix #6508) and described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [x] Any dependent changes have been merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6577: Custom config handler #6508
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #6577:
URL: https://github.com/apache/incubator-doris/pull/6577#issuecomment-961855196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] ccoffline commented on pull request #6577: Custom config handler #6508
Posted by GitBox <gi...@apache.org>.
ccoffline commented on pull request #6577:
URL: https://github.com/apache/incubator-doris/pull/6577#issuecomment-914900742
> Could your explain more about `query traffic limit` in your issue #6508 ?
I didn't put `query traffic limit` in this pr. This is still experimental on one of our clusters.
Some users want to limit query more flexibly than `maxQueryInstances` #6159. For example, all query should be rejected when queryInstances of this user reach 30000, and big queries that queryInstances more than 1000 should be rejected when queryInstances of this user reach 20000. Limiting rules like this will be complex and need to be modified at any time.
So we add a config that support this feature, using `SpEL` to evaluate whether to limit a query or not. The limiting expressions will be reset at any time, and the `Expression` needed to be compile as soon as setting the config. This is what this pr for, I think more configs will need callback in the future.
We are using 0.13 and #6159 is not supported yet. In master, there is a similar feature `sql block rule` #6192 which can support `query traffic limit`, maybe add a `limit` property. So I won't push our traffic limit pr to master, but just add config handler to support config setting callback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6577: Custom config handler #6508
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #6577:
URL: https://github.com/apache/incubator-doris/pull/6577#issuecomment-961855196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6577: Custom config handler #6508
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #6577:
URL: https://github.com/apache/incubator-doris/pull/6577#issuecomment-961855196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #6577: Custom config handler #6508
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #6577:
URL: https://github.com/apache/incubator-doris/pull/6577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #6577: Custom config handler #6508
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #6577:
URL: https://github.com/apache/incubator-doris/pull/6577#issuecomment-914388651
Could your explain more about `query traffic limit` in your issue #6508 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] ccoffline commented on pull request #6577: Custom config handler #6508
Posted by GitBox <gi...@apache.org>.
ccoffline commented on pull request #6577:
URL: https://github.com/apache/incubator-doris/pull/6577#issuecomment-914904753
I just looked into #6192 and `sql block rule` cannot support traffic limit, but I think traffic limit is better set in the user properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org