You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2020/04/06 16:54:36 UTC
[GitHub] [tomcat] fhanik opened a new pull request #267: Remove reflection
from Connector.java
fhanik opened a new pull request #267: Remove reflection from Connector.java
URL: https://github.com/apache/tomcat/pull/267
I will start a discussion on dev@tomcat.apache.org
TL;DR; We are using Apache Tomcat embedded in native images (GraalVM).
Reflection causes images to be unnecessarily large, and Apache Tomcat has many places where reflection can be avoided in an embedded scenario.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] fhanik commented on issue #267: Remove reflection from
Connector.java
Posted by GitBox <gi...@apache.org>.
fhanik commented on issue #267: Remove reflection from Connector.java
URL: https://github.com/apache/tomcat/pull/267#issuecomment-610548217
AbstractProtocol and AbstractEndpoint use reflection for all property setters. This change is a step in the right direction, but only has minimal impact.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] fhanik closed pull request #267: Remove reflection from
Connector.java
Posted by GitBox <gi...@apache.org>.
fhanik closed pull request #267: Remove reflection from Connector.java
URL: https://github.com/apache/tomcat/pull/267
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] fhanik commented on issue #267: Remove reflection from
Connector.java
Posted by GitBox <gi...@apache.org>.
fhanik commented on issue #267: Remove reflection from Connector.java
URL: https://github.com/apache/tomcat/pull/267#issuecomment-611695084
Closed per discussion on mailing list
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rmaucher commented on issue #267: Remove reflection from
Connector.java
Posted by GitBox <gi...@apache.org>.
rmaucher commented on issue #267: Remove reflection from Connector.java
URL: https://github.com/apache/tomcat/pull/267#issuecomment-609967157
The main target of Tomcat remains Tomcat standalone, server.xml and the digester. So this means tons of reflection here and there, and I expect it will stay that way.
You're in luck here since the Connector is a mess and some things could be improved. You need to continue working on the PR though, as the code changed to be less messy already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org