You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/03/18 23:35:18 UTC

[GitHub] [solr] epugh opened a new pull request #30: SOLR-15161: Remove documentation about bad practices for json responses and mime types

epugh opened a new pull request #30:
URL: https://github.com/apache/solr/pull/30


   # Description
   
   Browsers now care if you are doing a JSONP call and they expect application/json, and block any text/plain mime type response.
   
   In Quepid we communicate the API command to update your JSONResponseWriter during your setup process, but it's still very confusing. It was a "cool hack" back when we first used it, but 10 years later, it's causing issues.
   
   This is a copy of https://github.com/apache/lucene-solr/pull/2436
   
   # Solution
   
   Remove hack, and add warning in the docs if you choose to do it.
   
   # Tests
   
   Reran tests.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [ X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [ X] I have created a Jira issue and added the issue ID to my pull request title.
   - [ X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [ X] I have developed this patch against the `main` branch.
   - [ X] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ X] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [solr] epugh merged pull request #30: SOLR-15161: Remove documentation about bad practices for json responses and mime types

Posted by GitBox <gi...@apache.org>.
epugh merged pull request #30:
URL: https://github.com/apache/solr/pull/30


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [solr] janhoy commented on pull request #30: SOLR-15161: Remove documentation about bad practices for json responses and mime types

Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #30:
URL: https://github.com/apache/solr/pull/30#issuecomment-804152043


   This shared branch can also be deleted :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org